An open source design system that's fully customizable and agent ready
TypeScript
fix(core): restore visible keyboard focus ring on Collapsible trigger (#3722)
Baraa Hamodi55fa7615d8e2
diff --git a/.changeset/collapsible-focus-ring.md b/.changeset/collapsible-focus-ring.mdnew file mode 100644index 0000000000..11a5d3cf66--- /dev/null+++ b/.changeset/collapsible-focus-ring.md@@ -0,0 +1,6 @@+---+'@astryxdesign/core': patch+---++[fix] Collapsible: the trigger button now shows a visible focus ring when focused via keyboard. The trigger's `all: unset` reset removed the browser's default outline without restoring a replacement, leaving keyboard focus invisible (WCAG 2.4.7). (#3722)+@bhamodidiff --git a/packages/core/src/Collapsible/Collapsible.tsx b/packages/core/src/Collapsible/Collapsible.tsxindex 939479a3ad..1c3174b7f4 100644--- a/packages/core/src/Collapsible/Collapsible.tsx+++ b/packages/core/src/Collapsible/Collapsible.tsx@@ -65,6 +65,16 @@ const styles = stylex.create({color: colorVars['--color-text-primary'],textAlign: 'start',paddingBlock: 0,+ // `all: unset` above wipes the UA focus outline; restore a keyboard-only+ // focus ring using the standard token/offset (WCAG 2.4.7).+ outline: {+ default: null,+ ':focus-visible': `2px solid ${colorVars['--color-accent']}`,+ },+ outlineOffset: {+ default: '0',+ ':focus-visible': '2px',+ },},// Capsize: trim leading from text triggerstriggerLabel: {