An open source design system that's fully customizable and agent ready
TypeScript
fix(docsite): keep Properties preview border framed, tidy Examples divider (#2989)
rubyycheung5bb73bdbcd5a
diff --git a/apps/docsite/src/components/component-detail/ComponentDetailClient.tsx b/apps/docsite/src/components/component-detail/ComponentDetailClient.tsxindex b1347fdc9b..c4ba1cc790 100644--- a/apps/docsite/src/components/component-detail/ComponentDetailClient.tsx+++ b/apps/docsite/src/components/component-detail/ComponentDetailClient.tsx@@ -12,7 +12,6 @@ import {Card} from '@astryxdesign/core/Card';import {Divider} from '@astryxdesign/core';import {CodeExampleBlock} from '../CodeExampleBlock';import {TabList, Tab} from '@astryxdesign/core/TabList';-import {useMediaQuery} from '@astryxdesign/core/hooks';import {ShowcasePreview} from './ShowcasePreview';import {ComponentPreviewTheme} from './ComponentPreviewTheme';import {BestPractices} from './BestPractices';@@ -34,6 +33,19 @@ const styles = stylex.create({section: {marginInline: 'auto',},+ previewStage: {+ position: 'sticky',+ top: 44,+ zIndex: 10,+ backgroundColor: 'var(--color-background-page)',+ backdropFilter: 'blur(16px)',+ maxHeight: {default: 400, '@media (max-width: 768px)': 250},+ overflow: 'auto',+ borderWidth: 'var(--border-width, 1px)',+ borderStyle: 'solid',+ borderColor: 'var(--color-border-emphasized)',+ borderRadius: 'var(--radius-container)',+ },});interface ComponentDetailClientProps {@@ -91,7 +103,6 @@ function OverviewContent({{(exampleRegistry[comp.name] || []).length > 0 && (<>- <Divider /><VStack gap={4}><Heading level={2} type="display-3">Examples@@ -124,7 +135,6 @@ function ComponentDetailInner({const isHook = comp.params != null;const hasShowcase = comp.name in showcaseRegistry;const hasPlayground = !isHook;- const isMobile = useMediaQuery('(max-width: 768px)');const tab = searchParams.get('tab') ?? 'overview';const setTab = (value: string) => {@@ -184,16 +194,7 @@ function ComponentDetailInner({{tab === 'properties' && (<VStack gap={4}>- <div- style={{- position: 'sticky',- top: 44,- zIndex: 10,- backgroundColor: 'var(--color-background-page)',- backdropFilter: 'blur(16px)',- maxHeight: isMobile ? 250 : 400,- overflow: 'auto',- }}>+ <div {...stylex.props(styles.previewStage)}><InteractivePreviewStagename={comp.name}state={state}@@ -201,6 +202,7 @@ function ComponentDetailInner({playground={comp.playground}missingRequiredProps={missingRequiredProps}onPropChange={setProp}+ embeddedcanControlOpenState={comp.props.some(prop => prop.name === 'isOpen') &&comp.props.some(prop => prop.name === 'onOpenChange')diff --git a/apps/docsite/src/components/component-detail/InteractivePreview.tsx b/apps/docsite/src/components/component-detail/InteractivePreview.tsxindex c3a5b0fe5a..1185a86ab7 100644--- a/apps/docsite/src/components/component-detail/InteractivePreview.tsx+++ b/apps/docsite/src/components/component-detail/InteractivePreview.tsx@@ -11,6 +11,7 @@ import {Component,type ReactNode,} from 'react';+import * as stylex from '@stylexjs/stylex';import {getComponent, resolveValue} from './resolveElements';import {Button} from '@astryxdesign/core/Button';import {Card} from '@astryxdesign/core/Card';@@ -34,6 +35,17 @@ import type {export type {KnobProp} from './interactiveState';+const styles = stylex.create({+ card: {+ width: '100%',+ position: 'relative',+ },+ // Flattens the Card corners when embedded in an already-framed container.+ flat: {+ borderRadius: 0,+ },+});+class PreviewErrorBoundary extends Component<{children: ReactNode; resetKeys: unknown[]},{error: Error | null}@@ -193,6 +205,7 @@ export function InteractivePreviewStage({missingRequiredProps = [],onPropChange,canControlOpenState = false,+ embedded = false,}: {name: string;state: Record<string, unknown>;@@ -201,6 +214,7 @@ export function InteractivePreviewStage({missingRequiredProps?: string[];onPropChange?: (propName: string, value: unknown) => void;canControlOpenState?: boolean;+ embedded?: boolean;}) {const [showCode, setShowCode] = useState(false);const Component = getComponent(name);@@ -242,7 +256,7 @@ export function InteractivePreviewStage({if (missingRequiredProps.length > 0) {return (<ComponentPreviewTheme>- <Card variant="muted" padding={0}>+ <Card variant="muted" padding={0} xstyle={embedded && styles.flat}><Center style={{minHeight: 200, width: '100%'}}><VStackgap={1}@@ -268,7 +282,7 @@ export function InteractivePreviewStage({if (!Component) {return (<ComponentPreviewTheme>- <Card variant="muted" padding={0}>+ <Card variant="muted" padding={0} xstyle={embedded && styles.flat}><Center style={{minHeight: 200, width: '100%'}}><VStackgap={1}@@ -297,7 +311,7 @@ export function InteractivePreviewStage({<Cardvariant="muted"padding={0}- style={{width: '100%', position: 'relative'}}>+ xstyle={[styles.card, embedded && styles.flat]}><divstyle={{position: 'absolute',