Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(lab): a swizzled ListInput type-checks without Node's types (#10574)

Cindy Zhang5eb6b21379d9
diff --git a/packages/core/src/utils/processEnvTypes.test.ts b/packages/core/src/utils/processEnvTypes.test.ts
index 7ec3b5be98..99ce1d06a2 100644
--- a/packages/core/src/utils/processEnvTypes.test.ts
+++ b/packages/core/src/utils/processEnvTypes.test.ts
@@ -2,8 +2,8 @@
/**
* A swizzled copy is built by a product that may not install Node's types.
- * Bundlers replace `process.env.NODE_ENV` at build time, so a Core module that
- * reads it must still type-check without those types.
+ * Bundlers replace `process.env.NODE_ENV` at build time, so a module of Core
+ * or of a package swizzle copies from must still type-check without them.
*/
import * as fs from 'node:fs';
@@ -13,19 +13,26 @@ import ts from 'typescript';
import {describe, expect, it} from 'vitest';
const SRC = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const PACKAGES = path.resolve(SRC, '../..');
+/** The packages swizzle copies components from. */
+const SWIZZLE_SOURCES = ['core', 'lab', 'charts', 'richtext', 'vega']
+ .map(name => path.join(PACKAGES, name, 'src'))
+ .filter(dir => fs.existsSync(dir));
-/** Core's source modules, without tests, stories and declaration files. */
+/** Their source modules, without tests, stories and declaration files. */
function sourceModules(): string[] {
- return fs
- .readdirSync(SRC, {recursive: true, withFileTypes: true})
- .filter(
- entry =>
- entry.isFile() &&
- /\.tsx?$/.test(entry.name) &&
- !/\.(test|spec|stories|d)\.tsx?$/.test(entry.name) &&
- !entry.parentPath.includes('__tests__'),
- )
- .map(entry => path.join(entry.parentPath, entry.name));
+ return SWIZZLE_SOURCES.flatMap(dir =>
+ fs
+ .readdirSync(dir, {recursive: true, withFileTypes: true})
+ .filter(
+ entry =>
+ entry.isFile() &&
+ /\.tsx?$/.test(entry.name) &&
+ !/\.(test|spec|stories|d)\.tsx?$/.test(entry.name) &&
+ !entry.parentPath.includes('__tests__'),
+ )
+ .map(entry => path.join(entry.parentPath, entry.name)),
+ );
}
/** A module's code without its comments. */
@@ -59,7 +66,7 @@ describe('process.env without Node types', () => {
program
.getSemanticDiagnostics(program.getSourceFile(file))
.filter(d => d.code === 2580 || d.code === 2591)
- .map(d => `${path.relative(SRC, file)}: TS${d.code}`),
+ .map(d => `${path.relative(PACKAGES, file)}: TS${d.code}`),
);
expect(missing).toEqual([]);
});
diff --git a/packages/lab/src/ListInput/ListInput.tsx b/packages/lab/src/ListInput/ListInput.tsx
index cadb22bf1a..fa441ed1c1 100644
--- a/packages/lab/src/ListInput/ListInput.tsx
+++ b/packages/lab/src/ListInput/ListInput.tsx
@@ -60,6 +60,10 @@ import {
} from '@astryxdesign/core/utils';
import {reorderStyles} from '../reorderStyles';
+// Bundlers replace this value at build time. The declaration lets a product
+// without Node's types type-check this file.
+declare const process: {readonly env: {readonly NODE_ENV?: string}};
+
export type ListInputChange<T> =
| {type: 'add'; item: T; index: number}
| {