Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

feat(Selector,Typeahead,Tokenizer): cascade size to dropdown list items (#1442)

Ernest5f375b46ef25
diff --git a/packages/core/src/Selector/XDSSelector.tsx b/packages/core/src/Selector/XDSSelector.tsx
index 496cc86fcb..dc199c94fc 100644
--- a/packages/core/src/Selector/XDSSelector.tsx
+++ b/packages/core/src/Selector/XDSSelector.tsx
@@ -243,6 +243,21 @@ const sizeStyles = stylex.create({
},
});
+/**
+ * Size-specific overrides for dropdown list items.
+ * Matches the pattern used by XDSDropdownMenuItem so that
+ * an `sm` selector renders compact list items, `md`/`lg` use
+ * the base padding defined in `styles.item`.
+ */
+const itemSizeStyles = stylex.create({
+ sm: {
+ paddingBlock: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
+ },
+ md: {},
+ lg: {},
+});
+
const STATUS_ICON_MAP: Record<XDSSelectorStatusType, XDSIconName> = {
warning: 'warning',
error: 'xCircle',
@@ -574,6 +589,7 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
onMouseEnter={() => onItemMouseEnter(item, flatIndex)}
{...stylex.props(
styles.item,
+ itemSizeStyles[size],
isHighlighted && styles.itemHighlighted,
isSelected && styles.itemSelected,
item.disabled && styles.itemDisabled,
@@ -588,6 +604,7 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
[
children,
highlightedIndex,
+ size,
value,
getItemId,
onItemSelect,
diff --git a/packages/core/src/Tokenizer/XDSTokenizer.tsx b/packages/core/src/Tokenizer/XDSTokenizer.tsx
index f4f0e015ed..d1bcfb6e1b 100644
--- a/packages/core/src/Tokenizer/XDSTokenizer.tsx
+++ b/packages/core/src/Tokenizer/XDSTokenizer.tsx
@@ -708,6 +708,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
debounceMs={debounceMs}
onKeyDown={handleKeyDown}
anchorRef={wrapperRef}
+ size={size}
inputXStyle={
isAtMax || isTruncated
? styles.inputAtMax
diff --git a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx b/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
index b2c3cc0fd6..7d3c20bda7 100644
--- a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
+++ b/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
@@ -144,6 +144,13 @@ export interface XDSBaseTypeaheadProps<T extends XDSSearchableItem> {
* If the handler calls `e.preventDefault()`, internal handling is skipped.
*/
onKeyDown?: (e: React.KeyboardEvent<HTMLInputElement>) => void;
+
+ /**
+ * Size of the typeahead, used to scale dropdown item padding.
+ * When 'sm', items get compact padding to match the trigger size.
+ * @default 'md'
+ */
+ size?: 'sm' | 'md';
}
// =============================================================================
@@ -222,6 +229,19 @@ const styles = stylex.create({
},
});
+/**
+ * Size-specific overrides for dropdown list items.
+ * Matches the pattern used by XDSDropdownMenuItem / XDSSelector so that
+ * an `sm` typeahead renders compact list items.
+ */
+const itemSizeStyles = stylex.create({
+ sm: {
+ paddingBlock: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
+ },
+ md: {},
+});
+
// =============================================================================
// Component
// =============================================================================
@@ -266,6 +286,7 @@ export const XDSBaseTypeahead = function XDSBaseTypeahead<
anchorRef,
onKeyDown: externalOnKeyDown,
debounceMs = 150,
+ size = 'md',
ref,
}: XDSBaseTypeaheadProps<T> & {ref?: React.Ref<HTMLInputElement>}) {
const generatedId = useId();
@@ -629,6 +650,7 @@ export const XDSBaseTypeahead = function XDSBaseTypeahead<
onMouseEnter={() => setHighlightedIndex(index)}
{...stylex.props(
styles.item,
+ itemSizeStyles[size],
index === highlightedIndex && styles.itemHighlighted,
value?.id === item.id && styles.itemSelected,
)}>
diff --git a/packages/core/src/Typeahead/XDSTypeahead.tsx b/packages/core/src/Typeahead/XDSTypeahead.tsx
index 9af15bfe41..f494469e87 100644
--- a/packages/core/src/Typeahead/XDSTypeahead.tsx
+++ b/packages/core/src/Typeahead/XDSTypeahead.tsx
@@ -421,6 +421,7 @@ export function XDSTypeahead<T extends XDSSearchableItem>({
anchorRef={wrapperRef}
onKeyDown={handleKeyDown}
inputXStyle={showToken ? styles.inputHidden : undefined}
+ size={size}
/>
{hasClear && value && !isDisabled && isEditing && (
<button