Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): parse dotted meridiems in parseTimeInput (#3464)

Md Shahrier Islam Arham642936cb09db
diff --git a/.changeset/timeparser-dotted-meridiem.md b/.changeset/timeparser-dotted-meridiem.md
new file mode 100644
index 0000000000..f4ba8604a7
--- /dev/null
+++ b/.changeset/timeparser-dotted-meridiem.md
@@ -0,0 +1,6 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] TimeInput/DateTimeInput: parse dotted meridiems correctly. "2:30 p.m." was silently accepted as 02:30 and "12 a.m." as noon because the meridiem-detection regex did not allow the dots that the AM/PM regexes accept; hasMeridiem is now derived from those regexes so they cannot drift (#3462)
+@arham766
diff --git a/packages/core/src/utils/timeParser.test.ts b/packages/core/src/utils/timeParser.test.ts
index 74be1b4037..98a2745a4e 100644
--- a/packages/core/src/utils/timeParser.test.ts
+++ b/packages/core/src/utils/timeParser.test.ts
@@ -144,11 +144,21 @@ describe('parseTimeInput', () => {
expect(parseTimeInput('12pm')).toBe('12:00');
});
+ it('parses dotted meridiems (a.m./p.m.)', () => {
+ expect(parseTimeInput('2:30 p.m.')).toBe('14:30');
+ expect(parseTimeInput('2:30 P.M.')).toBe('14:30');
+ expect(parseTimeInput('2:30 p.m')).toBe('14:30');
+ expect(parseTimeInput('12 a.m.')).toBe('00:00');
+ expect(parseTimeInput('12 p.m.')).toBe('12:00');
+ expect(parseTimeInput('2 p.m.')).toBe('14:00');
+ });
+
it('returns null for invalid input', () => {
expect(parseTimeInput('')).toBeNull();
expect(parseTimeInput('abc')).toBeNull();
expect(parseTimeInput('25:00')).toBeNull();
expect(parseTimeInput('13:00 PM')).toBeNull(); // 13 is invalid in 12h format
+ expect(parseTimeInput('13:00 p.m.')).toBeNull(); // dotted variant rejected too
});
});
diff --git a/packages/core/src/utils/timeParser.ts b/packages/core/src/utils/timeParser.ts
index b45b25d95e..b7c51188f2 100644
--- a/packages/core/src/utils/timeParser.ts
+++ b/packages/core/src/utils/timeParser.ts
@@ -164,10 +164,13 @@ export function parseTimeInput(
const trimmed = input.trim().toLowerCase();
- // Check for AM/PM
- const hasMeridiem = /[ap]m?\s*$/i.test(trimmed);
+ // Check for AM/PM. hasMeridiem is derived from isPM/isAM so the detection
+ // can never drift from them: it previously used its own regex without the
+ // optional dots, so dotted meridiems ("2:30 p.m.") skipped the 12h -> 24h
+ // conversion and parsed 12 hours off.
const isPM = /p\.?m?\.?\s*$/i.test(trimmed);
const isAM = /a\.?m?\.?\s*$/i.test(trimmed);
+ const hasMeridiem = isPM || isAM;
// Remove AM/PM suffix
const timeStr = trimmed.replace(/\s*[ap]\.?m?\.?\s*$/i, '').trim();