Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(lab): announce EmojiPicker load failures (#7809)

심미진6a751f7b7a88
diff --git a/packages/lab/src/EmojiPicker/EmojiPicker.test.tsx b/packages/lab/src/EmojiPicker/EmojiPicker.test.tsx
index feab92ed46..5e99c72ed9 100644
--- a/packages/lab/src/EmojiPicker/EmojiPicker.test.tsx
+++ b/packages/lab/src/EmojiPicker/EmojiPicker.test.tsx
@@ -273,4 +273,25 @@ describe('EmojiPicker', () => {
fireEvent.change(search(), {target: {value: 'finish'}});
expect(emojiNames()).toEqual(['Chequered flag']);
});
+
+ it('renders the bundled emoji load error inside a status region', async () => {
+ const loadFailedMessage = "More emoji couldn't be loaded.";
+
+ vi.resetModules();
+ vi.doMock('./emojiData', () => {
+ throw new Error('forced emoji data load failure');
+ });
+
+ const {EmojiPicker: FailingEmojiPicker} = await import('./EmojiPicker');
+
+ render(<FailingEmojiPicker frequentEmojis={[]} onSelect={() => {}} />);
+
+ const errorMessage = await screen.findByText(loadFailedMessage);
+
+ const isInsideStatusRegion = screen
+ .getAllByRole('status')
+ .some(status => status.contains(errorMessage));
+
+ expect(isInsideStatusRegion).toBe(true);
+ });
});
diff --git a/packages/lab/src/EmojiPicker/EmojiPicker.tsx b/packages/lab/src/EmojiPicker/EmojiPicker.tsx
index becd65e81c..5cdc6749b8 100644
--- a/packages/lab/src/EmojiPicker/EmojiPicker.tsx
+++ b/packages/lab/src/EmojiPicker/EmojiPicker.tsx
@@ -526,22 +526,22 @@ export function EmojiPicker({
<Center>
<Spinner size="sm" label={t('@astryx.emojiPicker.loading')} />
</Center>
- ) : queryWords.length === 0 && categories === 'failed' ? (
- <HStack paddingInline={3}>
- <Text type="supporting" color="secondary">
- {t('@astryx.emojiPicker.loadFailed')}
- </Text>
- </HStack>
) : null}
<HStack
role="status"
aria-atomic="true"
paddingInline={3}
data-emoji-picker-search-status="true">
- {noResultsMessage != null && (
+ {queryWords.length === 0 && categories === 'failed' ? (
<Text type="supporting" color="secondary">
- {noResultsMessage}
+ {t('@astryx.emojiPicker.loadFailed')}
</Text>
+ ) : (
+ noResultsMessage != null && (
+ <Text type="supporting" color="secondary">
+ {noResultsMessage}
+ </Text>
+ )
)}
</HStack>
</VStack>