Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(FormLayout): give horizontal children equal width via CSS Grid (#2058)

Kenton Quatman760a9db77452
diff --git a/packages/core/src/FormLayout/XDSFormLayout.tsx b/packages/core/src/FormLayout/XDSFormLayout.tsx
index b1feb5c2c1..efa8edb1e7 100644
--- a/packages/core/src/FormLayout/XDSFormLayout.tsx
+++ b/packages/core/src/FormLayout/XDSFormLayout.tsx
@@ -41,8 +41,9 @@ const styles = stylex.create({
gap: spacingVars['--spacing-4'],
},
horizontal: {
- flexDirection: 'row',
- flexWrap: 'wrap',
+ display: 'grid',
+ gridAutoFlow: 'column',
+ gridAutoColumns: '1fr',
},
horizontalLabels: {
display: 'grid',
@@ -74,8 +75,8 @@ export interface XDSFormLayoutProps extends XDSBaseProps<HTMLDivElement> {
* Direction of field arrangement.
*
* - `'vertical'` — Fields stack top-to-bottom (default). Most common.
- * - `'horizontal'` — Fields arrange left-to-right, wrapping when needed.
- * Each child gets equal flex-grow.
+ * - `'horizontal'` — Fields arrange left-to-right in equal-width columns
+ * using CSS Grid. Each child occupies one equal column.
* - `'horizontal-labels'` — CSS Grid with labels to the left of inputs.
* Collapses to vertical when the container is narrow (≤480px).
*
diff --git a/packages/core/src/FormLayout/__snapshots__/XDSFormLayout.test.tsx.snap b/packages/core/src/FormLayout/__snapshots__/XDSFormLayout.test.tsx.snap
index 5600e69531..08c1ff0c57 100644
--- a/packages/core/src/FormLayout/__snapshots__/XDSFormLayout.test.tsx.snap
+++ b/packages/core/src/FormLayout/__snapshots__/XDSFormLayout.test.tsx.snap
@@ -2,7 +2,7 @@
exports[`XDSFormLayout > matches snapshot for horizontal direction 1`] = `
<div
- class="xds-form-layout horizontal XDSFormLayout__styles.base x78zum5 x18g69wz XDSFormLayout__styles.horizontal x1q0g3np x1a02dak"
+ class="xds-form-layout horizontal XDSFormLayout__styles.base xdt5ytf x18g69wz XDSFormLayout__styles.horizontal xrvj5dj x1mt1orb xu6a5m6"
data-testid="layout"
>
<input