Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(TextInput, TextArea): default value to empty string to prevent rendering "undefined" (#1439)

Cindy Zhang80996aab7d62
diff --git a/packages/core/src/TextArea/XDSTextArea.tsx b/packages/core/src/TextArea/XDSTextArea.tsx
index 04ab513b1e..47adc15801 100644
--- a/packages/core/src/TextArea/XDSTextArea.tsx
+++ b/packages/core/src/TextArea/XDSTextArea.tsx
@@ -264,7 +264,7 @@ export function XDSTextArea({
onChange,
onChangeAction,
isLoading = false,
- value,
+ value = '',
placeholder,
rows = 3,
isDisabled = false,
diff --git a/packages/core/src/TextInput/XDSTextInput.test.tsx b/packages/core/src/TextInput/XDSTextInput.test.tsx
index d2370288f8..74aee76fa5 100644
--- a/packages/core/src/TextInput/XDSTextInput.test.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.test.tsx
@@ -52,6 +52,12 @@ describe('XDSTextInput', () => {
expect(setValue).toHaveBeenCalledWith('A', expect.any(Object));
});
+ it('renders empty string when value is undefined', () => {
+ // @ts-expect-error — testing runtime safety when value is omitted
+ render(<XDSTextInput label="Name" onChange={() => {}} />);
+ expect(screen.getByRole('textbox')).toHaveValue('');
+ });
+
it('displays controlled value', () => {
render(
<XDSTextInput
diff --git a/packages/core/src/TextInput/XDSTextInput.tsx b/packages/core/src/TextInput/XDSTextInput.tsx
index cc4161d5de..b2fe6d7135 100644
--- a/packages/core/src/TextInput/XDSTextInput.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.tsx
@@ -241,7 +241,7 @@ export function XDSTextInput({
onChange,
onChangeAction,
isLoading = false,
- value,
+ value = '',
placeholder,
labelTooltip,
hasClear = false,