An open source design system that's fully customizable and agent ready
TypeScript
fix(themes): restore --radius-none to the fixed 0px contract in butter, chocolate, gothic, stone (#4906)
Ishan Jain83209502dfc4
diff --git a/.changeset/themes-radius-none-fixed-contract.md b/.changeset/themes-radius-none-fixed-contract.mdnew file mode 100644index 0000000000..6e99e25675--- /dev/null+++ b/.changeset/themes-radius-none-fixed-contract.md@@ -0,0 +1,10 @@+---+'@astryxdesign/theme-butter': patch+'@astryxdesign/theme-chocolate': patch+'@astryxdesign/theme-gothic': patch+'@astryxdesign/theme-stone': patch+---++[fix] `--radius-none` no longer overrides to `0.125rem`. `--radius-none` and `--radius-full` are documented as always fixed (never scaled by a theme), matching `@astryxdesign/core`'s own defaults — each of these themes' radius group bumps swept `--radius-none` along with it by mistake, the same bug fixed for `theme-neutral` in #4856. Anything opting out of rounding via `--radius-none` under these themes now renders with a true `0px` radius again, instead of a silent 2px.++@is-jaindiff --git a/packages/cli/assets/templates/themes/butter/butterTheme.ts b/packages/cli/assets/templates/themes/butter/butterTheme.tsindex 81fb94e4de..d7665a38e8 100644--- a/packages/cli/assets/templates/themes/butter/butterTheme.ts+++ b/packages/cli/assets/templates/themes/butter/butterTheme.ts@@ -202,8 +202,11 @@ export const butterTheme = defineTheme({// Radius// --radius-element drives buttons, badges, inputs — 8px per design// --radius-container drives cards, banners, popovers — 12px per design+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.375rem','--radius-element': '0.5rem', // 8px'--radius-container': '0.75rem', // 12pxdiff --git a/packages/cli/assets/templates/themes/chocolate/chocolateTheme.ts b/packages/cli/assets/templates/themes/chocolate/chocolateTheme.tsindex aca7447887..9cd674c95a 100644--- a/packages/cli/assets/templates/themes/chocolate/chocolateTheme.ts+++ b/packages/cli/assets/templates/themes/chocolate/chocolateTheme.ts@@ -176,8 +176,11 @@ export const chocolateTheme = defineTheme({// =========================================================================// Radius — soft and rounded+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.375rem','--radius-element': '0.625rem','--radius-container': '0.75rem',diff --git a/packages/cli/assets/templates/themes/gothic/gothicTheme.ts b/packages/cli/assets/templates/themes/gothic/gothicTheme.tsindex 2cf1720d1a..36999aca27 100644--- a/packages/cli/assets/templates/themes/gothic/gothicTheme.ts+++ b/packages/cli/assets/templates/themes/gothic/gothicTheme.ts@@ -201,8 +201,11 @@ export const gothicTheme = defineTheme({// =========================================================================// Radius — subtle rounding (original gothic)+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.25rem','--radius-element': '0.5rem','--radius-container': '0.75rem',diff --git a/packages/cli/assets/templates/themes/stone/stoneTheme.ts b/packages/cli/assets/templates/themes/stone/stoneTheme.tsindex 199e75c1a2..b1dfa63f9c 100644--- a/packages/cli/assets/templates/themes/stone/stoneTheme.ts+++ b/packages/cli/assets/templates/themes/stone/stoneTheme.ts@@ -219,8 +219,11 @@ export const stoneTheme = defineTheme({// =========================================================================// Radius — clean and subtle+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.25rem','--radius-element': '0.5rem','--radius-container': '0.75rem',diff --git a/packages/themes/butter/src/butterTheme.ts b/packages/themes/butter/src/butterTheme.tsindex 81fb94e4de..d7665a38e8 100644--- a/packages/themes/butter/src/butterTheme.ts+++ b/packages/themes/butter/src/butterTheme.ts@@ -202,8 +202,11 @@ export const butterTheme = defineTheme({// Radius// --radius-element drives buttons, badges, inputs — 8px per design// --radius-container drives cards, banners, popovers — 12px per design+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.375rem','--radius-element': '0.5rem', // 8px'--radius-container': '0.75rem', // 12pxdiff --git a/packages/themes/chocolate/src/chocolateTheme.ts b/packages/themes/chocolate/src/chocolateTheme.tsindex aca7447887..9cd674c95a 100644--- a/packages/themes/chocolate/src/chocolateTheme.ts+++ b/packages/themes/chocolate/src/chocolateTheme.ts@@ -176,8 +176,11 @@ export const chocolateTheme = defineTheme({// =========================================================================// Radius — soft and rounded+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.375rem','--radius-element': '0.625rem','--radius-container': '0.75rem',diff --git a/packages/themes/gothic/src/gothicTheme.ts b/packages/themes/gothic/src/gothicTheme.tsindex 2cf1720d1a..36999aca27 100644--- a/packages/themes/gothic/src/gothicTheme.ts+++ b/packages/themes/gothic/src/gothicTheme.ts@@ -201,8 +201,11 @@ export const gothicTheme = defineTheme({// =========================================================================// Radius — subtle rounding (original gothic)+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.25rem','--radius-element': '0.5rem','--radius-container': '0.75rem',diff --git a/packages/themes/stone/src/stoneTheme.ts b/packages/themes/stone/src/stoneTheme.tsindex 199e75c1a2..b1dfa63f9c 100644--- a/packages/themes/stone/src/stoneTheme.ts+++ b/packages/themes/stone/src/stoneTheme.ts@@ -219,8 +219,11 @@ export const stoneTheme = defineTheme({// =========================================================================// Radius — clean and subtle+ // --radius-none and --radius-full are always fixed and must never be+ // scaled by a theme (see defineTheme's radius config docs) — 0 and+ // 9999px respectively, matching @astryxdesign/core's own defaults.// =========================================================================- '--radius-none': '0.125rem',+ '--radius-none': '0px','--radius-inner': '0.25rem','--radius-element': '0.5rem','--radius-container': '0.75rem',