Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): prevent native text selection and context menu on touch long-press (#3606) (#3610)

Geervan88a690b4ea7c
diff --git a/packages/core/src/ContextMenu/ContextMenu.test.tsx b/packages/core/src/ContextMenu/ContextMenu.test.tsx
index 6f755c856a..4553bfd7c7 100644
--- a/packages/core/src/ContextMenu/ContextMenu.test.tsx
+++ b/packages/core/src/ContextMenu/ContextMenu.test.tsx
@@ -172,6 +172,21 @@ describe('ContextMenu', () => {
expect(preventDefault).toHaveBeenCalled();
});
+ it('prevents default context menu on the opened menu container', () => {
+ render(
+ <ContextMenu items={[{label: 'Item 1'}]}>
+ <div>Right-click me</div>
+ </ContextMenu>,
+ );
+
+ fireEvent.contextMenu(screen.getByText('Right-click me'));
+ const menu = screen.getByRole('menu', {hidden: true});
+ const event = new MouseEvent('contextmenu', {bubbles: true});
+ const preventDefault = vi.spyOn(event, 'preventDefault');
+ menu.dispatchEvent(event);
+ expect(preventDefault).toHaveBeenCalled();
+ });
+
it('does not open when isDisabled is true', () => {
render(
<ContextMenu items={[{label: 'Item 1'}]} isDisabled>
diff --git a/packages/core/src/ContextMenu/ContextMenu.tsx b/packages/core/src/ContextMenu/ContextMenu.tsx
index 516596cb21..f917b7d8c6 100644
--- a/packages/core/src/ContextMenu/ContextMenu.tsx
+++ b/packages/core/src/ContextMenu/ContextMenu.tsx
@@ -87,6 +87,7 @@ const styles = stylex.create({
transitionProperty: 'opacity',
transitionDuration: durationVars['--duration-fast'],
transitionTimingFunction: easeVars['--ease-standard'],
+ userSelect: 'none',
},
popover: {
minWidth: '160px',
@@ -409,6 +410,7 @@ export function ContextMenu({
role="menu"
aria-label={label}
onKeyDown={listKeyDown}
+ onContextMenu={e => e.preventDefault()}
{...mergeProps(
themeProps('context-menu'),
stylex.props(styles.menu, xstyle),