Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(docsite): normalize legacy input category (#5688)

rubyycheung89610aa59d1f
diff --git a/apps/docsite/src/__tests__/component-categories.test.ts b/apps/docsite/src/__tests__/component-categories.test.ts
new file mode 100644
index 0000000000..a904c5214d
--- /dev/null
+++ b/apps/docsite/src/__tests__/component-categories.test.ts
@@ -0,0 +1,14 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+import {describe, expect, it} from 'vitest';
+import {normalizeComponentCategory} from '../lib/componentCategories';
+
+describe('normalizeComponentCategory', () => {
+ it('maps legacy Data Input metadata to Form Controls', () => {
+ expect(normalizeComponentCategory('Data Input')).toBe('Form Controls');
+ });
+
+ it('preserves current category names', () => {
+ expect(normalizeComponentCategory('Navigation')).toBe('Navigation');
+ });
+});
diff --git a/apps/docsite/src/__tests__/data-extraction.test.ts b/apps/docsite/src/__tests__/data-extraction.test.ts
index f20a23d4fc..80599cb3e6 100644
--- a/apps/docsite/src/__tests__/data-extraction.test.ts
+++ b/apps/docsite/src/__tests__/data-extraction.test.ts
@@ -23,6 +23,7 @@ import {docTopics, docsCount} from '../generated/docsRegistry';
import {showcaseRegistry} from '../generated/showcaseRegistry';
import {eagerShowcases} from '../components/eagerShowcases';
import {exampleRegistry} from '../generated/exampleRegistry';
+import {normalizeComponentCategory} from '../lib/componentCategories';
const REPO_ROOT = path.resolve(
path.dirname(fileURLToPath(import.meta.url)),
@@ -1068,7 +1069,9 @@ describe('galleryEagerShowcases', () => {
/** Gallery render order: categories in display order, then registry order. */
const galleryOrder = categories.flatMap(cat =>
(components['@astryxdesign/core'] ?? []).filter(
- c => c.category === cat && isGalleryComponent(c),
+ c =>
+ normalizeComponentCategory(c.category ?? '') === cat &&
+ isGalleryComponent(c),
),
);
@@ -1084,7 +1087,7 @@ describe('galleryEagerShowcases', () => {
const declared = new Set(
(components['@astryxdesign/core'] ?? [])
.filter(isGalleryComponent)
- .map(c => c.category),
+ .map(c => normalizeComponentCategory(c.category ?? '')),
);
for (const cat of declared) {
expect(
diff --git a/apps/docsite/src/app/(docs)/components/page.tsx b/apps/docsite/src/app/(docs)/components/page.tsx
index 0399d6e7a4..7581aad502 100644
--- a/apps/docsite/src/app/(docs)/components/page.tsx
+++ b/apps/docsite/src/app/(docs)/components/page.tsx
@@ -22,6 +22,7 @@ import {CodeExampleBlock} from '../../../components/CodeExampleBlock';
import {components as componentRegistry} from '../../../generated/componentRegistry';
import {showcaseRegistry} from '../../../generated/showcaseRegistry';
import {ShowcaseThumbnail} from '../../../components/ShowcaseThumbnail';
+import {normalizeComponentCategory} from '../../../lib/componentCategories';
import {layout} from '../../../layout.stylex';
const FIGMA_LIBRARY_URL =
@@ -113,7 +114,7 @@ export default function ComponentsGalleryPage() {
displayName: comp.displayName,
description: comp.description,
href: `/components/${comp.name}`,
- category: comp.category,
+ category: normalizeComponentCategory(comp.category),
hasShowcase: SHOWCASE_NAMES.has(comp.name),
});
}
diff --git a/apps/docsite/src/lib/componentCategories.ts b/apps/docsite/src/lib/componentCategories.ts
new file mode 100644
index 0000000000..845aa5f93b
--- /dev/null
+++ b/apps/docsite/src/lib/componentCategories.ts
@@ -0,0 +1,6 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+/** Normalize category names emitted by older published package metadata. */
+export function normalizeComponentCategory(category: string): string {
+ return category === 'Data Input' ? 'Form Controls' : category;
+}