Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(Layout): treat padding={0} as equivalent to isFullBleed (#595)

Cindy Zhang8b3d3d80b5d7
diff --git a/packages/core/src/Layout/XDSLayoutContent.tsx b/packages/core/src/Layout/XDSLayoutContent.tsx
index 862c6ef29f..2aed0dc1cb 100644
--- a/packages/core/src/Layout/XDSLayoutContent.tsx
+++ b/packages/core/src/Layout/XDSLayoutContent.tsx
@@ -157,6 +157,9 @@ export function XDSLayoutContent({
XDSLayoutSlotsContext,
);
+ // padding={0} is semantically equivalent to isFullBleed
+ const isZeroPadding = isFullBleed || padding === 0;
+
return (
<div
ref={ref as React.Ref<HTMLDivElement>}
@@ -167,12 +170,12 @@ export function XDSLayoutContent({
stylex.props(
styles.content,
// Outer padding on container edges (unless content is full bleed)
- !hasStart && !isFullBleed && padding == null && styles.noStart,
- !hasEnd && !isFullBleed && padding == null && styles.noEnd,
- !hasHeader && !isFullBleed && padding == null && styles.noHeader,
- !hasFooter && !isFullBleed && padding == null && styles.noFooter,
+ !hasStart && !isZeroPadding && padding == null && styles.noStart,
+ !hasEnd && !isZeroPadding && padding == null && styles.noEnd,
+ !hasHeader && !isZeroPadding && padding == null && styles.noHeader,
+ !hasFooter && !isZeroPadding && padding == null && styles.noFooter,
isScrollable && styles.scrollable,
- isFullBleed && padding == null && styles.fullBleed,
+ isZeroPadding && styles.fullBleed,
padding != null && paddingStyles[padding],
padding != null && containerPaddingInlineVarStyles[padding],
xstyle,
diff --git a/packages/core/src/Layout/XDSLayoutFooter.tsx b/packages/core/src/Layout/XDSLayoutFooter.tsx
index cc08530c54..a9e0b4af13 100644
--- a/packages/core/src/Layout/XDSLayoutFooter.tsx
+++ b/packages/core/src/Layout/XDSLayoutFooter.tsx
@@ -131,8 +131,12 @@ export function XDSLayoutFooter({
ref,
...props
}: XDSLayoutFooterProps) {
+ // padding={0} is semantically equivalent to isFullBleed
+ const isZeroPadding = isFullBleed || padding === 0;
+
// When no divider, collapse spacing for seamless visual flow
- const shouldCollapseSpacing = !hasDivider && !isFullBleed && padding == null;
+ const shouldCollapseSpacing =
+ !hasDivider && !isZeroPadding && padding == null;
return (
<div
@@ -144,7 +148,7 @@ export function XDSLayoutFooter({
stylex.props(
styles.footer,
dynamicStyles.sizing(height ?? null),
- isFullBleed && padding == null && styles.fullBleed,
+ isZeroPadding && styles.fullBleed,
padding != null && paddingStyles[padding],
padding != null && containerPaddingInlineVarStyles[padding],
hasDivider && styles.divider,
diff --git a/packages/core/src/Layout/XDSLayoutHeader.tsx b/packages/core/src/Layout/XDSLayoutHeader.tsx
index f49256af15..a2a8f40177 100644
--- a/packages/core/src/Layout/XDSLayoutHeader.tsx
+++ b/packages/core/src/Layout/XDSLayoutHeader.tsx
@@ -131,8 +131,12 @@ export function XDSLayoutHeader({
ref,
...props
}: XDSLayoutHeaderProps) {
+ // padding={0} is semantically equivalent to isFullBleed
+ const isZeroPadding = isFullBleed || padding === 0;
+
// When no divider, collapse spacing for seamless visual flow
- const shouldCollapseSpacing = !hasDivider && !isFullBleed && padding == null;
+ const shouldCollapseSpacing =
+ !hasDivider && !isZeroPadding && padding == null;
return (
<div
@@ -144,7 +148,7 @@ export function XDSLayoutHeader({
stylex.props(
styles.header,
dynamicStyles.sizing(height ?? null),
- isFullBleed && padding == null && styles.fullBleed,
+ isZeroPadding && styles.fullBleed,
padding != null && paddingStyles[padding],
padding != null && containerPaddingInlineVarStyles[padding],
hasDivider && styles.divider,
diff --git a/packages/core/src/Layout/XDSLayoutPanel.tsx b/packages/core/src/Layout/XDSLayoutPanel.tsx
index 487b163d6a..9027b81d62 100644
--- a/packages/core/src/Layout/XDSLayoutPanel.tsx
+++ b/packages/core/src/Layout/XDSLayoutPanel.tsx
@@ -196,8 +196,12 @@ export function XDSLayoutPanel({
const isStartPanel = area === 'start';
const isEndPanel = area === 'end';
+ // padding={0} is semantically equivalent to isFullBleed
+ const isZeroPadding = isFullBleed || padding === 0;
+
// When no divider, collapse spacing for seamless visual flow
- const shouldCollapseSpacing = !hasDivider && !isFullBleed && padding == null;
+ const shouldCollapseSpacing =
+ !hasDivider && !isZeroPadding && padding == null;
// Select divider style based on position
const dividerStyle = isStartPanel
@@ -224,12 +228,15 @@ export function XDSLayoutPanel({
styles.panel,
dynamicStyles.sizing(width ?? null),
// Outer padding on container edges (unless component is full bleed)
- isStartPanel && !isFullBleed && padding == null && styles.startPanel,
- isEndPanel && !isFullBleed && padding == null && styles.endPanel,
- !hasHeader && !isFullBleed && padding == null && styles.noHeader,
- !hasFooter && !isFullBleed && padding == null && styles.noFooter,
+ isStartPanel &&
+ !isZeroPadding &&
+ padding == null &&
+ styles.startPanel,
+ isEndPanel && !isZeroPadding && padding == null && styles.endPanel,
+ !hasHeader && !isZeroPadding && padding == null && styles.noHeader,
+ !hasFooter && !isZeroPadding && padding == null && styles.noFooter,
isScrollable && styles.scrollable,
- isFullBleed && padding == null && styles.fullBleed,
+ isZeroPadding && styles.fullBleed,
padding != null && paddingStyles[padding],
padding != null && containerPaddingInlineVarStyles[padding],
hasDivider && dividerStyle,