Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

spec(AST-030): a stable contribution runs CI from a contributor budget (FR29, DEC-26) (#10797)

Cindy Zhang8d4148ff0f85
diff --git a/docs/specs/AST-030/spec.md b/docs/specs/AST-030/spec.md
index f6edd570e0..af9f1f5fef 100644
--- a/docs/specs/AST-030/spec.md
+++ b/docs/specs/AST-030/spec.md
@@ -420,19 +420,18 @@ they are separately named.
from the start. A pull request that may not run CI admits nothing, and
waiting never fails a job, so every required context reports as before. A
tool that grants CI capacity reads it through the same count admission uses
- (`.github/actions/ci-admission/count.mjs`), with no count of its own.
+ (`.github/actions/ci-admission/count.mjs`), with no count of its own. The contributor class of FR29 is granted by the capacity tool before this admission; its runs are then admitted like any pull request run.
- **FR17 — A pull request runs CI when it is ready and a maintainer can vouch
for it.** A draft pull request runs no CI, and marking it ready for review
starts its pull-request run, which runs what the change reaches (FR13,
DEC-6). A pull request runs CI when its head branch lives in this repository,
which pushing needs write access for, or when it carries the
- maintainer-applied `ci:run` label. The label takes effect on the next push or
- a close and reopen; applying or removing any label starts no run. For a pull
+ maintainer-applied `ci:run` label. Applying or removing a label starts no run by itself; the label takes effect on the next push, a close and reopen, or marking the pull request ready. For a pull
request that may not run CI, the required contexts (FR7) report failure with
"Waiting for a maintainer's ci:run label", never success, because a skipped
required check would count as passing. Events other than a pull request (a
push to `main`, a merge-group entry, a dispatch) are unaffected, and a fork's
- code never runs with the repository's secrets.
+ code never runs with the repository's secrets. The contributor job of FR29 starts a run the same way: the label plus a draft-and-ready toggle.
- **FR18 — Runtime performance has one nightly lane, outside the pull-request
surfaces.** `perf-nightly.yml` measures a fixed set of Sandbox perf scenes in
Chromium on every nightly run of `main` and on manual dispatch: mount long
@@ -609,6 +608,7 @@ they are separately named.
`interaction-check/` branch also qualifies; the prefix is reserved for the
release tooling. Such pull requests stay non-mergeable, and this widens the
scope of no other pull request (DEC-24).
+- **FR29 — A stable contribution runs CI without a maintainer.** A stable contribution from a fork runs CI without a maintainer. An automated job starts CI for a fork pull request without `ci:run` (a branch in another repository, so CI doesn't run on its pushes under FR17) when all of these hold: it isn't a draft; its CLA check passes; its head has had no push for 4 hours; the review bot's (`astracat-bot[bot]`) review at that exact head is APPROVED, or COMMENTED with no finding the review marks as blocking (its body or inline comments contain "**Blocking", "Requesting changes" or "Changes requested"); CHANGES_REQUESTED, or no review at the head, never counts; the link guard passes (merge-guard's `external-links` status at the head is success or absent, and the pull request has no `needs-human:external-link` label); GitHub doesn't report it as conflicting with its base; its last push is no more than 30 days old; and it changes no workflow or CI path (`.github/**`, CI scripts). To start the run, the job adds `ci:run` and marks the pull request draft and then ready again, so the ready event starts a run at that exact head (FR17). The same ready event re-requests a human reviewer whose latest review requested changes, as a maintainer's own toggle does. Once the run has started it removes the label, but only when the latest `ci:run` label event is its own, so a later push runs nothing until it is vetted again. The job starts a head at most once, and a new head becomes eligible when it meets the same conditions. It starts a run only when the capacity tool has no release-check or main-break waiter queued in the capacity tool, and room for one more pull-request run under the CI job ceiling, at most one start per sweep, in a contributor class with its own daily runner-minute budget set by the owner, first in, first out by how long each head has been stable; the run is then admitted under FR16 like any pull request run. A daily report shows the minutes used against the budget, flags eligible heads that waited more than 2 days, and lists eligible-but-stale heads (over 30 days since the last push) for triage as needing a rebase. A maintainer can still start CI by hand: `ci:run` with a draft-and-ready toggle, a push, or a reopen runs it outside the stability conditions and the contributor budget, admitted under FR16; the automated job never removes or re-adds a label a maintainer set. (DEC-26)
### Platform support
@@ -684,6 +684,15 @@ The nightly perf lane is the one scheduled measurement outside them (FR18).
| FR27 | `check-public-text.test.mjs` over the check and the Lint workflow step | each identifier shape; a hashed name and host made up in the test; ordinary text; a finding in a commit message, an added line and the description; a match before the merge base; an empty range, a bad sha, a missing commit and a missing digest file | a reference passes; the output holds the matched text; a match on the base branch fails a later pull request; an unreadable range passes; the step runs the pull request's own copy |
| FR27 | `check-public-text.test.mjs` commit-list cases | a pull request whose merge base resolves too far back in a shallow clone; its own commit with an internal reference | the check flags the base branch's commits, or passes the pull request's own reference |
| FR28 | `playwright-legs.test.mjs` creator, prefix and head-repository cases ("plans every WebKit spec only for the release tooling's interaction-check/ pull request") | release interaction-check PRs: the release tooling's pull request; the same prefix from another author or from a fork; the tooling account on another branch | A prefix-only, other-author or fork pull request gets the full WebKit scope, or the tooling's interaction-check pull request does not |
+| FR29 | the contributor CI job's rule tests and its dry-run report | an eligible fork pull request; each condition failing alone (including a conflict with the base and a last push over 30 days old); a second sweep on the same head; a new stable head | the eligible pull request does not get `ci:run` once, a single failing condition still adds the label, a second sweep on the same head adds anything, or a new stable head is not labelled |
+| FR29 | the contributor CI job's rule tests and its dry-run report | an eligible head when the day's contributor budget is spent; the daily report | the head runs before the next day's budget, or the report does not list the minutes used against the budget or flag eligible heads that waited more than 2 days |
+| FR29 | the contributor CI job's rule tests and its dry-run report | every write the job makes | the job adds any other label or merges |
+| FR29 | the contributor CI job's rule tests and its dry-run report | a manual `ci:run` with a ready toggle on an ineligible pull request | it does not run, it is counted against the contributor budget, or the job removes or re-adds it |
+| FR29 | the contributor CI job's rule tests and its dry-run report | An eligible-but-stale head (over 30 days since the last push) | it does not appear in the daily report's triage list |
+| FR29 | the contributor CI job's rule tests and its dry-run report | the job's own label after its run starts; a later push to that pull request | the job removes a label it did not set, keeps its own label after the run starts, or a later push runs CI |
+| FR29 | the contributor CI job's rule tests and its dry-run report | A branch in this repository, or a fork pull request that already carries `ci:run`, is never started by the job (CI already runs on its pushes) | the job starts it |
+| FR29 | the contributor CI job's rule tests and its dry-run report | A contributor head while a release-check or main-break waiter is queued in the capacity tool, or without room for one more pull-request run under the CI job ceiling, does not start; at most one starts per sweep | it starts, or more than one starts in a sweep |
+| FR29 | the contributor CI job's rule tests and its dry-run report | Of two eligible heads, the one stable longer starts first | the one stable for less time starts first |
## Decision log
@@ -1237,6 +1246,13 @@ a re-run (a push after ready merges without them); every audit spec on every
Layer change (about 37 minutes of recorded time on a change that lands about
four times a day).
+### DEC-26 — A stable contribution runs CI from a contributor budget
+
+**Reference:** `spec:AST-030/DEC-26`
+**Decider:** `cixzhang`, `2026-11-09`
+
+The owner asked for "some system that will activate ci:run on contribution PRs that are stable", "Or we have some contrib lane that runs off a budget", and "plus ci:run to override?" (FR29). She approved the budget with "Ok 600": The owner set the budget at 600 runner-minutes per UTC day; unused minutes don't carry over.
+
## Open questions
None.