Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(Breadcrumbs): onClick-only items now match link color (#1773)

Cindy Zhang8f2f8fd195df
diff --git a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
index 88b2573564..18fee4cd67 100644
--- a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
+++ b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
@@ -107,6 +107,14 @@ const itemStyles = stylex.create({
},
cursor: 'pointer',
},
+ // Reset native button styles so onClick-only items match link appearance
+ buttonReset: {
+ background: 'none',
+ border: 'none',
+ padding: 0,
+ margin: 0,
+ font: 'inherit',
+ },
defaultLink: {
color: colorVars['--color-text-secondary'],
},
@@ -259,6 +267,17 @@ export function XDSBreadcrumbItem({
)}>
{content}
</LinkComponent>
+ ) : onClick != null ? (
+ <button
+ type="button"
+ onClick={onClick}
+ {...stylex.props(
+ itemStyles.link,
+ itemStyles.buttonReset,
+ isSupporting ? itemStyles.supportingLink : itemStyles.defaultLink,
+ )}>
+ {content}
+ </button>
) : (
<span
{...stylex.props(
diff --git a/packages/core/src/Breadcrumbs/XDSBreadcrumbs.test.tsx b/packages/core/src/Breadcrumbs/XDSBreadcrumbs.test.tsx
index ba159b56d4..889476f494 100644
--- a/packages/core/src/Breadcrumbs/XDSBreadcrumbs.test.tsx
+++ b/packages/core/src/Breadcrumbs/XDSBreadcrumbs.test.tsx
@@ -201,7 +201,7 @@ describe('XDSBreadcrumbItem', () => {
expect(screen.getByText('Third').tagName).toBe('A');
});
- it('handles onClick', async () => {
+ it('handles onClick on link items', async () => {
const handleClick = vi.fn();
render(
<XDSBreadcrumbs>
@@ -216,6 +216,21 @@ describe('XDSBreadcrumbItem', () => {
expect(handleClick).toHaveBeenCalledTimes(1);
});
+ it('renders onClick-only items as buttons with link styling', async () => {
+ const handleClick = vi.fn();
+ render(
+ <XDSBreadcrumbs>
+ <XDSBreadcrumbItem onClick={handleClick}>Home</XDSBreadcrumbItem>
+ <XDSBreadcrumbItem isCurrent>Current</XDSBreadcrumbItem>
+ </XDSBreadcrumbs>,
+ );
+ const button = screen.getByRole('button', {name: 'Home'});
+ expect(button.tagName).toBe('BUTTON');
+ expect(button).toHaveAttribute('type', 'button');
+ await userEvent.click(button);
+ expect(handleClick).toHaveBeenCalledTimes(1);
+ });
+
it('renders startIcon', () => {
render(
<XDSBreadcrumbs>