An open source design system that's fully customizable and agent ready
TypeScript
feat(selector): add disabled-trigger theme target (#4626)
athz909adfacf94c
diff --git a/.changeset/selector-disabled-state-target.md b/.changeset/selector-disabled-state-target.mdnew file mode 100644index 0000000000..b46f2e3b14--- /dev/null+++ b/.changeset/selector-disabled-state-target.md@@ -0,0 +1,6 @@+---+'@astryxdesign/core': patch+---++[feat] Selector/MultiSelector: add `data-disabled` reflection on the trigger for theme-driven disabled styling. Rotation styles remain on the indicator-icon target (no separate wrapper target needed).+@athzdiff --git a/packages/core/src/MultiSelector/MultiSelector.doc.mjs b/packages/core/src/MultiSelector/MultiSelector.doc.mjsindex d7ad6d353f..682ff18478 100644--- a/packages/core/src/MultiSelector/MultiSelector.doc.mjs+++ b/packages/core/src/MultiSelector/MultiSelector.doc.mjs@@ -23,6 +23,7 @@ export const docs = {{className: 'astryx-multi-selector',visualProps: ['variant', 'size', 'status'],+ states: ['disabled'],},{className: 'astryx-multi-selector-clear-icon'},{className: 'astryx-multi-selector-empty-state'},diff --git a/packages/core/src/MultiSelector/MultiSelector.test.tsx b/packages/core/src/MultiSelector/MultiSelector.test.tsxindex 113add04d0..94a3b5fde3 100644--- a/packages/core/src/MultiSelector/MultiSelector.test.tsx+++ b/packages/core/src/MultiSelector/MultiSelector.test.tsx@@ -1904,3 +1904,58 @@ describe('MultiSelector search affordances', () => {expect(trigger).toHaveAttribute('aria-expanded', 'false');});});++describe('MultiSelector disabled state theme target', () => {+ const getSelectorRoot = (container: HTMLElement): HTMLElement => {+ const root = container.querySelector('.astryx-multi-selector');+ if (root == null) {+ throw new Error('multi-selector root not found');+ }+ return root as HTMLElement;+ };++ it('reflects data-state="disabled" on the root when disabled', () => {+ const {container} = render(+ <MultiSelector+ label="Fruit"+ options={['Apple', 'Banana', 'Orange']}+ value={[]}+ onChange={() => {}}+ isDisabled+ />,+ );+ expect(getSelectorRoot(container)).toHaveAttribute(+ 'data-disabled',+ 'disabled',+ );+ });++ it('omits the disabled class/attribute when enabled', () => {+ const {container} = render(+ <MultiSelector+ label="Fruit"+ options={['Apple', 'Banana', 'Orange']}+ value={[]}+ onChange={() => {}}+ />,+ );+ const root = getSelectorRoot(container);+ expect(root).not.toHaveAttribute('data-disabled');+ expect(root).not.toHaveClass('disabled');+ });++ it('exposes the disabled state so a theme can key on it', () => {+ const theme = defineTheme({+ name: 'multi-selector-disabled-state-test',+ components: {+ 'multi-selector': {+ 'disabled:disabled': {opacity: '0.4'},+ },+ },+ });+ const css = generateThemeTestCSS(theme);+ expect(css).toContain('.astryx-multi-selector.disabled');+ expect(css).toContain('opacity: 0.4');+ });+});+diff --git a/packages/core/src/MultiSelector/MultiSelector.tsx b/packages/core/src/MultiSelector/MultiSelector.tsxindex ed6484e4c9..8e485bade1 100644--- a/packages/core/src/MultiSelector/MultiSelector.tsx+++ b/packages/core/src/MultiSelector/MultiSelector.tsx@@ -1450,6 +1450,7 @@ export function MultiSelector<T extends MultiSelectorOptionType>({variant,size,status: status?.type ?? null,+ disabled: isDisabled ? 'disabled' : null,}),stylex.props(inputWrapperStyles.base,diff --git a/packages/core/src/Selector/Selector.doc.mjs b/packages/core/src/Selector/Selector.doc.mjsindex d9101fecb4..99be8fc423 100644--- a/packages/core/src/Selector/Selector.doc.mjs+++ b/packages/core/src/Selector/Selector.doc.mjs@@ -24,6 +24,7 @@ export const docs = {{className: 'astryx-selector',visualProps: ['variant', 'size', 'status'],+ states: ['disabled'],},{className: 'astryx-selector-option'},{className: 'astryx-selector-empty-state'},diff --git a/packages/core/src/Selector/Selector.test.tsx b/packages/core/src/Selector/Selector.test.tsxindex b158869f4e..2d9f5f1dc6 100644--- a/packages/core/src/Selector/Selector.test.tsx+++ b/packages/core/src/Selector/Selector.test.tsx@@ -1891,3 +1891,48 @@ describe('Selector selected-marker theme target (selector-check)', () => {expect(css).toContain('display: none');});});++describe('Selector disabled state theme target', () => {+ const getSelectorRoot = (container: HTMLElement): HTMLElement => {+ const root = container.querySelector('.astryx-selector');+ if (root == null) {+ throw new Error('selector root not found');+ }+ return root as HTMLElement;+ };++ it('reflects data-disabled="disabled" on the root when disabled', () => {+ const {container} = render(+ <Selector label="Fruit" options={OPTIONS} onChange={() => {}} isDisabled />,+ );+ expect(getSelectorRoot(container)).toHaveAttribute(+ 'data-disabled',+ 'disabled',+ );+ });++ it('omits the disabled class/attribute when enabled', () => {+ const {container} = render(+ <Selector label="Fruit" options={OPTIONS} onChange={() => {}} />,+ );+ const root = getSelectorRoot(container);+ expect(root).not.toHaveAttribute('data-disabled');+ expect(root).not.toHaveClass('disabled');+ });++ it('exposes the disabled state so a theme can key on it', () => {+ const theme = defineTheme({+ name: 'selector-disabled-state-test',+ components: {+ selector: {+ 'disabled:disabled': {opacity: '0.4'},+ },+ },+ });+ const css = generateThemeTestCSS(theme);+ expect(css).toContain('.astryx-selector.disabled');+ expect(css).toContain('opacity: 0.4');+ });+});++diff --git a/packages/core/src/Selector/Selector.tsx b/packages/core/src/Selector/Selector.tsxindex 405311c23d..7fa88d06a5 100644--- a/packages/core/src/Selector/Selector.tsx+++ b/packages/core/src/Selector/Selector.tsx@@ -1188,6 +1188,7 @@ export function Selector<T extends SelectorOptionType>(variant,size,status: status?.type ?? null,+ disabled: isDisabled ? 'disabled' : null,}),stylex.props(inputWrapperStyles.base,