An open source design system that's fully customizable and agent ready
TypeScript
fix(PowerSearch): show every enum_list value in the menu (#6481)
Mushaheed Kapadia90e79a251686
diff --git a/.changeset/powersearch-enum-list-shows-all-values.md b/.changeset/powersearch-enum-list-shows-all-values.mdnew file mode 100644index 0000000000..2b135a3227--- /dev/null+++ b/.changeset/powersearch-enum-list-shows-all-values.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] PowerSearch: `enum_list` value menus now show every value instead of the typeahead default of 10.++@fullstackhackerdiff --git a/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx b/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsxindex 36651eff80..28115bb4f3 100644--- a/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx+++ b/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx@@ -630,3 +630,54 @@ describe('maxMenuItems', () => {await expectCapped({type: 'entity_list', searchSource: source});});});++// =============================================================================+// EnumListEditor shows the whole closed vocabulary+// =============================================================================++describe('EnumListEditor', () => {+ const values = Array.from({length: 12}, (_, index) => ({+ value: `option-${index}`,+ label: `Option ${index}`,+ }));++ it('shows every value on focus instead of the typeahead default of 10', async () => {+ render(+ <PowerSearchValueEditor+ operatorValue={{type: 'enum_list', values}}+ filterValue={undefined}+ onChange={vi.fn()}+ config={stubConfig}+ />,+ );++ fireEvent.focus(screen.getByRole('combobox'));+ await act(async () => {+ await new Promise(resolve => setTimeout(resolve, 50));+ });++ expect(screen.getAllByRole('option', {hidden: true})).toHaveLength(12);+ expect(screen.getByText('Option 11')).toBeInTheDocument();+ });++ it('shows every matching value when searching', async () => {+ render(+ <PowerSearchValueEditor+ operatorValue={{type: 'enum_list', values}}+ filterValue={undefined}+ onChange={vi.fn()}+ config={stubConfig}+ />,+ );++ await act(async () => {+ fireEvent.change(screen.getByRole('combobox'), {+ target: {value: 'Option'},+ });+ await new Promise(resolve => setTimeout(resolve, 200));+ });++ expect(screen.getAllByRole('option', {hidden: true})).toHaveLength(12);+ expect(screen.getByText('Option 11')).toBeInTheDocument();+ });+});diff --git a/packages/core/src/PowerSearch/PowerSearchValueEditor.tsx b/packages/core/src/PowerSearch/PowerSearchValueEditor.tsxindex b70f5adb71..58cdd81a98 100644--- a/packages/core/src/PowerSearch/PowerSearchValueEditor.tsx+++ b/packages/core/src/PowerSearch/PowerSearchValueEditor.tsx@@ -619,6 +619,10 @@ function EnumListEditor({placeholder={t('@astryx.powersearch.valueEditor.selectValuesPlaceholder')}hasEntriesOnFocusdebounceMs={0}+ // A closed vocabulary: every value is a valid choice, so the menu shows+ // all of them instead of BaseTypeahead's 10-suggestion default, which+ // would silently drop valid choices with no way to reach them.+ maxMenuItems={items.length}/>);}