Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(cli): keep app classes on MetadataList out of data-columns selectors (#7982)

EJ Hammond9114234a7b50
diff --git a/.changeset/metadata-list-columns-selector.md b/.changeset/metadata-list-columns-selector.md
new file mode 100644
index 0000000000..66794b83ea
--- /dev/null
+++ b/.changeset/metadata-list-columns-selector.md
@@ -0,0 +1,7 @@
+---
+'@astryxdesign/cli': patch
+---
+
+[fix] `astryx upgrade` to 0.7 no longer rewrites an app's own class on MetadataList, such as `.astryx-metadata-list.app-compact-list`, into a `[data-columns="app-compact-list"]` selector that never matches. Only the column values MetadataList emitted (`single`, `multi`, and `columns-<n>`) become `data-columns` selectors. (#7982)
+
+@ejhammond
diff --git a/packages/cli/assets/codemods/transforms/v0.7.0/__tests__/migrate-deprecated-theme-surface.test.mjs b/packages/cli/assets/codemods/transforms/v0.7.0/__tests__/migrate-deprecated-theme-surface.test.mjs
index 9a8ca0a647..8d922255c8 100644
--- a/packages/cli/assets/codemods/transforms/v0.7.0/__tests__/migrate-deprecated-theme-surface.test.mjs
+++ b/packages/cli/assets/codemods/transforms/v0.7.0/__tests__/migrate-deprecated-theme-surface.test.mjs
@@ -475,6 +475,21 @@ const theme = {name: 'brand', components: {[oldTarget]: {base: {color: 'red'}}}}
expect(apply(output, 'theme.css')).toBe(output);
});
+ it('maps only the column values MetadataList emitted, not app classes', () => {
+ const output = apply(
+ `.astryx-metadata-list.app-compact-list { gap: 4px; }
+.astryx-metadata-list.columns-3, .astryx-metadata-list.multi { gap: 8px; }`,
+ 'theme.css',
+ );
+ expect(output).toContain('.astryx-metadata-list.app-compact-list');
+ expect(output).not.toContain('data-columns="app-compact-list"');
+ expect(output).toContain('.astryx-metadata-list:is([data-columns="3"])');
+ expect(output).not.toContain('data-columns="columns-3"');
+ expect(output).toContain(
+ '.astryx-metadata-list:is([data-columns="multi"])',
+ );
+ });
+
it('leaves unqualified and unknown consumer classes unchanged', () => {
const input = `.primary { color: red; }
.astryx-button.brand { color: blue; }`;
diff --git a/packages/cli/assets/codemods/transforms/v0.7.0/migrate-deprecated-theme-surface-v0.6-data.mjs b/packages/cli/assets/codemods/transforms/v0.7.0/migrate-deprecated-theme-surface-v0.6-data.mjs
index 21de54111a..2be4baebd2 100644
--- a/packages/cli/assets/codemods/transforms/v0.7.0/migrate-deprecated-theme-surface-v0.6-data.mjs
+++ b/packages/cli/assets/codemods/transforms/v0.7.0/migrate-deprecated-theme-surface-v0.6-data.mjs
@@ -214,6 +214,11 @@ export const V06_THEME_SELECTOR_TARGETS = {
"typeahead": {"error":["status","error"],"lg":["size","lg"],"md":["size","md"],"sm":["size","sm"],"success":["status","success"],"warning":["status","warning"]},
};
+// Only a prop typed as an open string emitted unbounded bare classes
+// (CodeBlock `language`). MetadataList `columns` is `'single' | 'multi' |
+// number`: its strings are in the table above and every number keeps the
+// `columns-` prefix, so any other class beside `.astryx-metadata-list` is
+// the app's own and stays unchanged.
/** @type {Record<string, Array<{axis: string, token: 'class-value' | 'prefixed', prefix?: string}>>} */
// prettier-ignore
export const V06_THEME_SELECTOR_DYNAMIC_AXES = {
@@ -224,6 +229,6 @@ export const V06_THEME_SELECTOR_DYNAMIC_AXES = {
"codeblock-header": [{"axis":"language","token":"class-value"}],
"codeblock-title": [{"axis":"language","token":"class-value"}],
"grid": [{"axis":"columns","token":"prefixed","prefix":"columns-"}],
- "metadata-list": [{"axis":"columns","token":"prefixed","prefix":"columns-"},{"axis":"columns","token":"class-value"}],
+ "metadata-list": [{"axis":"columns","token":"prefixed","prefix":"columns-"}],
"outline-item": [{"axis":"level","token":"prefixed","prefix":"level-"}],
};