Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

test(BottomSheet): read the viewport height without a non-null assertion (#10310)

Christopher Chedeau959c094e3530
diff --git a/packages/core/src/BottomSheet/__tests__/BottomSheetRelease.a11y.chromium.spec.ts b/packages/core/src/BottomSheet/__tests__/BottomSheetRelease.a11y.chromium.spec.ts
index 297ef1535f..39966c257d 100644
--- a/packages/core/src/BottomSheet/__tests__/BottomSheetRelease.a11y.chromium.spec.ts
+++ b/packages/core/src/BottomSheet/__tests__/BottomSheetRelease.a11y.chromium.spec.ts
@@ -279,15 +279,14 @@ test('a flick from the top snap point whose projection passes the next one close
'Nearby places',
);
const top = await restingTop(page);
- const half = await page.evaluate(() => window.innerHeight * 0.5);
+ const height = await page.evaluate(() => window.innerHeight);
+ const half = height * 0.5;
const cdp = await page.context().newCDPSession(page);
// 60 px in 15 ms is 4,000 px/s. 0.1 s ahead it lands past the
// half-height snap point, though nearer it than closed.
const projected = top + 60 + 4000 * sheetTable.release.projectionSeconds;
expect(projected).toBeGreaterThan(half);
- expect(projected - half).toBeLessThan(
- page.viewportSize()!.height - projected,
- );
+ expect(projected - half).toBeLessThan(height - projected);
await drag(cdp, sheet, 60, 15);
await expect(dialog).toBeHidden({timeout: 2_000});
});