An open source design system that's fully customizable and agent ready
TypeScript
feat(core): support destructive variant in Table context menu actions (#4864)
freddymeta98ea85caf40a
diff --git a/.changeset/table-context-action-destructive.md b/.changeset/table-context-action-destructive.mdnew file mode 100644index 0000000000..64cb0217af--- /dev/null+++ b/.changeset/table-context-action-destructive.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[feat] Table: `contextMenuActions` now accept a `variant: 'destructive'` for dangerous row/column actions (e.g. Delete), rendered in the error color to match ContextMenu.++@freddymetadiff --git a/packages/core/src/Table/tableContextMenu.test.tsx b/packages/core/src/Table/tableContextMenu.test.tsxindex 0e9df2714f..006e1b3466 100644--- a/packages/core/src/Table/tableContextMenu.test.tsx+++ b/packages/core/src/Table/tableContextMenu.test.tsx@@ -116,6 +116,33 @@ describe('Table header context menu', () => {screen.queryByRole('menuitem', {hidden: true}),).not.toBeInTheDocument();});++ it('forwards a destructive action variant to the menu item', () => {+ const plugin: TablePlugin<Row> = {+ transformHeaderCell: props => ({+ ...props,+ contextMenuActions: [+ {+ id: 'delete',+ label: 'Delete column',+ variant: 'destructive',+ onSelect: () => {},+ },+ {id: 'pin', label: 'Pin column', onSelect: () => {}},+ ],+ }),+ };+ render(+ <Table data={data} columns={columns} idKey="id" plugins={{plugin}} />,+ );+ fireEvent.contextMenu(screen.getByText('Name'));+ expect(+ screen.getAllByRole('menuitem', {name: 'Delete column', hidden: true})[0],+ ).toHaveAttribute('data-variant', 'destructive');+ expect(+ screen.getAllByRole('menuitem', {name: 'Pin column', hidden: true})[0],+ ).not.toHaveAttribute('data-variant');+ });});// =============================================================================diff --git a/packages/core/src/Table/tableContextMenu.tsx b/packages/core/src/Table/tableContextMenu.tsxindex 0f5079af16..184404b795 100644--- a/packages/core/src/Table/tableContextMenu.tsx+++ b/packages/core/src/Table/tableContextMenu.tsx@@ -79,6 +79,7 @@ function toContextMenuOptions(),isDisabled: action.disabled,onClick: action.onSelect,+ variant: action.variant,});}});diff --git a/packages/core/src/Table/types.ts b/packages/core/src/Table/types.tsindex fef4dc884a..5cbc2f8920 100644--- a/packages/core/src/Table/types.ts+++ b/packages/core/src/Table/types.ts@@ -379,6 +379,11 @@ export interface TableContextAction {group?: string;/** When true, the item renders as checked (e.g. the active sort direction). */checked?: boolean;+ /**+ * Visual variant. `'destructive'` renders the action in the error color for+ * dangerous operations (e.g. Delete row). @default 'default'+ */+ variant?: 'default' | 'destructive';}/**