Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(templates): table-grouped stray panel line + tighten XDS purity (72→85) (#2619)

rubyycheung9aabd5599dad
diff --git a/packages/cli/templates/pages/table-grouped/page.tsx b/packages/cli/templates/pages/table-grouped/page.tsx
index 664ab78a8f..70870a3524 100644
--- a/packages/cli/templates/pages/table-grouped/page.tsx
+++ b/packages/cli/templates/pages/table-grouped/page.tsx
@@ -60,20 +60,10 @@ const pageStyles = stylex.create({
groupHeaderRow: {
cursor: 'pointer',
backgroundColor: 'var(--color-background-muted)',
- borderBottomWidth: 1,
- borderBottomStyle: 'solid',
- borderBottomColor: 'var(--color-border)',
- },
- headerRow: {
- paddingBottom: 'var(--spacing-4)',
},
groupHeaderCell: {
padding: 'var(--spacing-3) var(--spacing-4)',
},
- flexFill: {
- flexGrow: 1,
- minWidth: 0,
- },
});
// Types
@@ -752,6 +742,9 @@ function TaskDetailPanel({
return null;
}
return (
+ // Panel owns the separator (its full-height left border). The adjacent
+ // XDSResizeHandle is kept divider-less + isAlwaysVisible={false} so its
+ // always-on pill doesn't float above the panel as a stray stub.
<XDSLayoutPanel
hasDivider
resizable={resizable}
@@ -997,9 +990,9 @@ export default function DataTableTemplate() {
}
}}
xstyle={[pageStyles.groupHeaderRow]}>
- <td
+ <XDSTableCell
colSpan={COL_COUNT}
- {...stylex.props(pageStyles.groupHeaderCell)}>
+ xstyle={pageStyles.groupHeaderCell}>
<XDSHStack gap={2} vAlign="center">
<XDSIcon
icon={
@@ -1016,7 +1009,7 @@ export default function DataTableTemplate() {
label={String(tasks.length)}
/>
</XDSHStack>
- </td>
+ </XDSTableCell>
</XDSTableRow>
)}
@@ -1141,7 +1134,11 @@ export default function DataTableTemplate() {
end={
selectedTask && (
<>
- <XDSResizeHandle resizable={detailPanel.props} isReversed />
+ <XDSResizeHandle
+ resizable={detailPanel.props}
+ isReversed
+ isAlwaysVisible={false}
+ />
<TaskDetailPanel
task={selectedTask}
onClose={() => setSelectedTask(null)}
diff --git a/packages/cli/templates/pages/table-grouped/template.doc.mjs b/packages/cli/templates/pages/table-grouped/template.doc.mjs
index a98322ae0c..63db5146ff 100644
--- a/packages/cli/templates/pages/table-grouped/template.doc.mjs
+++ b/packages/cli/templates/pages/table-grouped/template.doc.mjs
@@ -5,7 +5,8 @@ export const doc = {
type: 'page',
name: 'Grouped Table',
displayName: 'Grouped Table',
- description: 'Grouped data table with collapsible status sections, PowerSearch, and detail panel',
+ description:
+ 'Grouped data table with collapsible status sections, PowerSearch, and a resizable detail panel.',
isReady: true,
category: 'Table - Grouped',
};
diff --git a/packages/core/src/Markdown/parser.ts b/packages/core/src/Markdown/parser.ts
index 5a82e17d9a..8c0a0f5d62 100644
--- a/packages/core/src/Markdown/parser.ts
+++ b/packages/core/src/Markdown/parser.ts
@@ -426,19 +426,28 @@ const ANGLE_SCHEME = '[a-zA-Z][a-zA-Z0-9+.-]*';
const ANGLE_URL_BODY = '[^<>\\s]*';
/** Bare http(s) URL up to whitespace or `<`. Trailing punctuation is peeled afterwards. */
-const URL_LITERAL_RE = new RegExp(`${SCHEME}${ANY_NON_WHITESPACE_OR_ANGLE}`, 'g');
+const URL_LITERAL_RE = new RegExp(
+ `${SCHEME}${ANY_NON_WHITESPACE_OR_ANGLE}`,
+ 'g',
+);
/** Bare www. URL. Resulting href gets `http://` prepended. */
const WWW_LITERAL_RE = new RegExp(`www\\.${ANY_NON_WHITESPACE_OR_ANGLE}`, 'g');
/** Bare email: local-part@domain (at least one dot in domain). */
-const EMAIL_LITERAL_RE = new RegExp(`${EMAIL_LOCAL_PART}@${DOMAIN_WITH_DOT}`, 'g');
+const EMAIL_LITERAL_RE = new RegExp(
+ `${EMAIL_LOCAL_PART}@${DOMAIN_WITH_DOT}`,
+ 'g',
+);
/** Angle-bracket autolink: `<scheme:url>` (CommonMark §6.5). */
const ANGLE_URL_RE = new RegExp(`<(${ANGLE_SCHEME}:${ANGLE_URL_BODY})>`, 'g');
/** Angle-bracket email: `<[email protected]>`. */
-const ANGLE_EMAIL_RE = new RegExp(`<(${EMAIL_LOCAL_PART}@${DOMAIN_WITH_DOT})>`, 'g');
+const ANGLE_EMAIL_RE = new RegExp(
+ `<(${EMAIL_LOCAL_PART}@${DOMAIN_WITH_DOT})>`,
+ 'g',
+);
/** Characters treated as trailing sentence punctuation per GFM §6.9. */
const TRAILING_PUNCT_CHARS = new Set('?!.,:*_~');