An open source design system that's fully customizable and agent ready
TypeScript
fix(docsite): alphabetize the all templates view (#6297)
Kenton Quatmana8f2807ca2eb
diff --git a/apps/docsite/src/__tests__/template-gallery-order.test.tsx b/apps/docsite/src/__tests__/template-gallery-order.test.tsxnew file mode 100644index 0000000000..958cc6e6c5--- /dev/null+++ b/apps/docsite/src/__tests__/template-gallery-order.test.tsx@@ -0,0 +1,105 @@+// Copyright (c) Meta Platforms, Inc. and affiliates.++// @vitest-environment jsdom++import type {ReactNode} from 'react';+import {render, screen} from '@testing-library/react';+import {describe, expect, it, vi} from 'vitest';++vi.mock('next/navigation', () => ({+ usePathname: () => '/templates',+ useRouter: () => ({replace: vi.fn()}),+ useSearchParams: () => new URLSearchParams(),+}));+vi.mock('@stylexjs/stylex', () => ({+ create: <T,>(styles: T) => styles,+ props: () => ({}),+}));+vi.mock('@astryxdesign/core/AppShell', () => ({+ useAppShellMobile: () => ({isMobile: true}),+}));+vi.mock('@astryxdesign/core/Text', () => ({+ Heading: ({children}: {children: ReactNode}) => <h2>{children}</h2>,+ Text: ({children}: {children: ReactNode}) => <span>{children}</span>,+}));+vi.mock('@astryxdesign/core/Layout', () => ({+ VStack: ({children}: {children: ReactNode}) => <div>{children}</div>,+ HStack: ({children}: {children: ReactNode}) => <div>{children}</div>,+}));+vi.mock('@astryxdesign/core/Section', () => ({+ Section: ({children}: {children: ReactNode}) => <section>{children}</section>,+}));+vi.mock('@astryxdesign/core/Grid', () => ({+ Grid: ({children}: {children: ReactNode}) => <div>{children}</div>,+}));+vi.mock('@astryxdesign/core/ClickableCard', () => ({+ ClickableCard: ({label, children}: {label: string; children: ReactNode}) => (+ <button aria-label={label}>{children}</button>+ ),+}));+vi.mock('@astryxdesign/core/Button', () => ({+ Button: ({label}: {label: string}) => <span>{label}</span>,+}));+vi.mock('@astryxdesign/core/Overlay', () => ({+ Overlay: ({children}: {children: ReactNode}) => <>{children}</>,+}));+vi.mock('@astryxdesign/core/ToggleButton', () => ({+ ToggleButtonGroup: ({children}: {children: ReactNode}) => (+ <div>{children}</div>+ ),+ ToggleButton: ({label}: {label: string}) => <span>{label}</span>,+}));+vi.mock('../generated/templateMetadataRegistry', () => ({+ templateMetadata: [+ {+ name: 'Metrics dashboard',+ slug: 'metrics',+ category: 'Dashboard',+ description: '',+ isReady: true,+ isHiddenFromOverview: false,+ },+ {+ name: 'AI chat',+ slug: 'ai-chat',+ category: 'AI Chat',+ description: '',+ isReady: true,+ isHiddenFromOverview: false,+ },+ {+ name: 'Settings',+ slug: 'settings',+ category: 'Settings',+ description: '',+ isReady: true,+ isHiddenFromOverview: false,+ },+ ],+}));+vi.mock('../components/TemplateThumbnail', () => ({+ TemplateThumbnail: ({slug}: {slug: string}) => <span>{slug}</span>,+}));+vi.mock('../lib/analytics', () => ({+ trackOpenPlayground: vi.fn(),+ trackView: vi.fn(),+}));+vi.mock('../layout.stylex', () => ({layout: {contentMaxWidth: '1200px'}}));++import TemplatesPage from '../app/(site)/templates/page';++describe('TemplatesGallery order', () => {+ it('renders the All view alphabetically by title', () => {+ render(<TemplatesPage />);++ expect(+ screen+ .getAllByRole('button', {name: /^Preview /})+ .map(button => button.getAttribute('aria-label')),+ ).toEqual([+ 'Preview AI chat',+ 'Preview Metrics dashboard',+ 'Preview Settings',+ ]);+ });+});diff --git a/apps/docsite/src/app/(site)/templates/page.tsx b/apps/docsite/src/app/(site)/templates/page.tsxindex a390114d1a..b377975b0f 100644--- a/apps/docsite/src/app/(site)/templates/page.tsx+++ b/apps/docsite/src/app/(site)/templates/page.tsx@@ -26,6 +26,7 @@ import {templateMetadata as templates} from '../../../generated/templateMetadataimport {TemplateThumbnail} from '../../../components/TemplateThumbnail';import {buildTemplatePlaygroundHref} from '../../../components/playgroundLink';import {buildTemplatePreviewHref} from '../../../components/templatePreviewUrl';+import {sortTemplatesByTitle} from '../../../components/templateGalleryOrder';import type {TemplatePreviewItem} from '../../../components/TemplatePreviewDialog';import {trackOpenPlayground, trackView} from '../../../lib/analytics';import {layout} from '../../../layout.stylex';@@ -177,13 +178,13 @@ function TemplatesGallery() {return ['All', ...present];}, [items]);- const filteredItems = useMemo(- () =>+ const filteredItems = useMemo(() => {+ const visibleItems =activeCategory === 'All'? items- : items.filter(i => groupOf(i.category) === activeCategory),- [items, activeCategory],- );+ : items.filter(i => groupOf(i.category) === activeCategory);+ return sortTemplatesByTitle(visibleItems);+ }, [items, activeCategory]);// Flattened display-order list backing the preview dialog's prev/next// navigation, plus a slug -> index lookup for opening at a given card.diff --git a/apps/docsite/src/components/templateGalleryOrder.ts b/apps/docsite/src/components/templateGalleryOrder.tsnew file mode 100644index 0000000000..7e7313b5f7--- /dev/null+++ b/apps/docsite/src/components/templateGalleryOrder.ts@@ -0,0 +1,9 @@+// Copyright (c) Meta Platforms, Inc. and affiliates.++export function sortTemplatesByTitle<T extends {name: string}>(+ templates: readonly T[],+): T[] {+ return [...templates].sort((left, right) =>+ left.name.localeCompare(right.name),+ );+}