Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

Add stricter lint rules (#2357)

Andrey Goderaaa55fbf3c74
diff --git a/apps/docsite/src/app/(marketing)/themes/page.tsx b/apps/docsite/src/app/(marketing)/themes/page.tsx
index 03e0ca4c7e..5147e6553b 100644
--- a/apps/docsite/src/app/(marketing)/themes/page.tsx
+++ b/apps/docsite/src/app/(marketing)/themes/page.tsx
@@ -4,8 +4,6 @@
* Themes gallery — extracted from craft.
*/
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
'use client';
import * as stylex from '@stylexjs/stylex';
diff --git a/apps/sandbox/src/app/(fullscreen)/PreviewShell.tsx b/apps/sandbox/src/app/(fullscreen)/PreviewShell.tsx
index 7f58138f87..7802500205 100644
--- a/apps/sandbox/src/app/(fullscreen)/PreviewShell.tsx
+++ b/apps/sandbox/src/app/(fullscreen)/PreviewShell.tsx
@@ -964,6 +964,7 @@ export function PreviewShell({children}: {children: React.ReactNode}) {
<iframe
ref={iframeRef}
src={iframeSrc}
+ sandbox="allow-scripts allow-same-origin"
title={`${pageName} — ${viewport}`}
style={{
width: '100%',
@@ -985,6 +986,7 @@ export function PreviewShell({children}: {children: React.ReactNode}) {
<iframe
ref={iframeRef}
src={iframeSrc}
+ sandbox="allow-scripts allow-same-origin"
title={`${pageName} — ${viewport}`}
style={{
width: viewportWidths[viewport],
diff --git a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplateCard.tsx b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplateCard.tsx
index 7bf6d94b9c..f39a02e1de 100644
--- a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplateCard.tsx
+++ b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplateCard.tsx
@@ -128,6 +128,7 @@ export function TemplateCard({
{loadIframe && (
<iframe
src={`${basePath}/templates/${slug}/?embed=1`}
+ sandbox="allow-scripts allow-same-origin"
title={name}
loading="lazy"
style={{
diff --git a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreview.tsx b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreview.tsx
index 34e2a64fc6..58e735b2b1 100644
--- a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreview.tsx
+++ b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreview.tsx
@@ -406,6 +406,7 @@ export function TemplatePreview({
{slug ? (
<iframe
src={`${basePath}/templates/${slug}/?embed=1`}
+ sandbox="allow-scripts allow-same-origin"
title={templateName}
style={{
display: 'block',
diff --git a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreviewModal.tsx b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreviewModal.tsx
index f5367e5537..13486f3b87 100644
--- a/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreviewModal.tsx
+++ b/apps/sandbox/src/app/(fullscreen)/pages/docsite/TemplatePreviewModal.tsx
@@ -222,6 +222,7 @@ export function TemplatePreviewModal({
{item.slug ? (
<iframe
src={`${basePath}/templates/${item.slug}/?embed=1`}
+ sandbox="allow-scripts allow-same-origin"
title={item.name}
onLoad={() => setPreviewLoaded(true)}
style={{
@@ -687,6 +688,7 @@ export function TemplatePreviewModal({
{mlItem.slug ? (
<iframe
src={`${basePath}/templates/${mlItem.slug}/?embed=1`}
+ sandbox="allow-scripts allow-same-origin"
title={mlItem.name}
loading="lazy"
style={{
diff --git a/apps/sandbox/src/app/(fullscreen)/pages/docsite/ThemeEditorView.tsx b/apps/sandbox/src/app/(fullscreen)/pages/docsite/ThemeEditorView.tsx
index e215964267..c32ccdb01c 100644
--- a/apps/sandbox/src/app/(fullscreen)/pages/docsite/ThemeEditorView.tsx
+++ b/apps/sandbox/src/app/(fullscreen)/pages/docsite/ThemeEditorView.tsx
@@ -3219,6 +3219,8 @@ function TemplateIframePreview({
<iframe
ref={iframeRef}
src={href}
+ sandbox="allow-scripts allow-same-origin"
+ title="Theme preview"
style={{
width: '100%',
height: '100%',
diff --git a/eslint.config.js b/eslint.config.js
index 5a18fc6c71..f10abf29c4 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -74,6 +74,41 @@ export default tseslint.config(
}],
},
},
+ // Type-aware linting for core. Keep this scoped: projectService has a
+ // measurable startup cost, but catches async correctness issues syntax-only
+ // lint cannot see.
+ {
+ files: ["packages/core/src/**/*.{ts,tsx}"],
+ languageOptions: {
+ parserOptions: {
+ projectService: true,
+ },
+ },
+ rules: {
+ "@typescript-eslint/await-thenable": reactSeverity,
+ "@typescript-eslint/no-array-delete": reactSeverity,
+ "@typescript-eslint/no-base-to-string": reactSeverity,
+ "@typescript-eslint/no-duplicate-type-constituents": reactSeverity,
+ "@typescript-eslint/no-dynamic-delete": reactSeverity,
+ "@typescript-eslint/no-floating-promises": reactSeverity,
+ "@typescript-eslint/no-for-in-array": reactSeverity,
+ "@typescript-eslint/no-implied-eval": reactSeverity,
+ "@typescript-eslint/no-invalid-void-type": reactSeverity,
+ "@typescript-eslint/no-misused-promises": reactSeverity,
+ "@typescript-eslint/no-unnecessary-type-conversion": reactSeverity,
+ "@typescript-eslint/no-unnecessary-type-assertion": reactSeverity,
+ "@typescript-eslint/no-useless-default-assignment": reactSeverity,
+ "@typescript-eslint/no-redeclare": reactSeverity,
+ "@typescript-eslint/only-throw-error": reactSeverity,
+ "@typescript-eslint/prefer-includes": reactSeverity,
+ "@typescript-eslint/prefer-string-starts-ends-with": reactSeverity,
+ "@typescript-eslint/require-array-sort-compare": reactSeverity,
+ "@typescript-eslint/restrict-plus-operands": reactSeverity,
+ "@typescript-eslint/restrict-template-expressions": reactSeverity,
+ "@typescript-eslint/return-await": reactSeverity,
+ "@typescript-eslint/switch-exhaustiveness-check": reactSeverity,
+ },
+ },
// Copyright header — all source files must have the Meta copyright notice
{
files: ["**/*.{ts,tsx}"],
@@ -137,6 +172,7 @@ export default tseslint.config(
// DOM correctness
'@eslint-react/dom-no-missing-button-type': reactSeverity,
+ '@eslint-react/dom-no-missing-iframe-sandbox': reactSeverity,
'@eslint-react/dom-no-void-elements-with-children': reactSeverity,
'@eslint-react/dom-no-dangerously-set-innerhtml': reactSeverity,
'@eslint-react/dom-no-dangerously-set-innerhtml-with-children': reactSeverity,
@@ -144,10 +180,12 @@ export default tseslint.config(
'@eslint-react/dom-no-flush-sync': reactSeverity,
'@eslint-react/dom-no-script-url': reactSeverity,
'@eslint-react/dom-no-string-style-prop': reactSeverity,
+ '@eslint-react/dom-no-unsafe-target-blank': reactSeverity,
'@eslint-react/dom-no-unknown-property': reactSeverity,
// JSX correctness
'@eslint-react/no-missing-key': reactSeverity,
+ '@eslint-react/no-array-index-key': reactSeverity,
'@eslint-react/jsx-no-comment-textnodes': reactSeverity,
'@eslint-react/jsx-no-leaked-dollar': reactSeverity,
'@eslint-react/jsx-no-children-prop': reactSeverity,
@@ -173,6 +211,30 @@ export default tseslint.config(
'@eslint-react/web-api-no-leaked-fetch': reactSeverity,
},
},
+ // App preview surfaces may embed local pages, but every iframe must be sandboxed.
+ {
+ files: ["apps/docsite/**/*.{ts,tsx}", "apps/sandbox/**/*.{ts,tsx}"],
+ plugins: {
+ ...eslintReact.configs.recommended.plugins,
+ },
+ rules: {
+ '@eslint-react/dom-no-missing-iframe-sandbox': reactSeverity,
+ },
+ },
+ // Browser documentation/demo surfaces should avoid unsafe new-tab links.
+ {
+ files: [
+ "apps/docsite/**/*.{ts,tsx}",
+ "apps/sandbox/**/*.{ts,tsx}",
+ "apps/storybook/**/*.{ts,tsx}",
+ ],
+ plugins: {
+ ...eslintReact.configs.recommended.plugins,
+ },
+ rules: {
+ '@eslint-react/dom-no-unsafe-target-blank': reactSeverity,
+ },
+ },
// Test files — relax rules for test ergonomics (must be after React rules
// block so it overrides react-compiler/react-compiler)
{
diff --git a/internal/eslint-plugin-xds/copyright-header.js b/internal/eslint-plugin-xds/copyright-header.js
index 52fe73065e..cfca3b918a 100644
--- a/internal/eslint-plugin-xds/copyright-header.js
+++ b/internal/eslint-plugin-xds/copyright-header.js
@@ -14,8 +14,12 @@ const rule = {
},
fixable: 'code',
messages: {
+ duplicateHeader:
+ 'File must contain exactly one copyright header: "// Copyright (c) Meta Platforms, Inc. and affiliates."',
missingHeader:
'File is missing the copyright header: "// Copyright (c) Meta Platforms, Inc. and affiliates."',
+ misplacedHeader:
+ 'Copyright header must be the first line of the file: "// Copyright (c) Meta Platforms, Inc. and affiliates."',
},
schema: [],
},
@@ -26,15 +30,52 @@ const rule = {
const comments = source.getAllComments();
const firstToken = source.getFirstToken(node);
- const hasCopyright =
- comments.some(
- (c) => c.type === 'Line' && c.value.trim() === COPYRIGHT,
- ) ||
- comments.some(
- (c) => c.type === 'Block' && c.value.trim() === COPYRIGHT,
- );
+ const copyrightComments = comments.filter(
+ comment => comment.value.trim() === COPYRIGHT,
+ );
+ const [copyrightComment] = copyrightComments;
- if (hasCopyright) {
+ if (
+ copyrightComments.length === 1 &&
+ isCanonicalHeader(source, copyrightComment)
+ ) {
+ return;
+ }
+
+ if (copyrightComments.length > 1) {
+ context.report({
+ node,
+ loc: {line: 1, column: 0},
+ messageId: 'duplicateHeader',
+ fix(fixer) {
+ const canonicalHeader =
+ copyrightComments.find(comment =>
+ isCanonicalHeader(source, comment),
+ ) ?? null;
+
+ if (canonicalHeader != null) {
+ return copyrightComments
+ .filter(comment => comment !== canonicalHeader)
+ .map(comment =>
+ fixer.removeRange(getCommentRemovalRange(source, comment)),
+ );
+ }
+
+ return normalizeHeaderFixes(fixer, source, copyrightComments);
+ },
+ });
+ return;
+ }
+
+ if (copyrightComments.length === 1) {
+ context.report({
+ node,
+ loc: {line: 1, column: 0},
+ messageId: 'misplacedHeader',
+ fix(fixer) {
+ return normalizeHeaderFixes(fixer, source, [copyrightComment]);
+ },
+ });
return;
}
@@ -43,8 +84,12 @@ const rule = {
loc: {line: 1, column: 0},
messageId: 'missingHeader',
fix(fixer) {
- if (firstToken) {
- return fixer.insertTextBefore(firstToken, `${COMMENT_TEXT}\n\n`);
+ const insertOffset = getHeaderInsertOffset(source);
+ if (firstToken || insertOffset > 0) {
+ return fixer.insertTextAfterRange(
+ [insertOffset, insertOffset],
+ getHeaderInsertionText(source, insertOffset),
+ );
}
return fixer.insertTextAfterRange([0, 0], `${COMMENT_TEXT}\n`);
},
@@ -54,4 +99,90 @@ const rule = {
},
};
+function isCanonicalHeader(source, comment) {
+ const expectedLine = hasShebang(source) ? 2 : 1;
+ return (
+ comment.type === 'Line' &&
+ comment.loc.start.line === expectedLine &&
+ comment.loc.start.column === 0
+ );
+}
+
+function normalizeHeaderFixes(fixer, source, copyrightComments) {
+ const [firstCopyrightComment, ...extraCopyrightComments] = copyrightComments;
+ const insertOffset = getHeaderInsertOffset(source);
+
+ if (
+ source.text.slice(insertOffset, firstCopyrightComment.range[0]).trim() ===
+ ''
+ ) {
+ return [
+ fixer.replaceTextRange(
+ [
+ insertOffset,
+ getCommentRemovalRange(source, firstCopyrightComment)[1],
+ ],
+ `${COMMENT_TEXT}\n\n`,
+ ),
+ ...extraCopyrightComments.map(comment =>
+ fixer.removeRange(getCommentRemovalRange(source, comment)),
+ ),
+ ];
+ }
+
+ return [
+ fixer.insertTextAfterRange(
+ [insertOffset, insertOffset],
+ getHeaderInsertionText(source, insertOffset),
+ ),
+ ...copyrightComments.map(comment =>
+ fixer.removeRange(getCommentRemovalRange(source, comment)),
+ ),
+ ];
+}
+
+function hasShebang(source) {
+ return source.text.startsWith('#!');
+}
+
+function getHeaderInsertOffset(source) {
+ if (!hasShebang(source)) {
+ return 0;
+ }
+ const newlineIndex = source.text.search(/\r\n|\n|\r/);
+ if (newlineIndex === -1) {
+ return source.text.length;
+ }
+ if (source.text.startsWith('\r\n', newlineIndex)) {
+ return newlineIndex + 2;
+ }
+ return newlineIndex + 1;
+}
+
+function getHeaderInsertionText(source, insertOffset) {
+ const hasBlankLineAtInsertion = /^[ \t]*(?:\r\n|\n|\r)/.test(
+ source.text.slice(insertOffset),
+ );
+ return hasBlankLineAtInsertion ? `${COMMENT_TEXT}\n` : `${COMMENT_TEXT}\n\n`;
+}
+
+function getCommentRemovalRange(source, comment) {
+ const text = source.text;
+ let [, end] = comment.range;
+
+ if (text.startsWith('\r\n', end)) {
+ end += 2;
+ } else if (text[end] === '\n' || text[end] === '\r') {
+ end += 1;
+ }
+
+ const blankLineAfterComment = /^[ \t]*(?:\r\n|\n|\r)/.exec(text.slice(end));
+
+ if (blankLineAfterComment != null) {
+ end += blankLineAfterComment[0].length;
+ }
+
+ return [comment.range[0], end];
+}
+
export default rule;
diff --git a/internal/eslint-plugin-xds/copyright-header.test.mjs b/internal/eslint-plugin-xds/copyright-header.test.mjs
index a8f5306026..a3b5cd1cd9 100644
--- a/internal/eslint-plugin-xds/copyright-header.test.mjs
+++ b/internal/eslint-plugin-xds/copyright-header.test.mjs
@@ -10,20 +10,62 @@ describe('copyright-header', () => {
it('passes the RuleTester', () => {
ruleTester.run('copyright-header', copyrightHeaderRule, {
valid: [
- {code: '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;'},
+ {
+ code: '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
+ {
+ code: '#!/usr/bin/env node\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
{code: '// Copyright (c) Meta Platforms, Inc. and affiliates.\n'},
- {code: '/* Copyright (c) Meta Platforms, Inc. and affiliates. */\n\nconst x = 1;'},
],
invalid: [
{
code: 'const x = 1;',
errors: [{messageId: 'missingHeader'}],
- output: '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
},
{
code: "'use client';\n\nconst x = 1;",
errors: [{messageId: 'missingHeader'}],
- output: "// Copyright (c) Meta Platforms, Inc. and affiliates.\n\n'use client';\n\nconst x = 1;",
+ output:
+ "// Copyright (c) Meta Platforms, Inc. and affiliates.\n\n'use client';\n\nconst x = 1;",
+ },
+ {
+ code: '#!/usr/bin/env node\n\nconst x = 1;',
+ errors: [{messageId: 'missingHeader'}],
+ output:
+ '#!/usr/bin/env node\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
+ {
+ code: '\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ errors: [{messageId: 'misplacedHeader'}],
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
+ {
+ code: 'const x = 1;\n\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n',
+ errors: [{messageId: 'misplacedHeader'}],
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;\n\n',
+ },
+ {
+ code: '/* Copyright (c) Meta Platforms, Inc. and affiliates. */\n\nconst x = 1;',
+ errors: [{messageId: 'misplacedHeader'}],
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
+ {
+ code: '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ errors: [{messageId: 'duplicateHeader'}],
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ },
+ {
+ code: '/* Copyright (c) Meta Platforms, Inc. and affiliates. */\n\n// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
+ errors: [{messageId: 'duplicateHeader'}],
+ output:
+ '// Copyright (c) Meta Platforms, Inc. and affiliates.\n\nconst x = 1;',
},
],
});
diff --git a/package.json b/package.json
index edba76dd80..906c5aecd1 100644
--- a/package.json
+++ b/package.json
@@ -12,8 +12,8 @@
"check:package-boundaries": "node scripts/check-package-boundaries.js",
"check:repo": "pnpm check:sync && pnpm check:package-boundaries",
"check:sync": "node scripts/check-sync.js",
- "lint": "pnpm check:repo && eslint .",
- "lint:strict": "pnpm check:repo && XDS_STRICT_LINT=1 eslint .",
+ "lint": "pnpm check:repo && eslint . --cache",
+ "lint:strict": "pnpm check:repo && XDS_STRICT_LINT=1 eslint . --cache",
"storybook": "pnpm -F @xds/storybook dev",
"storybook:build": "pnpm -F @xds/storybook build",
"docs": "pnpm -F @xds/docs dev",
diff --git a/packages/core/src/AvatarGroup/XDSAvatarGroupOverflow.tsx b/packages/core/src/AvatarGroup/XDSAvatarGroupOverflow.tsx
index 278f7d9403..64ea545540 100644
--- a/packages/core/src/AvatarGroup/XDSAvatarGroupOverflow.tsx
+++ b/packages/core/src/AvatarGroup/XDSAvatarGroupOverflow.tsx
@@ -141,7 +141,7 @@ export function XDSAvatarGroupOverflow({
return (
<span
- ref={ref as React.Ref<HTMLSpanElement>}
+ ref={ref}
aria-label={label}
{...mergeProps(
xdsClassName('avatar-group-overflow'),
diff --git a/packages/core/src/Banner/XDSBanner.tsx b/packages/core/src/Banner/XDSBanner.tsx
index e767abac16..51f8790a8e 100644
--- a/packages/core/src/Banner/XDSBanner.tsx
+++ b/packages/core/src/Banner/XDSBanner.tsx
@@ -407,11 +407,7 @@ export function XDSBanner({
<div
ref={ref}
role={role}
- {...mergeProps(
- stylex.props(styles.root, xstyle),
- className,
- style,
- )}
+ {...mergeProps(stylex.props(styles.root, xstyle), className, style)}
{...rest}>
{/* Header: colored status background — primary theme target ('banner') */}
<div
@@ -449,7 +445,7 @@ export function XDSBanner({
<div
{...stylex.props(
styles.endArea,
- edgeCompSlot.inset(spacingVars['--spacing-2'] as string),
+ edgeCompSlot.inset(spacingVars['--spacing-2']),
)}>
{endContent}
{hasChildren && (
diff --git a/packages/core/src/Calendar/XDSCalendar.tsx b/packages/core/src/Calendar/XDSCalendar.tsx
index b0f9f45e1c..7e25ac9f0e 100644
--- a/packages/core/src/Calendar/XDSCalendar.tsx
+++ b/packages/core/src/Calendar/XDSCalendar.tsx
@@ -523,7 +523,7 @@ function MonthGrid({
// Parse selected date for roving tabindex priority
const selectedDateForTabindex = useMemo(() => {
if (mode === 'single' && value && typeof value === 'string') {
- return plainDateFromISO(value as ISODateString);
+ return plainDateFromISO(value);
}
return null;
}, [mode, value]);
@@ -640,9 +640,9 @@ function MonthGrid({
let rangeEnd: PlainDate | null = null;
if (mode === 'single' && value && typeof value === 'string') {
- selectedDate = plainDateFromISO(value as ISODateString);
+ selectedDate = plainDateFromISO(value);
} else if (mode === 'range' && value && typeof value === 'object') {
- const range = value as DateRange;
+ const range = value;
rangeStart = plainDateFromISO(range.start);
rangeEnd = plainDateFromISO(range.end);
}
@@ -691,9 +691,9 @@ function MonthGrid({
)}
/>
)}
- {dayNames.map((name, i) => (
+ {dayNames.map(name => (
<div
- key={i}
+ key={name}
role="columnheader"
{...stylex.props(monthGridStyles.dayName)}>
{name}
@@ -711,13 +711,13 @@ function MonthGrid({
monthGridStyles.daysGrid,
hasWeekNumbers && monthGridStyles.daysGridWithNumbers,
)}>
- {weeks.map((week, weekIndex) => {
+ {weeks.map(week => {
const weekDate = week.find(d => !d.isOutside)?.date || week[0].date;
const weekNum = plainDateGetWeekNumber(weekDate);
return (
<div
- key={weekIndex}
+ key={plainDateToISO(weekDate)}
role="row"
{...stylex.props(monthGridStyles.weekRow)}>
{hasWeekNumbers && (
@@ -727,7 +727,7 @@ function MonthGrid({
)}
{week.map((day, dayIndex) => (
<DayCell
- key={dayIndex}
+ key={day.iso}
day={day}
dayIndex={dayIndex}
mode={mode}
diff --git a/packages/core/src/Carousel/XDSCarousel.tsx b/packages/core/src/Carousel/XDSCarousel.tsx
index 7df99b9a34..3533d76b0f 100644
--- a/packages/core/src/Carousel/XDSCarousel.tsx
+++ b/packages/core/src/Carousel/XDSCarousel.tsx
@@ -168,7 +168,7 @@ const styles = stylex.create({
opacity: 0,
pointerEvents: 'none' as const,
},
- // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- CSS custom property requires type widening for StyleX
+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion, @typescript-eslint/consistent-type-assertions -- CSS custom property requires type widening for StyleX
buttonRadiusOverride: {
'--_button-radius': radiusVars['--radius-full'],
} as Record<string, string>,
diff --git a/packages/core/src/Chat/XDSChatComposerInput.tsx b/packages/core/src/Chat/XDSChatComposerInput.tsx
index aa84c07708..efc085845d 100644
--- a/packages/core/src/Chat/XDSChatComposerInput.tsx
+++ b/packages/core/src/Chat/XDSChatComposerInput.tsx
@@ -176,7 +176,7 @@ export interface XDSChatComposerInputProps extends Omit<
onPaste?: (
event: ClipboardEvent<HTMLDivElement>,
text: string,
- ) => boolean | void;
+ ) => boolean | void; // eslint-disable-line @typescript-eslint/no-invalid-void-type
/**
* Paste-as-token behavior. Defaults to converting pastes over 200 chars
* into token chips. Pass a custom useXDSChatPasteAsToken result to override,
diff --git a/packages/core/src/Chat/XDSChatDictationButton.tsx b/packages/core/src/Chat/XDSChatDictationButton.tsx
index bca89ac419..f29b7fe89b 100644
--- a/packages/core/src/Chat/XDSChatDictationButton.tsx
+++ b/packages/core/src/Chat/XDSChatDictationButton.tsx
@@ -137,6 +137,7 @@ export function XDSChatDictationButton({
const scale = BAR_MIN_SCALE + level * (1 - BAR_MIN_SCALE);
return (
<span
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- equalizer bars are fixed positional slots
key={i}
{...mergeProps(stylex.props(styles.bar), {
style: {
diff --git a/packages/core/src/Chat/useSpeechRecognition.ts b/packages/core/src/Chat/useSpeechRecognition.ts
index e9a7ef540a..5e0d89ad78 100644
--- a/packages/core/src/Chat/useSpeechRecognition.ts
+++ b/packages/core/src/Chat/useSpeechRecognition.ts
@@ -246,7 +246,7 @@ export function getDefaultAudioContext(): AudioContext {
_sharedAudioCtx = new AudioContext();
}
if (_sharedAudioCtx.state === 'suspended') {
- _sharedAudioCtx.resume();
+ void _sharedAudioCtx.resume();
}
return _sharedAudioCtx;
}
@@ -353,7 +353,7 @@ export function useSpeechRecognition(
recognition.onstart = () => {
setIsListening(true);
callbacksRef.current.onStart?.();
- createVolumeAnalyser(getAudioContextRef.current).then(a => {
+ void createVolumeAnalyser(getAudioContextRef.current).then(a => {
if (a) {
analyserRef.current = a;
startVolumePolling();
diff --git a/packages/core/src/Chat/useXDSChatDictation.ts b/packages/core/src/Chat/useXDSChatDictation.ts
index 47aafb08e3..819c519f5c 100644
--- a/packages/core/src/Chat/useXDSChatDictation.ts
+++ b/packages/core/src/Chat/useXDSChatDictation.ts
@@ -202,7 +202,7 @@ function getDefaultAudioContext(): AudioContext {
_sharedAudioCtx = new AudioContext();
}
if (_sharedAudioCtx.state === 'suspended') {
- _sharedAudioCtx.resume();
+ void _sharedAudioCtx.resume();
}
return _sharedAudioCtx;
}
@@ -439,7 +439,7 @@ export function useXDSChatDictation(
if (hasSounds) {
playStartSound(getAudioContextRef.current);
}
- createVolumeAnalyser(getAudioContextRef.current).then(analyser => {
+ void createVolumeAnalyser(getAudioContextRef.current).then(analyser => {
if (analyser) {
analyserRef.current = analyser;
startVolumePolling();
diff --git a/packages/core/src/CodeBlock/XDSCodeBlock.tsx b/packages/core/src/CodeBlock/XDSCodeBlock.tsx
index a9a70057f3..98784a0af0 100644
--- a/packages/core/src/CodeBlock/XDSCodeBlock.tsx
+++ b/packages/core/src/CodeBlock/XDSCodeBlock.tsx
@@ -383,7 +383,7 @@ function isSafari(): boolean {
return false;
}
const ua = navigator.userAgent;
- return /AppleWebKit/.test(ua) && !/Chrome/.test(ua);
+ return ua.includes('AppleWebKit') && !ua.includes('Chrome');
}
/**
@@ -414,19 +414,28 @@ function useTokenLines(
const abortController = new AbortController();
if (customTokenizer) {
- Promise.resolve().then(() => {
- if (abortController.signal.aborted) {
- return;
+ try {
+ if (!abortController.signal.aborted) {
+ const flat = customTokenizer(code, language);
+ setAsyncTokens(flatTokensToLines(flat, code));
}
- const flat = customTokenizer(code, language);
- setAsyncTokens(flatTokensToLines(flat, code));
- });
- } else {
- tokenizeAsync(code, language, abortController.signal).then(tokens => {
+ } catch {
if (!abortController.signal.aborted) {
- setAsyncTokens(tokens);
+ setAsyncTokens(null);
}
- });
+ }
+ } else {
+ void tokenizeAsync(code, language, abortController.signal)
+ .then(tokens => {
+ if (!abortController.signal.aborted) {
+ setAsyncTokens(tokens);
+ }
+ })
+ .catch(() => {
+ if (!abortController.signal.aborted) {
+ setAsyncTokens(null);
+ }
+ });
}
return () => {
@@ -618,12 +627,15 @@ export function XDSCodeBlock({
[highlightLines],
);
- const handleCopy = useCallback(() => {
- navigator.clipboard.writeText(code).then(() => {
+ const handleCopy = useCallback(async () => {
+ try {
+ await navigator.clipboard.writeText(code);
setCopied(true);
onCopy?.();
setTimeout(() => setCopied(false), 2000);
- });
+ } catch {
+ // Clipboard failures leave the copied state unchanged.
+ }
}, [code, onCopy]);
const sizeStyle = size === 'sm' ? styles.sizeSm : styles.sizeMd;
@@ -670,7 +682,9 @@ export function XDSCodeBlock({
const copyButtonEl = hasCopyButton ? (
<button
type="button"
- onClick={handleCopy}
+ onClick={() => {
+ void handleCopy();
+ }}
aria-label={copied ? 'Copied' : 'Copy code'}
{...stylex.props(
styles.copyButton,
@@ -735,6 +749,7 @@ export function XDSCodeBlock({
{...stylex.props(styles.gutter, gutterSizeStyle)}
aria-hidden="true">
{lines.map((_, i) => (
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- gutter line numbers are positional by definition
<div key={i} {...stylex.props(styles.gutterLine)}>
{i + 1}
</div>
diff --git a/packages/core/src/DateRangeInput/XDSDateRangeInput.test.tsx b/packages/core/src/DateRangeInput/XDSDateRangeInput.test.tsx
index bf971fc772..d6416230b8 100644
--- a/packages/core/src/DateRangeInput/XDSDateRangeInput.test.tsx
+++ b/packages/core/src/DateRangeInput/XDSDateRangeInput.test.tsx
@@ -1,3 +1,5 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
/**
* @file XDSDateRangeInput.test.tsx
* @input Uses vitest, @testing-library/react, XDSDateRangeInput component
@@ -7,13 +9,10 @@
* SYNC: When XDSDateRangeInput.tsx changes, update tests to match new behavior
*/
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
import {describe, it, expect, vi} from 'vitest';
import {render, screen, fireEvent} from '@testing-library/react';
import {XDSDateRangeInput} from './XDSDateRangeInput';
import type {XDSDateRange} from './XDSDateRangeInput';
-import type {ISODateString} from '../Calendar';
describe('XDSDateRangeInput', () => {
it('renders with label', () => {
@@ -44,8 +43,8 @@ describe('XDSDateRangeInput', () => {
it('displays formatted range when value is set', () => {
const range: XDSDateRange = {
- start: '2026-03-15' as ISODateString,
- end: '2026-03-22' as ISODateString,
+ start: '2026-03-15',
+ end: '2026-03-22',
};
render(
<XDSDateRangeInput
@@ -237,8 +236,8 @@ describe('XDSDateRangeInput', () => {
describe('hasClear', () => {
it('shows clear button when hasClear is true and value exists', () => {
const range: XDSDateRange = {
- start: '2026-03-15' as ISODateString,
- end: '2026-03-22' as ISODateString,
+ start: '2026-03-15',
+ end: '2026-03-22',
};
render(
<XDSDateRangeInput
@@ -269,8 +268,8 @@ describe('XDSDateRangeInput', () => {
it('does not show clear button when hasClear is false', () => {
const range: XDSDateRange = {
- start: '2026-03-15' as ISODateString,
- end: '2026-03-22' as ISODateString,
+ start: '2026-03-15',
+ end: '2026-03-22',
};
render(
<XDSDateRangeInput
@@ -287,8 +286,8 @@ describe('XDSDateRangeInput', () => {
it('does not show clear button when disabled', () => {
const range: XDSDateRange = {
- start: '2026-03-15' as ISODateString,
- end: '2026-03-22' as ISODateString,
+ start: '2026-03-15',
+ end: '2026-03-22',
};
render(
<XDSDateRangeInput
@@ -307,8 +306,8 @@ describe('XDSDateRangeInput', () => {
it('calls onChange with null when clear is clicked', () => {
const onChange = vi.fn();
const range: XDSDateRange = {
- start: '2026-03-15' as ISODateString,
- end: '2026-03-22' as ISODateString,
+ start: '2026-03-15',
+ end: '2026-03-22',
};
render(
<XDSDateRangeInput
diff --git a/packages/core/src/DateRangeInput/XDSDateRangeInput.tsx b/packages/core/src/DateRangeInput/XDSDateRangeInput.tsx
index 7244e9e856..7c9e05b964 100644
--- a/packages/core/src/DateRangeInput/XDSDateRangeInput.tsx
+++ b/packages/core/src/DateRangeInput/XDSDateRangeInput.tsx
@@ -365,7 +365,7 @@ export function XDSDateRangeInput({
ref,
...rest
}: XDSDateRangeInputProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSDateRangeInputSize;
+ const size = useXDSSize(sizeProp, 'md');
const id = useId();
const descriptionID = useId();
const statusMessageID = useId();
@@ -560,12 +560,12 @@ export function XDSDateRangeInput({
role="listbox"
aria-label="Preset date ranges"
{...stylex.props(styles.presetSidebar)}>
- {presets.map((preset, i) => {
+ {presets.map(preset => {
const presetRange = preset.getRange();
const isActive = isRangeEqual(value, presetRange);
return (
<button
- key={i}
+ key={preset.label}
type="button"
role="option"
aria-selected={isActive}
diff --git a/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx b/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx
index c20707570b..8045c860cd 100644
--- a/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx
+++ b/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx
@@ -388,7 +388,7 @@ export function XDSDateTimeInput({
ref,
...rest
}: XDSDateTimeInputProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSDateTimeInputSize;
+ const size = useXDSSize(sizeProp, 'md');
const dateInputId = useId();
const timeInputId = useId();
const descriptionID = useId();
diff --git a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
index 299d1b13f0..f9591bea5d 100644
--- a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
+++ b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
@@ -204,7 +204,7 @@ export function XDSDropdownMenu({
...props
}: XDSDropdownMenuProps) {
const items = ('items' in props ? props.items : undefined) ?? [];
- const children = props.children as ReactNode;
+ const children = props.children;
const menuId = useId();
const menuSize = button?.size ?? 'md';
diff --git a/packages/core/src/DropdownMenu/renderXDSDropdownItems.tsx b/packages/core/src/DropdownMenu/renderXDSDropdownItems.tsx
index 83a2894e01..e8a8564d62 100644
--- a/packages/core/src/DropdownMenu/renderXDSDropdownItems.tsx
+++ b/packages/core/src/DropdownMenu/renderXDSDropdownItems.tsx
@@ -16,7 +16,11 @@ import {
typeScaleVars,
colorVars,
} from '../theme/tokens.stylex';
-import type {XDSDropdownMenuOption} from './XDSDropdownMenu';
+import type {
+ XDSDropdownMenuItemData,
+ XDSDropdownMenuOption,
+ XDSDropdownMenuSection,
+} from './XDSDropdownMenu';
const styles = stylex.create({
sectionHeading: {
@@ -33,6 +37,14 @@ const styles = stylex.create({
},
});
+function getItemKey(item: XDSDropdownMenuItemData): string {
+ return `item-${item.label}`;
+}
+
+function getSectionKey(section: XDSDropdownMenuSection, index: number): string {
+ return `section-${section.title ?? index}`;
+}
+
/**
* Converts data-driven items into XDSDropdownMenuItem components,
* so both modes share the same rendering and keyboard navigation path.
@@ -51,15 +63,18 @@ export function renderXDSDropdownItems(
);
} else if ('type' in option && option.type === 'section') {
elements.push(
- <div key={`section-${i}`} role="group" aria-label={option.title}>
+ <div
+ key={getSectionKey(option, i)}
+ role="group"
+ aria-label={option.title}>
{option.title && (
<div {...stylex.props(styles.sectionHeading)} aria-hidden="true">
{option.title}
</div>
)}
- {option.items.map((item, j) => (
+ {option.items.map(item => (
<XDSDropdownMenuItem
- key={`${item.label}-${j}`}
+ key={getItemKey(item)}
icon={item.icon}
label={item.label}
onClick={item.onClick}
@@ -71,7 +86,7 @@ export function renderXDSDropdownItems(
} else if (!('type' in option)) {
elements.push(
<XDSDropdownMenuItem
- key={`${option.label}-${i}`}
+ key={getItemKey(option)}
icon={option.icon}
label={option.label}
onClick={option.onClick}
diff --git a/packages/core/src/Field/XDSField.tsx b/packages/core/src/Field/XDSField.tsx
index de7537eb48..0ba1ab8a3f 100644
--- a/packages/core/src/Field/XDSField.tsx
+++ b/packages/core/src/Field/XDSField.tsx
@@ -20,7 +20,7 @@ import {type ReactNode, use} from 'react';
import * as stylex from '@stylexjs/stylex';
import type {XDSBaseProps} from '../XDSBaseProps';
import {XDSFieldLabel} from './XDSFieldLabel';
-import {XDSFieldStatus} from './XDSFieldStatus';
+import {XDSFieldStatus as XDSFieldStatusComponent} from './XDSFieldStatus';
import {spacingVars, borderVars} from '../theme/tokens.stylex';
import type {XDSIconType} from '../Icon';
import {xdsClassName, mergeProps} from '../utils';
@@ -199,7 +199,7 @@ export function XDSField({
);
const statusNode = status?.message ? (
- <XDSFieldStatus
+ <XDSFieldStatusComponent
type={status.type}
message={status.message}
id={resolvedMessageID}
diff --git a/packages/core/src/FileInput/XDSFileInput.test.tsx b/packages/core/src/FileInput/XDSFileInput.test.tsx
index 095f264aa8..5ebd740362 100644
--- a/packages/core/src/FileInput/XDSFileInput.test.tsx
+++ b/packages/core/src/FileInput/XDSFileInput.test.tsx
@@ -1,3 +1,5 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
/**
* @file XDSFileInput.test.tsx
* @input Uses vitest, @testing-library/react, XDSFileInput component
@@ -7,8 +9,6 @@
* SYNC: When XDSFileInput.tsx changes, update tests to match new behavior
*/
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
import {describe, it, expect, vi} from 'vitest';
import {render, screen, fireEvent} from '@testing-library/react';
import userEvent from '@testing-library/user-event';
diff --git a/packages/core/src/HoverCard/XDSHoverCard.test.tsx b/packages/core/src/HoverCard/XDSHoverCard.test.tsx
index 357eddf144..167c52e93a 100644
--- a/packages/core/src/HoverCard/XDSHoverCard.test.tsx
+++ b/packages/core/src/HoverCard/XDSHoverCard.test.tsx
@@ -310,7 +310,7 @@ describe('XDSHoverCard', () => {
// Focus the content button
const contentButton = screen.getByText('Interactive button');
- (contentButton as HTMLElement).focus();
+ contentButton.focus();
// Press Escape - should refocus trigger
fireEvent.keyDown(contentButton, {key: 'Escape'});
@@ -342,7 +342,7 @@ describe('XDSHoverCard', () => {
// Focus the content button
const contentButton = screen.getByText('Interactive button');
- (contentButton as HTMLElement).focus();
+ contentButton.focus();
// Clear the mock to track new calls
onOpenChange.mockClear();
diff --git a/packages/core/src/InputGroup/XDSInputGroup.test.tsx b/packages/core/src/InputGroup/XDSInputGroup.test.tsx
index b67ba9d23f..12cb89e062 100644
--- a/packages/core/src/InputGroup/XDSInputGroup.test.tsx
+++ b/packages/core/src/InputGroup/XDSInputGroup.test.tsx
@@ -1,3 +1,5 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
/**
* @file XDSInputGroup.test.tsx
* @input Uses vitest, @testing-library/react, InputGroup and TextInput components
@@ -7,8 +9,6 @@
* SYNC: When InputGroup component changes, update tests to match new behavior
*/
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
import {describe, it, expect} from 'vitest';
import {render, screen} from '@testing-library/react';
import {XDSInputGroup} from './XDSInputGroup';
diff --git a/packages/core/src/Item/Item.doc.mjs b/packages/core/src/Item/Item.doc.mjs
index 2d66fcf0c6..ce1c38f4c7 100644
--- a/packages/core/src/Item/Item.doc.mjs
+++ b/packages/core/src/Item/Item.doc.mjs
@@ -34,7 +34,8 @@ export const docs = {
{name: 'descriptionLines', type: 'number', description: 'Max lines before description truncates with ellipsis.'},
{name: 'onClick', type: '(event: MouseEvent) => void', description: 'Click handler. Makes the item clickable with button semantics.'},
{name: 'href', type: 'string', description: 'Link URL. Makes the item a link via an invisible anchor element.'},
- {name: 'target', type: "'_blank' | '_self'", description: 'Link target. Only used with href.'},
+ {name: 'target', type: "'_blank' | '_self'", description: 'Link target. Only used with href. target="_blank" automatically adds noopener noreferrer.'},
+ {name: 'rel', type: 'string', description: 'Link relationship tokens. noopener noreferrer are merged automatically for target="_blank".'},
{name: 'isHighlighted', type: 'boolean', description: 'Highlighted state (hover/keyboard focus appearance).', default: 'false'},
{name: 'isSelected', type: 'boolean', description: 'Selected state.', default: 'false'},
{name: 'isDisabled', type: 'boolean', description: 'Disabled state.', default: 'false'},
@@ -84,7 +85,8 @@ export const docsZh = {
descriptionLines: '描述截断前的最大行数。',
onClick: '点击处理函数。使项目可点击,具有按钮语义。',
href: '链接 URL。通过不可见锚点元素使项目成为链接。',
- target: '链接目标。仅与 href 一起使用。',
+ target: '链接目标。仅与 href 一起使用。target="_blank" 会自动添加 noopener noreferrer。',
+ rel: '链接关系标记。target="_blank" 会自动合并 noopener noreferrer。',
isHighlighted: '高亮状态(悬停/键盘焦点外观)。',
isSelected: '选中状态。',
isDisabled: '禁用状态。',
@@ -148,7 +150,9 @@ export const docsDense = {
descriptionLines: 'Max description lines before truncation.',
onClick: 'Click handler; enables button semantics.',
href: 'Link URL; enables anchor semantics.',
- target: 'Link target, only with href.',
+ target:
+ 'Link target, only with href. target="_blank" auto-adds noopener noreferrer.',
+ rel: 'Link relationship tokens. noopener noreferrer are merged for target="_blank".',
isHighlighted: 'Highlighted state.',
isSelected: 'Selected state.',
isDisabled: 'Disabled state.',
diff --git a/packages/core/src/Item/XDSItem.test.tsx b/packages/core/src/Item/XDSItem.test.tsx
index ea931ecd11..e617d6f29f 100644
--- a/packages/core/src/Item/XDSItem.test.tsx
+++ b/packages/core/src/Item/XDSItem.test.tsx
@@ -181,6 +181,20 @@ describe('XDSItem', () => {
);
const anchor = container.querySelector('a');
expect(anchor).toHaveAttribute('target', '_blank');
+ expect(anchor).toHaveAttribute('rel', 'noopener noreferrer');
+ });
+
+ it('preserves existing rel tokens when target is blank', () => {
+ const {container} = render(
+ <XDSItem
+ label="External"
+ href="https://example.com"
+ target="_blank"
+ rel="sponsored noopener"
+ />,
+ );
+ const anchor = container.querySelector('a');
+ expect(anchor).toHaveAttribute('rel', 'sponsored noopener noreferrer');
});
it('does not render button or anchor for static items', () => {
diff --git a/packages/core/src/Item/XDSItem.tsx b/packages/core/src/Item/XDSItem.tsx
index 526e968bc3..ce3a8b7513 100644
--- a/packages/core/src/Item/XDSItem.tsx
+++ b/packages/core/src/Item/XDSItem.tsx
@@ -28,6 +28,7 @@ import {
} from '../theme/tokens.stylex';
import type {XDSBaseProps} from '../XDSBaseProps';
import {xdsClassName, mergeProps} from '../utils';
+import {computeTargetAndRel} from '../Link/computeTargetAndRel';
import {useXDSLinkComponent} from '../Link/useXDSLinkComponent';
// =============================================================================
@@ -115,6 +116,12 @@ export interface XDSItemProps extends XDSBaseProps<HTMLElement> {
*/
target?: '_blank' | '_self';
+ /**
+ * Link relationship. Automatically includes noopener noreferrer when
+ * target is "_blank".
+ */
+ rel?: string;
+
/**
* Highlighted state (hover/keyboard focus appearance).
* @default false
@@ -314,7 +321,8 @@ export function XDSItem({
descriptionLines,
onClick,
href,
- target,
+ target: targetFromProps,
+ rel: relFromProps,
isHighlighted = false,
isSelected = false,
isDisabled = false,
@@ -327,6 +335,7 @@ export function XDSItem({
}: XDSItemProps) {
const LinkComponent = useXDSLinkComponent();
const isInteractive = onClick != null || href != null;
+ const {target, rel} = computeTargetAndRel(targetFromProps, relFromProps);
// When a semantic role is provided (e.g. "menuitem"), a parent component
// handles keyboard access. Skip the invisible button/anchor and put
// onClick directly on the root element instead.
@@ -381,9 +390,13 @@ export function XDSItem({
);
const handleContainerClick = (e: React.MouseEvent) => {
- if (isDisabled) {return;}
+ if (isDisabled) {
+ return;
+ }
const target = e.target as HTMLElement;
- if (target.closest('button, a, input, select, textarea')) {return;}
+ if (target.closest('button, a, input, select, textarea')) {
+ return;
+ }
onClick?.(e);
};
@@ -404,6 +417,7 @@ export function XDSItem({
<LinkComponent
href={href}
target={target}
+ rel={rel}
aria-disabled={isDisabled || undefined}
tabIndex={isDisabled ? -1 : undefined}
{...stylex.props(
diff --git a/packages/core/src/Kbd/XDSKbd.tsx b/packages/core/src/Kbd/XDSKbd.tsx
index 3a481a4dee..ce335fbe9b 100644
--- a/packages/core/src/Kbd/XDSKbd.tsx
+++ b/packages/core/src/Kbd/XDSKbd.tsx
@@ -163,8 +163,8 @@ export function XDSKbd({
style,
)}
aria-hidden="true">
- {parts.map((key, i) => (
- <kbd key={i} {...stylex.props(styles.kbd)}>
+ {parts.map(key => (
+ <kbd key={key} {...stylex.props(styles.kbd)}>
{getKeyDisplay(key, isMac)}
</kbd>
))}
diff --git a/packages/core/src/Link/Link.doc.mjs b/packages/core/src/Link/Link.doc.mjs
index c48763d01f..5d40ba96e4 100644
--- a/packages/core/src/Link/Link.doc.mjs
+++ b/packages/core/src/Link/Link.doc.mjs
@@ -52,13 +52,21 @@ export const docs = {
{
name: 'isExternalLink',
type: 'boolean',
- description: 'Opens in new tab with external icon',
+ description:
+ 'Opens in new tab with external icon and safe rel tokens',
default: 'false',
},
{
name: 'target',
type: 'string',
- description: 'Where to open linked document',
+ description:
+ 'Where to open linked document. target="_blank" automatically adds noopener noreferrer.',
+ },
+ {
+ name: 'rel',
+ type: 'string',
+ description:
+ 'Link relationship tokens. noopener noreferrer are merged automatically for target="_blank".',
},
{
name: 'onClick',
@@ -167,13 +175,20 @@ export const docsZh = {
{
name: 'isExternalLink',
type: 'boolean',
- description: '在新标签页中打开,带外部图标',
+ description: '在新标签页中打开,带外部图标和安全 rel 标记',
default: 'false',
},
{
name: 'target',
type: 'string',
- description: '链接文档的打开位置',
+ description:
+ '链接文档的打开位置。target="_blank" 会自动添加 noopener noreferrer。',
+ },
+ {
+ name: 'rel',
+ type: 'string',
+ description:
+ '链接关系标记。target="_blank" 会自动合并 noopener noreferrer。',
},
{
name: 'onClick',
@@ -270,8 +285,10 @@ export const docsDense = {
href: 'Link destination URL',
hasUnderline: 'Always show underline',
isDisabled: 'Disables link',
- isExternalLink: 'Opens new tab w/ external icon',
- target: 'Where to open linked document',
+ isExternalLink: 'Opens new tab w/ external icon and safe rel tokens',
+ target:
+ 'Where to open linked document. target="_blank" auto-adds noopener noreferrer.',
+ rel: 'Link relationship tokens. noopener noreferrer are merged for target="_blank".',
onClick: 'Click event handler',
tooltip: 'Tooltip text on hover',
isStandalone: 'Applies base font sizing',
diff --git a/packages/core/src/Link/XDSLink.test.tsx b/packages/core/src/Link/XDSLink.test.tsx
index f4dd9a9dbf..616e5b0df7 100644
--- a/packages/core/src/Link/XDSLink.test.tsx
+++ b/packages/core/src/Link/XDSLink.test.tsx
@@ -130,6 +130,27 @@ describe('XDSLink', () => {
expect(link).toHaveAttribute('target', '_parent');
});
+ it('adds safe rel tokens for explicit target="_blank"', () => {
+ render(
+ <XDSLink href="/test" target="_blank">
+ Blank Link
+ </XDSLink>,
+ );
+ const link = screen.getByRole('link');
+ expect(link).toHaveAttribute('target', '_blank');
+ expect(link).toHaveAttribute('rel', 'noopener noreferrer');
+ });
+
+ it('preserves existing rel tokens for explicit target="_blank"', () => {
+ render(
+ <XDSLink href="/test" target="_blank" rel="sponsored noopener">
+ Blank Link
+ </XDSLink>,
+ );
+ const link = screen.getByRole('link');
+ expect(link).toHaveAttribute('rel', 'sponsored noopener noreferrer');
+ });
+
it('handles click events', async () => {
const user = userEvent.setup();
const handleClick = vi.fn(e => e.preventDefault());
diff --git a/packages/core/src/Link/XDSLink.tsx b/packages/core/src/Link/XDSLink.tsx
index 75a4bf0e4a..35654ca8d0 100644
--- a/packages/core/src/Link/XDSLink.tsx
+++ b/packages/core/src/Link/XDSLink.tsx
@@ -40,6 +40,7 @@ import type {
import {useXDSLinkComponent} from './useXDSLinkComponent';
import type {XDSLinkComponentType} from './types';
import {xdsClassName, mergeProps} from '../utils';
+import {computeTargetAndRel} from './computeTargetAndRel';
/**
* Base link styles
@@ -237,7 +238,7 @@ export function XDSLink({
hasUnderline = false,
isDisabled = false,
isExternalLink = false,
- target,
+ target: targetFromProps,
onClick,
tooltip,
isStandalone = false,
@@ -248,7 +249,7 @@ export function XDSLink({
display = 'inline',
maxLines = 0,
children,
- rel,
+ rel: relFromProps,
xstyle,
className,
style,
@@ -257,19 +258,17 @@ export function XDSLink({
}: XDSLinkProps) {
const LinkComponent = useXDSLinkComponent(as);
// Determine target and rel based on isExternalLink
- const computedTarget = isExternalLink ? '_blank' : target;
- const computedRel = isExternalLink
- ? rel
- ? `${rel} noopener noreferrer`
- : 'noopener noreferrer'
- : rel;
+ const {target, rel} = computeTargetAndRel(
+ isExternalLink ? '_blank' : targetFromProps,
+ relFromProps,
+ );
const linkElement = (
<LinkComponent
ref={ref}
href={href}
- target={computedTarget}
- rel={computedRel}
+ target={target}
+ rel={rel}
onClick={onClick}
aria-label={label || undefined}
aria-disabled={isDisabled || undefined}
diff --git a/packages/core/src/Link/computeTargetAndRel.ts b/packages/core/src/Link/computeTargetAndRel.ts
new file mode 100644
index 0000000000..e4ed548a8f
--- /dev/null
+++ b/packages/core/src/Link/computeTargetAndRel.ts
@@ -0,0 +1,31 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+/**
+ * @file computeTargetAndRel.ts
+ * @input Link target and rel values
+ * @output Exports helper for normalizing target/rel link props
+ * @position Internal utility; consumed by link-rendering components
+ */
+
+const BLANK_TARGET_REL_TOKENS = ['noopener', 'noreferrer'] as const;
+
+export function computeTargetAndRel(
+ target: string | undefined,
+ rel: string | undefined,
+): {rel: string | undefined; target: string | undefined} {
+ if (target !== '_blank') {
+ return {target, rel};
+ }
+
+ const tokens = rel?.split(/\s+/).filter(Boolean) ?? [];
+ for (const token of BLANK_TARGET_REL_TOKENS) {
+ if (!tokens.includes(token)) {
+ tokens.push(token);
+ }
+ }
+
+ return {
+ target,
+ rel: tokens.join(' '),
+ };
+}
diff --git a/packages/core/src/List/List.doc.mjs b/packages/core/src/List/List.doc.mjs
index 2e65e2928d..cce904c3c6 100644
--- a/packages/core/src/List/List.doc.mjs
+++ b/packages/core/src/List/List.doc.mjs
@@ -104,7 +104,13 @@ export const docs = {
name: 'target',
type: 'string',
description:
- 'Link target attribute, only applicable when href is provided.',
+ 'Link target attribute, only applicable when href is provided. target="_blank" automatically adds noopener noreferrer.',
+ },
+ {
+ name: 'rel',
+ type: 'string',
+ description:
+ 'Link relationship tokens. noopener noreferrer are merged automatically for target="_blank".',
},
{
name: 'isDisabled',
@@ -235,7 +241,13 @@ export const docsZh = {
name: 'target',
type: 'string',
description:
- '链接 target 属性,仅在提供 href 时适用。',
+ '链接 target 属性,仅在提供 href 时适用。target="_blank" 会自动添加 noopener noreferrer。',
+ },
+ {
+ name: 'rel',
+ type: 'string',
+ description:
+ '链接关系标记。target="_blank" 会自动合并 noopener noreferrer。',
},
{
name: 'isDisabled',
@@ -318,7 +330,9 @@ export const docsDense = {
endContent: 'Content after label area (e.g. badge, chevron).',
onClick: 'Click handler; enables invisible button pattern.',
href: 'Link URL; enables invisible anchor pattern.',
- target: 'Link target attribute, only when href provided.',
+ target:
+ 'Link target attribute, only when href provided. target="_blank" auto-adds noopener noreferrer.',
+ rel: 'Link relationship tokens. noopener noreferrer are merged for target="_blank".',
isDisabled: 'Disabled state; sets aria-disabled.',
isSelected: 'Selected state; sets aria-selected.',
},
diff --git a/packages/core/src/List/XDSList.test.tsx b/packages/core/src/List/XDSList.test.tsx
index 52b1badb0b..4743e04ba0 100644
--- a/packages/core/src/List/XDSList.test.tsx
+++ b/packages/core/src/List/XDSList.test.tsx
@@ -193,8 +193,8 @@ describe('XDSList', () => {
const header = screen.getByText('Group');
const wrapper = header.parentElement?.parentElement;
const ul = container.querySelector('ul');
- expect(wrapper).toContainElement(header.parentElement!);
- expect(wrapper).toContainElement(ul!);
+ expect(wrapper).toContainElement(header.parentElement);
+ expect(wrapper).toContainElement(ul);
});
it('does not add a wrapper div when header is absent', () => {
@@ -416,6 +416,7 @@ describe('XDSList', () => {
);
const anchor = container.querySelector('a');
expect(anchor).toHaveAttribute('target', '_blank');
+ expect(anchor).toHaveAttribute('rel', 'noopener noreferrer');
});
it('does not render button or anchor for static items', () => {
diff --git a/packages/core/src/List/XDSListItem.tsx b/packages/core/src/List/XDSListItem.tsx
index 9be4f8963c..66b3b6e288 100644
--- a/packages/core/src/List/XDSListItem.tsx
+++ b/packages/core/src/List/XDSListItem.tsx
@@ -85,6 +85,12 @@ export interface XDSListItemProps extends XDSBaseProps<HTMLLIElement> {
*/
target?: string;
+ /**
+ * Link relationship. Automatically includes noopener noreferrer when
+ * target is "_blank".
+ */
+ rel?: string;
+
/**
* Whether the item is disabled.
* @default false
@@ -183,7 +189,7 @@ const embeddedStyles = stylex.create({
* ```
* <XDSListItem label="Settings" description="Manage your preferences" />
* <XDSListItem label="Profile" onClick={() => navigate('/profile')} />
- * <XDSListItem label="Docs" href="/docs" target="_blank" />
+ * <XDSListItem label="Docs" href="/docs" target="_blank" rel="noreferrer" />
* ```
*/
export function XDSListItem({
@@ -194,6 +200,7 @@ export function XDSListItem({
onClick,
href,
target,
+ rel,
isDisabled = false,
isSelected = false,
xstyle,
@@ -235,6 +242,7 @@ export function XDSListItem({
onClick={onClick}
href={href}
target={target as '_blank' | '_self'}
+ rel={rel}
isDisabled={isDisabled}
isSelected={isSelected}
density={itemDensity}
diff --git a/packages/core/src/Markdown/XDSMarkdown.tsx b/packages/core/src/Markdown/XDSMarkdown.tsx
index 973ff0dec5..bfc98dd6fb 100644
--- a/packages/core/src/Markdown/XDSMarkdown.tsx
+++ b/packages/core/src/Markdown/XDSMarkdown.tsx
@@ -125,7 +125,7 @@ export interface XDSMarkdownProps extends XDSBaseProps<HTMLDivElement> {
onLinkClick?: (
href: string,
event: React.MouseEvent<HTMLAnchorElement>,
- ) => void | false;
+ ) => void | false; // eslint-disable-line @typescript-eslint/no-invalid-void-type
/**
* Citation sources keyed by ID. When provided, `[id]` and `【id】` markers
* in the markdown that match a key are rendered as citation chips.
@@ -434,6 +434,9 @@ function countInlineTextLength(nodes: InlineNode[]): number {
case 'code':
len += node.content.length;
break;
+ case 'image':
+ len += node.alt.length;
+ break;
case 'bold':
case 'italic':
case 'strikethrough':
@@ -483,6 +486,11 @@ function countBlockTextLength(nodes: BlockNode[]): number {
}
}
break;
+ case 'hr':
+ break;
+ case 'image':
+ len += node.alt.length;
+ break;
}
}
return len;
@@ -1256,6 +1264,7 @@ function renderBlock(
return (
<XDSCheckboxListItem
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- markdown task items are rendered from positional AST nodes
key={i}
value={`task-${i}`}
label={label}
@@ -1331,7 +1340,13 @@ function renderBlock(
</>
);
- return <XDSListItem key={i} label={label} />;
+ return (
+ <XDSListItem
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- markdown list items are rendered from positional AST nodes
+ key={i}
+ label={label}
+ />
+ );
})}
</XDSList>
</div>
@@ -1350,9 +1365,7 @@ function renderBlock(
? dynamicStyles.blockWidth(contentWidthValue)
: null,
BLOCK_ALIGN_MARGIN[contentAlign] != null
- ? dynamicStyles.blockAlign(
- BLOCK_ALIGN_MARGIN[contentAlign] as string,
- )
+ ? dynamicStyles.blockAlign(BLOCK_ALIGN_MARGIN[contentAlign])
: null,
isFirst && styles.noMarginBlockStart,
isLast && styles.noMarginBlockEnd,
@@ -1362,6 +1375,7 @@ function renderBlock(
<XDSTableRow>
{node.headers.map((h, i) => (
<XDSTableHeaderCell
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- markdown table columns are positional by definition
key={i}
xstyle={[
dynamicStyles.cellMinWidth(`${colMinWidths[i]}px`),
@@ -1388,6 +1402,7 @@ function renderBlock(
{node.rows.map((row, i) => {
const cells = row.map((cell, j) => (
<XDSTableCell
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- markdown table cells are positional by row and column
key={j}
xstyle={[
node.alignments[j] === 'center' && cellAlignStyles.center,
@@ -1407,7 +1422,13 @@ function renderBlock(
)}
</XDSTableCell>
));
- return <XDSTableRow key={i}>{cells}</XDSTableRow>;
+ return (
+ <XDSTableRow
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- markdown table rows are rendered from positional AST nodes
+ key={i}>
+ {cells}
+ </XDSTableRow>
+ );
})}
</XDSTableBody>
</XDSTable>
diff --git a/packages/core/src/Markdown/incremental.test.ts b/packages/core/src/Markdown/incremental.test.ts
index 3ba5d2a694..6ad8a3e444 100644
--- a/packages/core/src/Markdown/incremental.test.ts
+++ b/packages/core/src/Markdown/incremental.test.ts
@@ -391,6 +391,11 @@ describe('streaming end-to-end: no raw syntax visible', () => {
}
}
break;
+ case 'hr':
+ break;
+ case 'image':
+ text += block.alt;
+ break;
}
}
return text;
@@ -415,6 +420,9 @@ describe('streaming end-to-end: no raw syntax visible', () => {
case 'image':
text += node.alt;
break;
+ case 'citation':
+ text += node.sourceId;
+ break;
case 'break':
text += '\n';
break;
diff --git a/packages/core/src/Markdown/parser.ts b/packages/core/src/Markdown/parser.ts
index e6c02958fe..b2819a0d92 100644
--- a/packages/core/src/Markdown/parser.ts
+++ b/packages/core/src/Markdown/parser.ts
@@ -406,7 +406,7 @@ function isBlockStart(line: string): boolean {
function splitTableRow(line: string): string[] {
let start = 0;
let end = line.length;
- if (line[0] === '|') {
+ if (line.startsWith('|')) {
start = 1;
while (start < end && line[start] === ' ') {
start++;
@@ -701,7 +701,7 @@ function findSettledBoundary(lines: string[]): number {
inFence = true;
fenceMarker = fenceMatch[1];
} else if (
- fenceMatch[1][0] === fenceMarker[0] &&
+ fenceMatch[1].startsWith(fenceMarker[0]) &&
fenceMatch[1].length >= fenceMarker.length
) {
inFence = false;
diff --git a/packages/core/src/MultiSelector/XDSMultiSelector.tsx b/packages/core/src/MultiSelector/XDSMultiSelector.tsx
index 265550a407..5605f67c3b 100644
--- a/packages/core/src/MultiSelector/XDSMultiSelector.tsx
+++ b/packages/core/src/MultiSelector/XDSMultiSelector.tsx
@@ -561,7 +561,7 @@ export function XDSMultiSelector<T extends XDSMultiSelectorOptionType>({
className,
style,
}: XDSMultiSelectorProps<T>) {
- const size = useXDSSize(sizeProp, 'md') as XDSMultiSelectorSize;
+ const size = useXDSSize(sizeProp, 'md');
const triggerId = useId();
const listboxId = useId();
const descriptionId = useId();
diff --git a/packages/core/src/NumberInput/XDSNumberInput.tsx b/packages/core/src/NumberInput/XDSNumberInput.tsx
index c6e5bc16e3..b2b5f491d1 100644
--- a/packages/core/src/NumberInput/XDSNumberInput.tsx
+++ b/packages/core/src/NumberInput/XDSNumberInput.tsx
@@ -497,7 +497,7 @@ export function XDSNumberInput({
// Handle clear button click
const handleClear = useCallback(() => {
if (hasClear) {
- (onChange as (value: number | null) => void)(null);
+ onChange(null);
}
setPendingInput(null);
inputRef.current?.focus();
diff --git a/packages/core/src/Pagination/XDSPagination.tsx b/packages/core/src/Pagination/XDSPagination.tsx
index 2ae3e7b24e..98d4617a76 100644
--- a/packages/core/src/Pagination/XDSPagination.tsx
+++ b/packages/core/src/Pagination/XDSPagination.tsx
@@ -428,9 +428,11 @@ export function XDSPagination({
<>
{pageRange.map((item, index) => {
if (item === '...') {
+ const previousPage = pageRange[index - 1];
+ const nextPage = pageRange[index + 1];
return (
<span
- key={`ellipsis-${index}`}
+ key={`ellipsis-${previousPage}-${nextPage}`}
aria-hidden="true"
{...stylex.props(
styles.ellipsis,
diff --git a/packages/core/src/PowerSearch/PowerSearchEditPopover.test.tsx b/packages/core/src/PowerSearch/PowerSearchEditPopover.test.tsx
index 992983315c..d683ca0e0c 100644
--- a/packages/core/src/PowerSearch/PowerSearchEditPopover.test.tsx
+++ b/packages/core/src/PowerSearch/PowerSearchEditPopover.test.tsx
@@ -32,8 +32,7 @@ let rafCallbacks: Array<FrameRequestCallback> = [];
let rafId = 0;
beforeAll(() => {
- globalThis.ResizeObserver =
- MockResizeObserver as unknown as typeof ResizeObserver;
+ globalThis.ResizeObserver = MockResizeObserver;
HTMLElement.prototype.showPopover = vi.fn(function (this: HTMLElement) {
popoverOpenState.set(this, true);
const event = new Event('toggle');
diff --git a/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx b/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx
index 3ac05c6433..c6e8f1f54d 100644
--- a/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx
+++ b/packages/core/src/PowerSearch/PowerSearchValueEditor.test.tsx
@@ -28,8 +28,7 @@ class MockResizeObserver {
}
beforeAll(() => {
- globalThis.ResizeObserver =
- MockResizeObserver as unknown as typeof ResizeObserver;
+ globalThis.ResizeObserver = MockResizeObserver;
HTMLElement.prototype.showPopover = vi.fn(function (this: HTMLElement) {
popoverOpenState.set(this, true);
const event = new Event('toggle');
diff --git a/packages/core/src/PowerSearch/XDSPowerSearch.test.tsx b/packages/core/src/PowerSearch/XDSPowerSearch.test.tsx
index 7bcce4708a..f03c54d72e 100644
--- a/packages/core/src/PowerSearch/XDSPowerSearch.test.tsx
+++ b/packages/core/src/PowerSearch/XDSPowerSearch.test.tsx
@@ -30,8 +30,7 @@ class MockResizeObserver {
}
beforeAll(() => {
- globalThis.ResizeObserver =
- MockResizeObserver as unknown as typeof ResizeObserver;
+ globalThis.ResizeObserver = MockResizeObserver;
HTMLElement.prototype.showPopover = vi.fn(function (this: HTMLElement) {
popoverOpenState.set(this, true);
const event = new Event('toggle');
diff --git a/packages/core/src/PowerSearch/XDSPowerSearch.tsx b/packages/core/src/PowerSearch/XDSPowerSearch.tsx
index 3c4687d7a5..31da0e941a 100644
--- a/packages/core/src/PowerSearch/XDSPowerSearch.tsx
+++ b/packages/core/src/PowerSearch/XDSPowerSearch.tsx
@@ -522,7 +522,7 @@ export function XDSPowerSearch({
style,
components: componentOverrides,
}: XDSPowerSearchProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSPowerSearchSize;
+ const size = useXDSSize(sizeProp, 'md');
const config = useInternalConfig(configProp);
const searchSource = usePowerSearchSource(config);
const tokenizerRef = useRef<XDSTokenizerHandle>(null);
@@ -729,7 +729,7 @@ export function XDSPowerSearch({
// Custom token renderer
const renderToken = useCallback(
(item: PowerSearchItem, onRemove: () => void) => {
- const auxData = item.auxiliaryData as PowerSearchAuxData | undefined;
+ const auxData = item.auxiliaryData;
const filterIndex = auxData?.filterIndex ?? -1;
const filter = filterIndex >= 0 ? filters[filterIndex] : undefined;
@@ -830,7 +830,7 @@ export function XDSPowerSearch({
// Custom typeahead item renderer — adds field icon and description
const renderItem = useCallback(
(item: PowerSearchItem) => {
- const auxData = item.auxiliaryData as PowerSearchAuxData | undefined;
+ const auxData = item.auxiliaryData;
if (!auxData) {
return <XDSTypeaheadItem item={item} />;
}
diff --git a/packages/core/src/PowerSearch/formatFilterValue.ts b/packages/core/src/PowerSearch/formatFilterValue.ts
index 88d101e267..c3a1c75e92 100644
--- a/packages/core/src/PowerSearch/formatFilterValue.ts
+++ b/packages/core/src/PowerSearch/formatFilterValue.ts
@@ -10,12 +10,7 @@
* - /packages/core/src/PowerSearch/index.ts
*/
-import type {
- OperatorValue,
- FilterValue,
- EnumItem,
- CustomOperatorValue,
-} from './types';
+import type {OperatorValue, FilterValue, EnumItem} from './types';
import type {InternalConfig} from './useInternalConfig';
function truncate(str: string, maxLength: number): string {
@@ -163,10 +158,7 @@ export function formatFilterValue(
case 'custom':
if (operatorValue.type === 'custom') {
- return truncate(
- (operatorValue as CustomOperatorValue).getString(filterValue.value),
- maxLength,
- );
+ return truncate(operatorValue.getString(filterValue.value), maxLength);
}
return filterValue.value;
diff --git a/packages/core/src/PowerSearch/usePowerSearchConfig.ts b/packages/core/src/PowerSearch/usePowerSearchConfig.ts
index f33dc96231..3a051b16e0 100644
--- a/packages/core/src/PowerSearch/usePowerSearchConfig.ts
+++ b/packages/core/src/PowerSearch/usePowerSearchConfig.ts
@@ -344,6 +344,20 @@ function toUnixSeconds(value: Date | number): number {
return value;
}
+function isStringArray(value: unknown): value is string[] {
+ return Array.isArray(value) && value.every(item => typeof item === 'string');
+}
+
+function toStringValues(value: unknown): string[] | null {
+ if (typeof value === 'string') {
+ return [value];
+ }
+ if (isStringArray(value)) {
+ return value;
+ }
+ return null;
+}
+
function resolveRangePart(part: DateTimeRangePart): number {
switch (part.type) {
case 'NOW':
@@ -385,7 +399,10 @@ function matchesFilter(
}
case 'string': {
- const s = String(fieldValue ?? '').toLowerCase();
+ if (typeof fieldValue !== 'string') {
+ return false;
+ }
+ const s = fieldValue.toLowerCase();
const target = filterValue.value.toLowerCase();
if (operator in stringOpHandlers) {
return stringOpHandlers[operator as keyof typeof stringOpHandlers](
@@ -398,7 +415,10 @@ function matchesFilter(
case 'integer':
case 'float': {
- const n = Number(fieldValue);
+ if (typeof fieldValue !== 'number') {
+ return false;
+ }
+ const n = fieldValue;
const target = filterValue.value;
if (operator in numberOpHandlers) {
return numberOpHandlers[operator as keyof typeof numberOpHandlers](
@@ -410,7 +430,10 @@ function matchesFilter(
}
case 'date_absolute': {
- const ts = toUnixSeconds(fieldValue as Date | number);
+ if (!(fieldValue instanceof Date) && typeof fieldValue !== 'number') {
+ return false;
+ }
+ const ts = toUnixSeconds(fieldValue);
if (operator === DateOps.BEFORE) {
return ts < filterValue.unixSeconds;
}
@@ -421,7 +444,10 @@ function matchesFilter(
}
case 'date_range': {
- const ts = toUnixSeconds(fieldValue as Date | number);
+ if (!(fieldValue instanceof Date) && typeof fieldValue !== 'number') {
+ return false;
+ }
+ const ts = toUnixSeconds(fieldValue);
if (operator === DateOps.BETWEEN) {
const start = resolveRangePart(filterValue.value.start);
const end = resolveRangePart(filterValue.value.end);
@@ -431,40 +457,51 @@ function matchesFilter(
}
case 'enum': {
+ if (typeof fieldValue !== 'string') {
+ return false;
+ }
if (operator === EnumOps.IS) {
- return String(fieldValue) === filterValue.value;
+ return fieldValue === filterValue.value;
}
if (operator === EnumOps.IS_NOT) {
- return String(fieldValue) !== filterValue.value;
+ return fieldValue !== filterValue.value;
}
return true;
}
case 'enum_list': {
- const sv = String(fieldValue);
+ const values = toStringValues(fieldValue);
+ if (values == null) {
+ return false;
+ }
if (operator === EnumListOps.IS_ANY_OF) {
- return filterValue.value.includes(sv);
+ return values.some(v => filterValue.value.includes(v));
}
if (operator === EnumListOps.IS_NONE_OF) {
- return !filterValue.value.includes(sv);
+ return values.every(v => !filterValue.value.includes(v));
}
return true;
}
case 'string_list': {
- const arr = Array.isArray(fieldValue)
- ? (fieldValue as string[])
- : [String(fieldValue)];
+ const values = toStringValues(fieldValue);
+ if (values == null) {
+ return false;
+ }
if (operator === StringListOps.IS_ANY_OF) {
- return arr.some(v => filterValue.value.includes(v));
+ return values.some(v => filterValue.value.includes(v));
}
if (operator === StringListOps.IS_NONE_OF) {
- return arr.every(v => !filterValue.value.includes(v));
+ return values.every(v => !filterValue.value.includes(v));
}
return true;
}
- default:
+ case 'time':
+ case 'date_relative':
+ case 'entity_list':
+ case 'custom':
+ case 'nested':
return true;
}
}
diff --git a/packages/core/src/SegmentedControl/XDSSegmentedControl.tsx b/packages/core/src/SegmentedControl/XDSSegmentedControl.tsx
index ec1d774cbe..17a75a10db 100644
--- a/packages/core/src/SegmentedControl/XDSSegmentedControl.tsx
+++ b/packages/core/src/SegmentedControl/XDSSegmentedControl.tsx
@@ -131,7 +131,7 @@ export function XDSSegmentedControl({
className,
style,
}: XDSSegmentedControlProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSSegmentedControlSize;
+ const size = useXDSSize(sizeProp, 'md');
const containerRef = useRef<HTMLDivElement>(null);
const handleKeyDown = useCallback(
diff --git a/packages/core/src/SelectableCard/XDSSelectableCard.tsx b/packages/core/src/SelectableCard/XDSSelectableCard.tsx
index 21100ee208..625d7d0255 100644
--- a/packages/core/src/SelectableCard/XDSSelectableCard.tsx
+++ b/packages/core/src/SelectableCard/XDSSelectableCard.tsx
@@ -148,6 +148,10 @@ const styles = stylex.create({
const selectedStyleForVariant = (variant: XDSCardVariant) => {
switch (variant) {
+ case 'default':
+ case 'transparent':
+ case 'muted':
+ return styles.selected;
case 'blue':
return styles.selectedBlue;
case 'cyan':
@@ -168,8 +172,6 @@ const selectedStyleForVariant = (variant: XDSCardVariant) => {
return styles.selectedTeal;
case 'yellow':
return styles.selectedYellow;
- default:
- return styles.selected;
}
};
diff --git a/packages/core/src/Selector/XDSSelector.tsx b/packages/core/src/Selector/XDSSelector.tsx
index ef007476dc..52bc152e76 100644
--- a/packages/core/src/Selector/XDSSelector.tsx
+++ b/packages/core/src/Selector/XDSSelector.tsx
@@ -536,7 +536,7 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
...rest
} = props as XDSSelectorPropsClearable<T>;
const hasClear = hasClearProp === true;
- const size = useXDSSize(sizeProp, 'md') as XDSSelectorSize;
+ const size = useXDSSize(sizeProp, 'md');
// Normalize null to undefined for internal use (null is the clear sentinel)
const normalizedValue = value === null ? undefined : value;
@@ -672,13 +672,11 @@ export function XDSSelector<T extends XDSSelectorOptionType>(
const handleClear = useCallback(
(e: React.MouseEvent) => {
e.stopPropagation(); // Don't open dropdown
- (onChange as ((value: string | null) => void) | undefined)?.(null);
+ onChange?.(null);
if (changeAction) {
startTransition(async () => {
- setOptimisticValue(undefined as unknown as string);
- await (
- changeAction as (value: string | null) => void | Promise<void>
- )(null);
+ setOptimisticValue(undefined);
+ await changeAction(null);
});
}
},
diff --git a/packages/core/src/SideNav/XDSSideNavHeading.tsx b/packages/core/src/SideNav/XDSSideNavHeading.tsx
index b558d11336..771137d937 100644
--- a/packages/core/src/SideNav/XDSSideNavHeading.tsx
+++ b/packages/core/src/SideNav/XDSSideNavHeading.tsx
@@ -367,9 +367,9 @@ export function XDSSideNavHeading({
const setRef = mergeRefs<HTMLDivElement>(
rootRef,
- setTriggerEl as React.Ref<HTMLDivElement>,
+ setTriggerEl,
ref,
- menu ? (popover.triggerRef as React.Ref<HTMLDivElement>) : undefined,
+ menu ? popover.triggerRef : undefined,
);
// In collapsed mode: hide if no icon, show icon-only if has icon
@@ -379,10 +379,7 @@ export function XDSSideNavHeading({
if (isCollapsed && icon) {
const collapsedIcon = <span {...stylex.props(styles.icon)}>{icon}</span>;
- const collapsedSetRef = mergeRefs<HTMLElement>(
- collapsedItemRef,
- ref as React.Ref<HTMLElement>,
- );
+ const collapsedSetRef = mergeRefs<HTMLElement>(collapsedItemRef, ref);
let collapsedElement: ReactNode;
@@ -406,7 +403,7 @@ export function XDSSideNavHeading({
collapsedElement = (
<>
<button
- ref={collapsedSetRef as React.Ref<HTMLButtonElement>}
+ ref={collapsedSetRef}
type="button"
aria-label={heading}
data-testid={testId}
diff --git a/packages/core/src/Slider/XDSSlider.tsx b/packages/core/src/Slider/XDSSlider.tsx
index d73545e8a1..f877c258a9 100644
--- a/packages/core/src/Slider/XDSSlider.tsx
+++ b/packages/core/src/Slider/XDSSlider.tsx
@@ -372,7 +372,7 @@ export function XDSSlider({ref, ...props}: XDSSliderProps) {
// Value helpers
const values: number[] = useMemo(
- () => (isRange ? (value as [number, number]) : [value as number]),
+ () => (isRange ? value : [value]),
[isRange, value],
);
diff --git a/packages/core/src/Stack/XDSStack.tsx b/packages/core/src/Stack/XDSStack.tsx
index e53103410f..9193b475b1 100644
--- a/packages/core/src/Stack/XDSStack.tsx
+++ b/packages/core/src/Stack/XDSStack.tsx
@@ -194,15 +194,9 @@ export function XDSStack({
}: XDSStackProps) {
// Resolve align/justify aliases based on direction
const resolvedHAlign =
- hAlign ??
- (direction === 'horizontal'
- ? (justify as XDSStackAlignment | undefined)
- : (align as XDSStackAlignment | undefined));
+ hAlign ?? (direction === 'horizontal' ? justify : align);
const resolvedVAlign =
- vAlign ??
- (direction === 'horizontal'
- ? (align as XDSStackAlignment | undefined)
- : (justify as XDSStackAlignment | undefined));
+ vAlign ?? (direction === 'horizontal' ? align : justify);
// Map hAlign/vAlign to mainAlign/crossAlign based on direction
const mainAlign =
diff --git a/packages/core/src/TabList/XDSTabList.tsx b/packages/core/src/TabList/XDSTabList.tsx
index 1e6a607ed5..d712bc8c9e 100644
--- a/packages/core/src/TabList/XDSTabList.tsx
+++ b/packages/core/src/TabList/XDSTabList.tsx
@@ -109,7 +109,7 @@ export function XDSTabList({
children,
...restProps
}: XDSTabListProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSTabListSize;
+ const size = useXDSSize(sizeProp, 'md');
const contextValue = useMemo(
() => ({value, onChange, size, layout}),
diff --git a/packages/core/src/TabList/XDSTabMenu.tsx b/packages/core/src/TabList/XDSTabMenu.tsx
index 0706d73cd1..73996cd126 100644
--- a/packages/core/src/TabList/XDSTabMenu.tsx
+++ b/packages/core/src/TabList/XDSTabMenu.tsx
@@ -294,10 +294,7 @@ export function XDSTabMenu({
[tabListCtx, popover],
);
- const setButtonRef = mergeRefs<HTMLButtonElement>(
- popover.triggerRef as React.Ref<HTMLButtonElement>,
- ref,
- );
+ const setButtonRef = mergeRefs<HTMLButtonElement>(popover.triggerRef, ref);
return (
<>
diff --git a/packages/core/src/Table/XDSBaseTable.tsx b/packages/core/src/Table/XDSBaseTable.tsx
index 9276138818..a4c19e61a5 100644
--- a/packages/core/src/Table/XDSBaseTable.tsx
+++ b/packages/core/src/Table/XDSBaseTable.tsx
@@ -379,9 +379,7 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
// With table-layout: fixed, header cell sizing controls column widths.
const widthStyle = resolvedWidths.columns.get(col.key)?.style ?? {};
- const existingStyle = cellRenderProps.htmlProps.style as
- | React.CSSProperties
- | undefined;
+ const existingStyle = cellRenderProps.htmlProps.style;
const mergedHtmlProps = {
...cellRenderProps.htmlProps,
style: existingStyle ? {...widthStyle, ...existingStyle} : widthStyle,
@@ -441,7 +439,7 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
const hasColumns = resolvedColumns.length > 0;
const tableStyle: React.CSSProperties = {
- ...(tableRenderProps.htmlProps.style as React.CSSProperties | undefined),
+ ...tableRenderProps.htmlProps.style,
minWidth:
resolvedWidths.tableMinWidth > 0
? `${resolvedWidths.tableMinWidth}px`
diff --git a/packages/core/src/Table/XDSTableCell.tsx b/packages/core/src/Table/XDSTableCell.tsx
index 595b6eae4e..5ea42b9186 100644
--- a/packages/core/src/Table/XDSTableCell.tsx
+++ b/packages/core/src/Table/XDSTableCell.tsx
@@ -150,7 +150,7 @@ export function XDSTableCell({
xdsClassName('table-cell'),
stylex.props(xstyle),
incomingClassName,
- incomingStyle as React.CSSProperties,
+ incomingStyle,
)}>
{children}
</td>
@@ -173,7 +173,7 @@ export function XDSTableCell({
xdsClassName('table-cell'),
stylex.props(...mergeXStyle(cellStyles, xstyle)),
incomingClassName,
- incomingStyle as React.CSSProperties,
+ incomingStyle,
)}>
{children}
</td>
diff --git a/packages/core/src/Table/XDSTableHeaderCell.tsx b/packages/core/src/Table/XDSTableHeaderCell.tsx
index ace53a0034..c21b22a25b 100644
--- a/packages/core/src/Table/XDSTableHeaderCell.tsx
+++ b/packages/core/src/Table/XDSTableHeaderCell.tsx
@@ -129,7 +129,7 @@ export function XDSTableHeaderCell({
xdsClassName('table-header-cell'),
stylex.props(xstyle),
incomingClassName,
- incomingStyle as React.CSSProperties,
+ incomingStyle,
)}>
{children}
</th>
@@ -160,7 +160,7 @@ export function XDSTableHeaderCell({
xdsClassName('table-header-cell'),
stylex.props(...mergeXStyle(cellStyles, xstyle)),
incomingClassName,
- incomingStyle as React.CSSProperties,
+ incomingStyle,
)}>
{children}
</th>
diff --git a/packages/core/src/Table/columnUtils.ts b/packages/core/src/Table/columnUtils.ts
index 25ca5d2c50..1f61c18745 100644
--- a/packages/core/src/Table/columnUtils.ts
+++ b/packages/core/src/Table/columnUtils.ts
@@ -182,7 +182,18 @@ export function defaultCellRenderer<T extends Record<string, unknown>>(
if (value == null) {
return '';
}
- return String(value);
+ if (value instanceof Date) {
+ return value.toISOString();
+ }
+ if (
+ typeof value === 'string' ||
+ typeof value === 'number' ||
+ typeof value === 'boolean' ||
+ typeof value === 'bigint'
+ ) {
+ return String(value);
+ }
+ return '';
}
/**
diff --git a/packages/core/src/Table/plugins/columnResize/useXDSTableColumnResize.tsx b/packages/core/src/Table/plugins/columnResize/useXDSTableColumnResize.tsx
index 419472d729..dd66036f9f 100644
--- a/packages/core/src/Table/plugins/columnResize/useXDSTableColumnResize.tsx
+++ b/packages/core/src/Table/plugins/columnResize/useXDSTableColumnResize.tsx
@@ -330,7 +330,7 @@ function ResizeHandle({
e.stopPropagation();
const handle = e.currentTarget;
- const th = handle.closest('th') as HTMLTableCellElement | null;
+ const th = handle.closest('th');
if (!th) {
return;
}
@@ -618,7 +618,7 @@ function ResizeHandle({
const handleKeyDown = useCallback(
(e: React.KeyboardEvent<HTMLDivElement>) => {
const handle = e.currentTarget;
- const th = handle.closest('th') as HTMLTableCellElement | null;
+ const th = handle.closest('th');
if (!th) {
return;
}
@@ -820,9 +820,7 @@ export function useXDSTableColumnResize<T extends Record<string, unknown>>(
}
: undefined;
- const existingStyle = props.htmlProps.style as
- | React.CSSProperties
- | undefined;
+ const existingStyle = props.htmlProps.style;
const mergedStyle = widthStyle
? existingStyle
? {...existingStyle, ...widthStyle}
diff --git a/packages/core/src/Table/plugins/filtering/useXDSTableFilterState.tsx b/packages/core/src/Table/plugins/filtering/useXDSTableFilterState.tsx
index 89e058918c..c37facdbcf 100644
--- a/packages/core/src/Table/plugins/filtering/useXDSTableFilterState.tsx
+++ b/packages/core/src/Table/plugins/filtering/useXDSTableFilterState.tsx
@@ -60,13 +60,11 @@ export function useXDSTableFilterState(
const onFilterChange = useCallback(
(key: string, value: XDSTableFilterValue | null) => {
setFilters(prev => {
- const next = {...prev};
if (value == null) {
- delete next[key];
- } else {
- next[key] = value;
+ const {[key]: _removed, ...next} = prev;
+ return next;
}
- return next;
+ return {...prev, [key]: value};
});
},
[],
diff --git a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.test.tsx b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.test.tsx
index b06b40fd20..98ea42655c 100644
--- a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.test.tsx
+++ b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.test.tsx
@@ -130,13 +130,11 @@ function FilterTable({
filters,
onFilterChange: (key: string, value: XDSTableFilterValue | null) => {
setFilters(prev => {
- const next = {...prev};
if (value == null) {
- delete next[key];
- } else {
- next[key] = value;
+ const {[key]: _removed, ...next} = prev;
+ return next;
}
- return next;
+ return {...prev, [key]: value};
});
},
variant,
diff --git a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
index db39373d21..2875ab3f54 100644
--- a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
+++ b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
@@ -215,7 +215,7 @@ function tableValueToFilterValue(
return typeof value === 'string' ? {type: 'enum', value} : undefined;
case 'enum_list':
return Array.isArray(value)
- ? {type: 'enum_list', value: value as string[]}
+ ? {type: 'enum_list', value: value}
: undefined;
case 'date_absolute':
return typeof value === 'string'
@@ -228,16 +228,20 @@ function tableValueToFilterValue(
return typeof value === 'string' ? {type: 'time', value} : undefined;
case 'string_list':
return Array.isArray(value)
- ? {type: 'string_list', value: value as string[]}
+ ? {type: 'string_list', value: value}
: undefined;
case 'entity_list':
return Array.isArray(value)
? {
type: 'entity_list',
- value: (value as string[]).map(id => ({id, label: id})),
+ value: value.map(id => ({id, label: id})),
}
: undefined;
- default:
+ case 'nested':
+ case 'empty':
+ case 'date_relative':
+ case 'date_range':
+ case 'custom':
return undefined;
}
}
@@ -491,7 +495,7 @@ function NumberFilterControl({
label={`Filter ${header}`}
isLabelHidden
value={numValue}
- onChange={handleChange as (value: number) => void}
+ onChange={handleChange}
placeholder={`Filter ${header}`}
min={operatorValue.minValue ?? null}
max={operatorValue.maxValue ?? null}
@@ -557,7 +561,7 @@ function SelectorFilterControl({
isLabelHidden
options={options}
value={strValue}
- onChange={handleChange as (value: string) => void}
+ onChange={handleChange}
placeholder="All"
size={size}
/>
@@ -795,7 +799,11 @@ function FilterControl({
hasClear={hasClear}
/>
);
- default:
+ case 'nested':
+ case 'empty':
+ case 'date_relative':
+ case 'date_range':
+ case 'custom':
return null;
}
}
diff --git a/packages/core/src/Table/plugins/sortable/useXDSTableSortableState.tsx b/packages/core/src/Table/plugins/sortable/useXDSTableSortableState.tsx
index 50ed7db5b3..96a12d5f4f 100644
--- a/packages/core/src/Table/plugins/sortable/useXDSTableSortableState.tsx
+++ b/packages/core/src/Table/plugins/sortable/useXDSTableSortableState.tsx
@@ -35,6 +35,21 @@ import type {
*/
export type XDSTableSortComparator<T> = (a: T, b: T) => number;
+function toSortableString(value: unknown): string {
+ if (value instanceof Date) {
+ return value.toISOString();
+ }
+ if (
+ typeof value === 'string' ||
+ typeof value === 'number' ||
+ typeof value === 'boolean' ||
+ typeof value === 'bigint'
+ ) {
+ return String(value);
+ }
+ return '';
+}
+
// =============================================================================
// Hook Config
// =============================================================================
@@ -170,7 +185,13 @@ function defaultCompare<T extends Record<string, unknown>>(
}
// string comparison with numeric collation
- return String(aVal).localeCompare(String(bVal), undefined, {numeric: true});
+ return toSortableString(aVal).localeCompare(
+ toSortableString(bVal),
+ undefined,
+ {
+ numeric: true,
+ },
+ );
}
// =============================================================================
@@ -233,7 +254,7 @@ export function useXDSTableSortableState<
): UseXDSTableSortableStateResult<T, TSortKey> {
const {
data,
- defaultSort = [] as unknown as XDSTableSortState<TSortKey>,
+ defaultSort = [],
sort: controlledSort,
onSortChange: controlledOnSortChange,
comparators,
diff --git a/packages/core/src/Text/XDSText.tsx b/packages/core/src/Text/XDSText.tsx
index 0435a560ed..dd06ae7019 100644
--- a/packages/core/src/Text/XDSText.tsx
+++ b/packages/core/src/Text/XDSText.tsx
@@ -169,7 +169,7 @@ const defaultColorByType: Record<string, XDSTextColor> = {
*/
function resolveStyleType(type: XDSTextType): XDSBuiltinTextType {
if (type in sizeByTypeStyles) {
- return type as XDSBuiltinTextType;
+ return type;
}
return 'body';
}
diff --git a/packages/core/src/TextArea/XDSTextArea.tsx b/packages/core/src/TextArea/XDSTextArea.tsx
index da5843a239..22c34491c0 100644
--- a/packages/core/src/TextArea/XDSTextArea.tsx
+++ b/packages/core/src/TextArea/XDSTextArea.tsx
@@ -272,7 +272,7 @@ export function XDSTextArea({
onChange,
changeAction,
isLoading = false,
- value = '',
+ value,
placeholder,
rows = 3,
isDisabled = false,
@@ -293,7 +293,7 @@ export function XDSTextArea({
ref,
...rest
}: XDSTextAreaProps) {
- const size = useXDSSize(sizeProp, 'md') as XDSTextAreaSize;
+ const size = useXDSSize(sizeProp, 'md');
const id = useId();
const descriptionID = useId();
const statusMessageID = useId();
@@ -396,7 +396,7 @@ export function XDSTextArea({
ref={mergeRefs(ref, textareaRef)}
id={id}
name={htmlName}
- value={String(optimisticValue)}
+ value={optimisticValue}
onChange={handleChange}
onPaste={onPaste}
onFocus={onFocus}
diff --git a/packages/core/src/TextInput/XDSTextInput.tsx b/packages/core/src/TextInput/XDSTextInput.tsx
index e8a6646de0..77b1f09126 100644
--- a/packages/core/src/TextInput/XDSTextInput.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.tsx
@@ -250,7 +250,7 @@ export function XDSTextInput({
onChange,
changeAction,
isLoading = false,
- value = '',
+ value,
placeholder,
labelTooltip,
hasClear = false,
@@ -352,7 +352,7 @@ export function XDSTextInput({
id={id}
name={htmlName}
type={type}
- value={String(optimisticValue)}
+ value={optimisticValue}
onChange={handleChange}
onKeyDown={
onEnter || onKeyDown
diff --git a/packages/core/src/Thumbnail/XDSThumbnail.tsx b/packages/core/src/Thumbnail/XDSThumbnail.tsx
index 2ca5354194..f17238684c 100644
--- a/packages/core/src/Thumbnail/XDSThumbnail.tsx
+++ b/packages/core/src/Thumbnail/XDSThumbnail.tsx
@@ -171,7 +171,7 @@ const styles = stylex.create({
borderRadius: radiusVars['--radius-element'],
overflow: 'hidden',
},
- // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- CSS custom property requires type widening for StyleX
+
removeButtonOverrides: {
position: 'absolute',
top: spacingVars['--spacing-1'],
@@ -180,7 +180,7 @@ const styles = stylex.create({
'--_button-radius': `calc(${radiusVars['--radius-element']} - ${spacingVars['--spacing-1']})`,
height: 20,
minWidth: 20,
- } as Record<string, string | number>,
+ },
disabled: {
opacity: 0.5,
pointerEvents: 'none' as const,
diff --git a/packages/core/src/Toast/useXDSToast.tsx b/packages/core/src/Toast/useXDSToast.tsx
index b80c74f5ee..ad07a3d0d7 100644
--- a/packages/core/src/Toast/useXDSToast.tsx
+++ b/packages/core/src/Toast/useXDSToast.tsx
@@ -75,7 +75,7 @@ function getFallbackContext(): XDSToastContextValue {
fallbackContext.addToast(entry);
} else {
pending.push(entry);
- ctxReady.then(ctx => {
+ void ctxReady.then(ctx => {
for (const e of pending) {
ctx.addToast(e);
}
diff --git a/packages/core/src/ToggleButton/XDSToggleButton.tsx b/packages/core/src/ToggleButton/XDSToggleButton.tsx
index ae393e716d..3b8781253f 100644
--- a/packages/core/src/ToggleButton/XDSToggleButton.tsx
+++ b/packages/core/src/ToggleButton/XDSToggleButton.tsx
@@ -23,7 +23,6 @@
import React, {useCallback, type ReactNode} from 'react';
import * as stylex from '@stylexjs/stylex';
import {colorVars, fontWeightVars} from '../theme/tokens.stylex';
-import type {StyleXStyles} from '@stylexjs/stylex';
import {xdsClassName} from '../utils';
import {XDSButton, type XDSButtonSize} from '../Button';
import {useXDSToggleButtonGroup} from './XDSToggleButtonGroup';
@@ -244,7 +243,7 @@ export function XDSToggleButton({
const newState = !isPressed;
onPressedChangeProp(newState);
if (pressedChangeAction) {
- pressedChangeAction(newState);
+ void pressedChangeAction(newState);
}
}
}, [
@@ -297,12 +296,7 @@ export function XDSToggleButton({
className={xdsClassName('toggle-button', {
isPressed: isPressed ? 'true' : 'false',
})}
- xstyle={
- [
- isPressed ? pressedStyles.background : undefined,
- xstyle,
- ] as unknown as StyleXStyles
- }
+ xstyle={[isPressed ? pressedStyles.background : undefined, xstyle]}
style={style}
onClick={handleClick}
{...props}>
diff --git a/packages/core/src/ToggleButton/XDSToggleButtonGroup.tsx b/packages/core/src/ToggleButton/XDSToggleButtonGroup.tsx
index ee97560915..eacbae2c82 100644
--- a/packages/core/src/ToggleButton/XDSToggleButtonGroup.tsx
+++ b/packages/core/src/ToggleButton/XDSToggleButtonGroup.tsx
@@ -192,25 +192,25 @@ export function XDSToggleButtonGroup(
const selectedValues = useMemo(() => {
if (isMultiple) {
- return new Set(props.value as string[]);
+ return new Set(props.value);
}
- const singleValue = props.value as string | null;
+ const singleValue = props.value;
return singleValue != null ? new Set([singleValue]) : new Set<string>();
}, [isMultiple, props.value]);
const toggle = useCallback(
(itemValue: string) => {
if (isMultiple) {
- const current = props.value as string[];
- const onChange = props.onChange as (value: string[]) => void;
+ const current = props.value;
+ const onChange = props.onChange;
if (current.includes(itemValue)) {
onChange(current.filter(v => v !== itemValue));
} else {
onChange([...current, itemValue]);
}
} else {
- const current = props.value as string | null;
- const onChange = props.onChange as (value: string | null) => void;
+ const current = props.value;
+ const onChange = props.onChange;
// Allow deselection: clicking active → null
onChange(current === itemValue ? null : itemValue);
}
diff --git a/packages/core/src/Token/XDSToken.tsx b/packages/core/src/Token/XDSToken.tsx
index 8483464e0d..b7ab41995e 100644
--- a/packages/core/src/Token/XDSToken.tsx
+++ b/packages/core/src/Token/XDSToken.tsx
@@ -389,7 +389,7 @@ export function XDSToken({
return (
<span
- ref={ref as React.Ref<HTMLSpanElement>}
+ ref={ref}
onClick={isDisabled ? undefined : handleContainerClick}
{...sharedProps}
{...mergeProps(
@@ -440,7 +440,7 @@ export function XDSToken({
return (
<span
- ref={ref as React.Ref<HTMLSpanElement>}
+ ref={ref}
{...sharedProps}
{...mergeProps(
xdsClassName('token', {color, size}),
diff --git a/packages/core/src/Tokenizer/XDSTokenizer.test.tsx b/packages/core/src/Tokenizer/XDSTokenizer.test.tsx
index aae177201b..68a3705689 100644
--- a/packages/core/src/Tokenizer/XDSTokenizer.test.tsx
+++ b/packages/core/src/Tokenizer/XDSTokenizer.test.tsx
@@ -30,8 +30,7 @@ class MockResizeObserver {
// Mock Popover API for jsdom
beforeAll(() => {
- globalThis.ResizeObserver =
- MockResizeObserver as unknown as typeof ResizeObserver;
+ globalThis.ResizeObserver = MockResizeObserver;
HTMLElement.prototype.showPopover = vi.fn(function (this: HTMLElement) {
popoverOpenState.set(this, true);
const event = new Event('toggle');
diff --git a/packages/core/src/Tokenizer/XDSTokenizer.tsx b/packages/core/src/Tokenizer/XDSTokenizer.tsx
index 30607993cf..093a47115e 100644
--- a/packages/core/src/Tokenizer/XDSTokenizer.tsx
+++ b/packages/core/src/Tokenizer/XDSTokenizer.tsx
@@ -259,9 +259,18 @@ const sizeStyles = stylex.create({
});
const endSectionSizeStyles = stylex.create({
- sm: {top: `calc(${sizeVars['--size-element-sm']} / 2 - 1px)`, transform: 'translateY(-50%)'},
- md: {top: `calc(${sizeVars['--size-element-md']} / 2 - 1px)`, transform: 'translateY(-50%)'},
- lg: {top: `calc(${sizeVars['--size-element-lg']} / 2 - 1px)`, transform: 'translateY(-50%)'},
+ sm: {
+ top: `calc(${sizeVars['--size-element-sm']} / 2 - 1px)`,
+ transform: 'translateY(-50%)',
+ },
+ md: {
+ top: `calc(${sizeVars['--size-element-md']} / 2 - 1px)`,
+ transform: 'translateY(-50%)',
+ },
+ lg: {
+ top: `calc(${sizeVars['--size-element-lg']} / 2 - 1px)`,
+ transform: 'translateY(-50%)',
+ },
});
const truncatedSizeStyles = stylex.create({
@@ -358,7 +367,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
'data-testid': testId,
ref,
}: XDSTokenizerProps<T>) {
- const size = useXDSSize(sizeProp, 'md') as XDSTokenizerSize;
+ const size = useXDSSize(sizeProp, 'md');
const inputId = useId();
const descriptionId = useId();
const statusMessageId = useId();
@@ -420,7 +429,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
const handleFocusCapture = useCallback(
(e: React.FocusEvent) => {
- const comingFromOutside = !isFocusInTokenizer(e.relatedTarget as Node);
+ const comingFromOutside = !isFocusInTokenizer(e.relatedTarget);
setIsFocusedWithin(true);
if (isLayerMode) {
layer.show();
@@ -439,7 +448,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
const handleBlurCapture = useCallback(
(e: React.FocusEvent) => {
- if (!isFocusInTokenizer(e.relatedTarget as Node)) {
+ if (!isFocusInTokenizer(e.relatedTarget)) {
setIsFocusedWithin(false);
onBlur?.(e);
if (isLayerMode) {
@@ -647,9 +656,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
inputWrapperStyles.base,
styles.wrapper,
value.length > 0 && styles.wrapperWithTokens,
- isTruncated
- ? truncatedSizeStyles[size]
- : sizeStyle,
+ isTruncated ? truncatedSizeStyles[size] : sizeStyle,
isTruncated && styles.truncatedWrapper,
isDisabled && inputWrapperStyles.disabled,
status && inputStatusBorderStyles[status.type],
@@ -704,11 +711,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
}
/>
{(endContent || (hasClear && value.length > 0 && !isDisabled)) && (
- <div
- {...stylex.props(
- styles.endSection,
- endSectionSizeStyles[size],
- )}>
+ <div {...stylex.props(styles.endSection, endSectionSizeStyles[size])}>
{endContent}
{hasClear && value.length > 0 && !isDisabled && (
<XDSInputClearButton
diff --git a/packages/core/src/Toolbar/XDSToolbar.tsx b/packages/core/src/Toolbar/XDSToolbar.tsx
index 3a93edbbc9..fbd685c9c3 100644
--- a/packages/core/src/Toolbar/XDSToolbar.tsx
+++ b/packages/core/src/Toolbar/XDSToolbar.tsx
@@ -119,9 +119,9 @@ const defaultBlockPaddingForSize: Record<XDSElementSize, SpacingStep> = {
};
const blockPaddingVarForSize: Record<XDSElementSize, string> = {
- sm: spacingVars['--spacing-2'] as string,
- md: spacingVars['--spacing-2'] as string,
- lg: spacingVars['--spacing-2'] as string,
+ sm: spacingVars['--spacing-2'],
+ md: spacingVars['--spacing-2'],
+ lg: spacingVars['--spacing-2'],
};
/**
diff --git a/packages/core/src/TopNav/XDSTopNavHeading.tsx b/packages/core/src/TopNav/XDSTopNavHeading.tsx
index 6742731ca7..19b2f571ee 100644
--- a/packages/core/src/TopNav/XDSTopNavHeading.tsx
+++ b/packages/core/src/TopNav/XDSTopNavHeading.tsx
@@ -337,9 +337,9 @@ export function XDSTopNavHeading({
const setRef = mergeRefs<HTMLElement>(
rootRef,
- setTriggerEl as React.Ref<HTMLElement>,
+ setTriggerEl,
ref,
- menu ? (popover.triggerRef as React.Ref<HTMLElement>) : undefined,
+ menu ? popover.triggerRef : undefined,
);
const showChevron = !!menu;
diff --git a/packages/core/src/TopNav/XDSTopNavMegaMenu.tsx b/packages/core/src/TopNav/XDSTopNavMegaMenu.tsx
index 583a87cc04..59cbe20515 100644
--- a/packages/core/src/TopNav/XDSTopNavMegaMenu.tsx
+++ b/packages/core/src/TopNav/XDSTopNavMegaMenu.tsx
@@ -366,7 +366,7 @@ function DefaultMegaMenu({
useEffect(() => {
const nav = triggerButtonRef.current?.closest('nav');
if (nav) {
- popover.triggerRef(nav as HTMLElement);
+ popover.triggerRef(nav);
}
return () => {
popover.triggerRef(null);
diff --git a/packages/core/src/TopNav/XDSTopNavMenu.tsx b/packages/core/src/TopNav/XDSTopNavMenu.tsx
index b253e267cb..f121b2dd53 100644
--- a/packages/core/src/TopNav/XDSTopNavMenu.tsx
+++ b/packages/core/src/TopNav/XDSTopNavMenu.tsx
@@ -245,6 +245,10 @@ export interface XDSTopNavMenuItemData {
onClick?: () => void;
}
+function getMenuItemKey(item: XDSTopNavMenuItemData): string {
+ return item.title;
+}
+
export interface XDSTopNavMenuProps extends XDSBaseProps<HTMLButtonElement> {
ref?: React.Ref<HTMLButtonElement>;
/**
@@ -343,8 +347,8 @@ export function XDSTopNavMenu({
const setTriggerRef = mergeRefs<HTMLButtonElement>(
triggerButtonRef,
- popover.triggerRef as React.Ref<HTMLButtonElement>,
- setTriggerEl as React.Ref<HTMLButtonElement>,
+ popover.triggerRef,
+ setTriggerEl,
ref,
);
@@ -379,9 +383,9 @@ export function XDSTopNavMenu({
drawerExpanded && drawerStyles.itemsExpanded,
)}>
<div {...stylex.props(drawerStyles.itemsInner)}>
- {items.map((item, i) => (
+ {items.map(item => (
<LinkComponent
- key={i}
+ key={getMenuItemKey(item)}
href={item.href}
onClick={(_e: React.MouseEvent) => {
item.onClick?.();
@@ -437,11 +441,11 @@ export function XDSTopNavMenu({
aria-label={label}
{...contentProps}
{...stylex.props(styles.menuContainer)}>
- {items.map((item, index) => {
+ {items.map(item => {
const Element = item.href ? 'a' : 'div';
return (
<Element
- key={index}
+ key={getMenuItemKey(item)}
role="menuitem"
tabIndex={popover.isOpen ? 0 : -1}
href={item.href}
diff --git a/packages/core/src/TreeList/XDSTreeListBranches.tsx b/packages/core/src/TreeList/XDSTreeListBranches.tsx
index 0683d99fad..6d1be0a353 100644
--- a/packages/core/src/TreeList/XDSTreeListBranches.tsx
+++ b/packages/core/src/TreeList/XDSTreeListBranches.tsx
@@ -73,26 +73,29 @@ export function XDSTreeListBranches({
}: XDSTreeListBranchesProps) {
return (
<>
- {ancestorsIsLast.map(
- (ancestorIsLast, level) =>
+ {ancestorsIsLast.map((ancestorIsLast, level) => {
+ const branchOffset = `calc(${BRANCH_MARGIN} + ${level} * ${LEVEL_INDENT})`;
+ return (
// Skip the level that the current-item connector occupies
// (nestedLevel - 1), since that position is rendered below
// with the correct terminus/continuation style.
!ancestorIsLast &&
level !== nestedLevel - 1 && (
<div
+ // eslint-disable-next-line @eslint-react/no-array-index-key -- tree branch levels are fixed positional connectors
key={level}
{...mergeProps(stylex.props(styles.container), {
style: {
- left: `calc(${BRANCH_MARGIN} + ${level} * ${LEVEL_INDENT})`,
+ left: branchOffset,
},
})}>
<div
{...stylex.props(styles.verticalLine, styles.verticalFull)}
/>
</div>
- ),
- )}
+ )
+ );
+ })}
{nestedLevel > 0 && (
<div
{...mergeProps(stylex.props(styles.container), {
diff --git a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx b/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
index 228a0e5422..875ace63b7 100644
--- a/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
+++ b/packages/core/src/Typeahead/XDSBaseTypeahead.tsx
@@ -461,9 +461,9 @@ export const XDSBaseTypeahead = function XDSBaseTypeahead<
const triggerSearch = () => {
if (newQuery.length > 0) {
- performSearch(newQuery);
+ void performSearch(newQuery);
} else if (hasEntriesOnFocus) {
- performBootstrap();
+ void performBootstrap();
}
};
@@ -518,7 +518,7 @@ export const XDSBaseTypeahead = function XDSBaseTypeahead<
return;
}
if (hasEntriesOnFocus && results.length === 0 && query.length === 0) {
- performBootstrap();
+ void performBootstrap();
} else if (
results.length > 0 &&
(query.length > 0 || hasEntriesOnFocus) &&
@@ -553,7 +553,7 @@ export const XDSBaseTypeahead = function XDSBaseTypeahead<
popover.show();
setHighlightedIndex(0);
} else if (hasEntriesOnFocus) {
- performBootstrap();
+ void performBootstrap();
}
}
return;
diff --git a/packages/core/src/Typeahead/XDSTypeahead.tsx b/packages/core/src/Typeahead/XDSTypeahead.tsx
index 435f387f20..52486e5b3b 100644
--- a/packages/core/src/Typeahead/XDSTypeahead.tsx
+++ b/packages/core/src/Typeahead/XDSTypeahead.tsx
@@ -212,7 +212,7 @@ export function XDSTypeahead<T extends XDSSearchableItem>({
style,
'data-testid': testId,
}: XDSTypeaheadProps<T>) {
- const size = useXDSSize(sizeProp, 'md') as XDSTypeaheadSize;
+ const size = useXDSSize(sizeProp, 'md');
const inputId = useId();
const descriptionId = useId();
const statusMessageId = useId();
@@ -258,7 +258,7 @@ export function XDSTypeahead<T extends XDSSearchableItem>({
const handleBlur = useCallback(
(e: React.FocusEvent) => {
// Don't restore if focus is moving within the wrapper (e.g. to dropdown)
- if (wrapperRef.current?.contains(e.relatedTarget as Node)) {
+ if (wrapperRef.current?.contains(e.relatedTarget)) {
return;
}
diff --git a/packages/core/src/hooks/useGridFocus.ts b/packages/core/src/hooks/useGridFocus.ts
index b9b63885a1..b31ea53907 100644
--- a/packages/core/src/hooks/useGridFocus.ts
+++ b/packages/core/src/hooks/useGridFocus.ts
@@ -144,9 +144,7 @@ export function useGridFocus<T extends HTMLElement = HTMLElement>(
const getCurrentIndex = useCallback((): number => {
const cells = getCells();
const active = document.activeElement;
- return cells.findIndex(
- cell => cell === active || cell.contains(active as Node),
- );
+ return cells.findIndex(cell => cell === active || cell.contains(active));
}, [getCells]);
/**
diff --git a/packages/core/src/hooks/useImageMode.ts b/packages/core/src/hooks/useImageMode.ts
index 56d40fb405..999e68efbd 100644
--- a/packages/core/src/hooks/useImageMode.ts
+++ b/packages/core/src/hooks/useImageMode.ts
@@ -175,7 +175,7 @@ export function useImageMode(
}
}
- detect();
+ void detect();
return () => {
cancelled = true;
diff --git a/packages/core/src/hooks/useListFocus.ts b/packages/core/src/hooks/useListFocus.ts
index 1fc6796734..6bf26b7b7d 100644
--- a/packages/core/src/hooks/useListFocus.ts
+++ b/packages/core/src/hooks/useListFocus.ts
@@ -124,9 +124,7 @@ export function useListFocus<T extends HTMLElement = HTMLElement>(
const getCurrentIndex = useCallback((): number => {
const items = getItems();
const active = document.activeElement;
- return items.findIndex(
- item => item === active || item.contains(active as Node),
- );
+ return items.findIndex(item => item === active || item.contains(active));
}, [getItems]);
/**
diff --git a/packages/core/src/hooks/useOverflow.test.ts b/packages/core/src/hooks/useOverflow.test.ts
index 75e537b358..afcc6cd81c 100644
--- a/packages/core/src/hooks/useOverflow.test.ts
+++ b/packages/core/src/hooks/useOverflow.test.ts
@@ -31,7 +31,7 @@ class FakeResizeObserver {
this.callback = cb;
}
observe = vi.fn(() => {
- this.callback([], this as unknown as ResizeObserver);
+ this.callback([], this);
});
unobserve = vi.fn();
disconnect = vi.fn();
diff --git a/packages/core/src/hooks/useXDSStreamingText.test.ts b/packages/core/src/hooks/useXDSStreamingText.test.ts
index b7731ea84f..80080533a1 100644
--- a/packages/core/src/hooks/useXDSStreamingText.test.ts
+++ b/packages/core/src/hooks/useXDSStreamingText.test.ts
@@ -16,7 +16,7 @@ describe('useXDSStreamingText', () => {
globalThis.requestAnimationFrame = vi.fn(cb => {
rafCallbacks.push(cb);
return rafCallbacks.length;
- }) as unknown as typeof requestAnimationFrame;
+ });
globalThis.cancelAnimationFrame = vi.fn();
// Mock matchMedia for useXDSTheme → useMediaQuery
diff --git a/packages/core/src/theme/defineTheme.ts b/packages/core/src/theme/defineTheme.ts
index 79d4345f48..661e6a0938 100644
--- a/packages/core/src/theme/defineTheme.ts
+++ b/packages/core/src/theme/defineTheme.ts
@@ -852,7 +852,7 @@ export function generateThemeRules(theme: XDSDefinedTheme): string[] {
for (const [prop, value] of entries) {
if (prop.startsWith(':') && typeof value === 'object') {
- pseudos.push([prop, value as Record<string, string>]);
+ pseudos.push([prop, value]);
} else {
props.push([prop, value as string]);
}
@@ -1137,7 +1137,7 @@ export function generateOnMediaCSS(theme: XDSDefinedTheme): string {
for (const [prop, value] of entries) {
if (prop.startsWith(':') && typeof value === 'object') {
- pseudos.push([prop, value as Record<string, string>]);
+ pseudos.push([prop, value]);
} else {
props.push([prop, value as string]);
}
diff --git a/packages/core/src/utils/mergeProps.ts b/packages/core/src/utils/mergeProps.ts
index 6160c82135..f8ffea80b5 100644
--- a/packages/core/src/utils/mergeProps.ts
+++ b/packages/core/src/utils/mergeProps.ts
@@ -32,10 +32,7 @@ type StyleObject = React.CSSProperties;
export function mergeProps(
xdsClassOrStylexResult: string | {className?: string; style?: StyleObject},
- stylexResultOrClassName?:
- | {className?: string; style?: StyleObject}
- | string
- | undefined,
+ stylexResultOrClassName?: {className?: string; style?: StyleObject} | string,
classNameOrStyle?: string | React.CSSProperties,
style?: React.CSSProperties,
): {className: string; style?: StyleObject} {
diff --git a/packages/core/src/utils/plainDate.test.ts b/packages/core/src/utils/plainDate.test.ts
index 3b04590f4f..12abfd9838 100644
--- a/packages/core/src/utils/plainDate.test.ts
+++ b/packages/core/src/utils/plainDate.test.ts
@@ -84,7 +84,7 @@ describe('plainDateCreate', () => {
describe('plainDateFromISO', () => {
it('parses a standard ISO date', () => {
- expect(plainDateFromISO('2026-01-25' as ISODateString)).toEqual({
+ expect(plainDateFromISO('2026-01-25')).toEqual({
year: 2026,
month: 1,
day: 25,
@@ -92,12 +92,12 @@ describe('plainDateFromISO', () => {
});
it('parses date with 1-based month', () => {
- const dec = plainDateFromISO('2026-12-31' as ISODateString);
+ const dec = plainDateFromISO('2026-12-31');
expect(dec.month).toBe(12);
});
it('handles single-digit month/day when padded', () => {
- expect(plainDateFromISO('2026-03-05' as ISODateString)).toEqual({
+ expect(plainDateFromISO('2026-03-05')).toEqual({
year: 2026,
month: 3,
day: 5,
diff --git a/packages/core/src/utils/sharedResizeObserver.test.ts b/packages/core/src/utils/sharedResizeObserver.test.ts
index a4b5d4ca01..a979c3d395 100644
--- a/packages/core/src/utils/sharedResizeObserver.test.ts
+++ b/packages/core/src/utils/sharedResizeObserver.test.ts
@@ -23,7 +23,7 @@ describe('sharedResizeObserver', () => {
unobserve: mockUnobserve,
disconnect: mockDisconnect,
};
- }) as unknown as typeof ResizeObserver;
+ });
});
afterEach(() => {
diff --git a/packages/lab/src/Chart/formatters.ts b/packages/lab/src/Chart/formatters.ts
index e2b97e58bd..0d3820b7cc 100644
--- a/packages/lab/src/Chart/formatters.ts
+++ b/packages/lab/src/Chart/formatters.ts
@@ -1,3 +1,5 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
/**
* @file formatters.ts
* @output Built-in tick format utilities for common data types
@@ -7,8 +9,6 @@
/**
* Compact number formatter (e.g. 1200 → "1.2K", 1500000 → "1.5M")
*/
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
export function compactNumber(value: unknown): string {
const n = Number(value);
if (isNaN(n)) {
diff --git a/packages/themes/brutalist/tsup.config.ts b/packages/themes/brutalist/tsup.config.ts
index 13452cb00d..5b17850619 100644
--- a/packages/themes/brutalist/tsup.config.ts
+++ b/packages/themes/brutalist/tsup.config.ts
@@ -1,7 +1,5 @@
// Copyright (c) Meta Platforms, Inc. and affiliates.
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
import {defineConfig} from 'tsup';
export default defineConfig({
diff --git a/packages/themes/default/src/defaultTheme.ts b/packages/themes/default/src/defaultTheme.ts
index f6b7804582..206724f958 100644
--- a/packages/themes/default/src/defaultTheme.ts
+++ b/packages/themes/default/src/defaultTheme.ts
@@ -1,7 +1,5 @@
// Copyright (c) Meta Platforms, Inc. and affiliates.
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
/**
* XDS Default Theme
*
diff --git a/packages/themes/default/src/icons.tsx b/packages/themes/default/src/icons.tsx
index ee98430c4c..a367dafc45 100644
--- a/packages/themes/default/src/icons.tsx
+++ b/packages/themes/default/src/icons.tsx
@@ -1,7 +1,5 @@
// Copyright (c) Meta Platforms, Inc. and affiliates.
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
/**
* @file icons.tsx
* @input Uses @heroicons/react outline and solid icon components, XDSIconRegistry type
diff --git a/packages/themes/default/src/source.ts b/packages/themes/default/src/source.ts
index 556cf02f9f..64bc4849c7 100644
--- a/packages/themes/default/src/source.ts
+++ b/packages/themes/default/src/source.ts
@@ -1,6 +1,4 @@
// Copyright (c) Meta Platforms, Inc. and affiliates.
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
export {defaultTheme} from './defaultTheme';
export {defaultIconRegistry} from './icons';