An open source design system that's fully customizable and agent ready
TypeScript
Honor the last suffix on template demo assets (#6039)
Hashim Khanad0006deb351
diff --git a/.changeset/template-asset-unrecognized-format.md b/.changeset/template-asset-unrecognized-format.mdnew file mode 100644index 0000000000..64ae512f2a--- /dev/null+++ b/.changeset/template-asset-unrecognized-format.md@@ -0,0 +1,6 @@+---+'@astryxdesign/cli': patch+---++[fix] Report the fixture path when a template demo asset has an unsupported format (#6039)+@Hashim1999164diff --git a/packages/cli/foundation/discovery/template-adapter.mjs b/packages/cli/foundation/discovery/template-adapter.mjsindex 371954ee09..f7f8c7bcff 100644--- a/packages/cli/foundation/discovery/template-adapter.mjs+++ b/packages/cli/foundation/discovery/template-adapter.mjs@@ -170,7 +170,18 @@ const PLACEHOLDER_IMAGE =** @type {Set<string>}*/-const VIDEO_EXTENSIONS = new Set(['mp4', 'webm', 'mov', 'ogv']);+const VIDEO_EXTENSIONS = new Set(['mp4', 'webm', 'mov', 'ogv', 'm4v']);++const IMAGE_EXTENSIONS = new Set([+ 'svg',+ 'png',+ 'jpg',+ 'jpeg',+ 'gif',+ 'webp',+ 'avif',+ 'ico',+]);/*** Demo-asset sources to strip from scaffolded projects. Template demo imagery@@ -183,7 +194,7 @@ const VIDEO_EXTENSIONS = new Set(['mp4', 'webm', 'mov', 'ogv']);** @type {RegExp}*/-const DEMO_ASSET_PATTERN = /\/template-assets\/[\w-]+\.(\w+)/g;+const DEMO_ASSET_PATTERN = /\/template-assets\/[\w.-]+\.(\w+)/g;/*** Normalize path into Unix path (using forward slashes) for consistent comparison@@ -207,9 +218,16 @@ function toPosixPath(p) {* @returns {string} Source with demo asset references replaced.*/export function stripTemplateAssetRefs(source) {- return source.replace(DEMO_ASSET_PATTERN, (match, extension) =>- VIDEO_EXTENSIONS.has(extension.toLowerCase()) ? '' : PLACEHOLDER_IMAGE,- );+ return source.replace(DEMO_ASSET_PATTERN, (match, extension) => {+ const ext = extension.toLowerCase();+ if (VIDEO_EXTENSIONS.has(ext)) {+ return '';+ }+ if (IMAGE_EXTENSIONS.has(ext)) {+ return PLACEHOLDER_IMAGE;+ }+ throw new Error(`Unrecognized template asset format ${ext} for ${match}`);+ });}/*** Load a template-spec module and return its metadata object. Supports bothdiff --git a/packages/cli/foundation/discovery/template-adapter.test.mjs b/packages/cli/foundation/discovery/template-adapter.test.mjsindex ecff0ba91a..592ffe2870 100644--- a/packages/cli/foundation/discovery/template-adapter.test.mjs+++ b/packages/cli/foundation/discovery/template-adapter.test.mjs@@ -16,7 +16,10 @@ import {describe, it, expect, beforeAll, afterAll} from 'vitest';import * as fs from 'node:fs';import * as os from 'node:os';import * as path from 'node:path';-import {extractComponents} from './template-adapter.mjs';+import {+ extractComponents,+ stripTemplateAssetRefs,+} from './template-adapter.mjs';/** @type {string} */let dir;@@ -134,3 +137,30 @@ describe('extractComponents — TypeScript generics are not components', () => {expect(extractComponents(file)).toEqual(['Card']);});});++describe('stripTemplateAssetRefs', () => {+ it('uses the last extension on dotted demo asset names', () => {+ const src = 'src="/template-assets/clip.min.mp4"';+ expect(stripTemplateAssetRefs(src)).toBe('src=""');+ });++ it('strips m4v demo assets as video', () => {+ const src = 'src="/template-assets/demo.m4v"';+ expect(stripTemplateAssetRefs(src)).toBe('src=""');+ });++ it('keeps the image placeholder for known image extensions', () => {+ const src = 'src="/template-assets/hero.png"';+ const out = stripTemplateAssetRefs(src);+ expect(out).toContain('data:image/svg+xml');+ expect(out).not.toContain('/template-assets/hero.png');+ });++ it('throws for an unrecognized demo asset extension', () => {+ expect(() =>+ stripTemplateAssetRefs('src="/template-assets/clip.bin"'),+ ).toThrow(+ /Unrecognized template asset format bin for \/template-assets\/clip\.bin/,+ );+ });+});