Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

docs(useInteractiveRole): correct isDisabled behavior for a disabled href (#3786)

Shahrier Islam Arhamadf98f8fab28
diff --git a/.changeset/interactive-role-disabled-href-doc.md b/.changeset/interactive-role-disabled-href-doc.md
new file mode 100644
index 0000000000..679736165f
--- /dev/null
+++ b/.changeset/interactive-role-disabled-href-doc.md
@@ -0,0 +1,8 @@
+---
+'@astryxdesign/core': patch
+---
+
+[docs] Correct useInteractiveRole isDisabled docs for disabled href (#3786)
+
+The `isDisabled` JSDoc claimed a disabled `href` "falls back to button". It does not: a disabled `href` is skipped at the link step and resolved by the remaining priority checks, so with no `onClick` and no interactive context it lands on `'inert'` — as `Token` already relies on for disabled links. The `isDisabled` doc, the step-1 inline comment, and the priority summary now describe the actual behavior. Docs only; no runtime change.
+@arham766
diff --git a/packages/core/src/hooks/useInteractiveRole.ts b/packages/core/src/hooks/useInteractiveRole.ts
index d8a0a51315..be9b1b60ae 100644
--- a/packages/core/src/hooks/useInteractiveRole.ts
+++ b/packages/core/src/hooks/useInteractiveRole.ts
@@ -11,11 +11,14 @@
* Centralizes the "what element should I render as?" decision for
* polymorphic components. The priority order:
*
- * 1. href → 'link' (navigation always wins)
+ * 1. href → 'link' (navigation always wins, unless disabled)
* 2. onClick → 'button' (explicit interactivity)
* 3. interactive trigger context → 'button' (implicit via parent)
* 4. else → 'inert' (non-interactive)
*
+ * A disabled `href` is excluded at step 1 and therefore resolves via the
+ * remaining steps — 'inert' when no onClick or context applies.
+ *
* This hook is the single place to add new context-based triggers
* (e.g., Popover, DropdownMenu, Disclosure). Components that consume
* this hook never need updating when new trigger contexts are added.
@@ -49,8 +52,12 @@ export interface UseInteractiveRoleOptions {
onClick?: ((...args: never[]) => unknown) | null;
/**
- * Whether the component is disabled. When true and href is provided,
- * falls back to button (disabled links are an a11y anti-pattern).
+ * Whether the component is disabled. When true, an `href` is ignored for
+ * role resolution (a disabled link is an a11y anti-pattern), so the role is
+ * decided by the remaining inputs: `onClick` → `'button'`, an interactive
+ * context → its role, otherwise `'inert'`. In particular a disabled `href`
+ * with no `onClick` and no context override resolves to `'inert'`, not a
+ * link or a button.
* @default false
*/
isDisabled?: boolean;
@@ -83,7 +90,8 @@ export function useInteractiveRole({
}: UseInteractiveRoleOptions): InteractiveRole {
const contextRole = useInteractiveRoleContext();
- // 1. href → link (unless disabled — disabled links fall through to button)
+ // 1. href → link (unless disabled — a disabled href is skipped here and
+ // resolved by the checks below, landing on 'inert' if nothing else applies)
if (href != null && !isDisabled) {
return 'link';
}