Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(cli): inline demo-image URLs so base-URL const templates scaffold a clean placeholder (#4028)

Xinzi Zhouaeb5ee6de61d
diff --git a/.changeset/template-cdn-const-src.md b/.changeset/template-cdn-const-src.md
new file mode 100644
index 0000000000..73b9c27b69
--- /dev/null
+++ b/.changeset/template-cdn-const-src.md
@@ -0,0 +1,7 @@
+---
+'@astryxdesign/cli': patch
+---
+
+[fix] template: inline full demo-image URLs in the Avatar blocks and theme-showcase page so scaffolding strips them to a clean placeholder. Templates that stored only the CDN base in a `const` and appended the filename via interpolation (`` `${CDN}/File.png` ``) previously scaffolded a malformed `src` — the placeholder data URI with the filename glued onto the end — plus a dead `const CDN = 'data:…'`. (#4027)
+
+@imdreamrunner
diff --git a/packages/cli/templates/blocks/components/Avatar/AvatarGroup.tsx b/packages/cli/templates/blocks/components/Avatar/AvatarGroup.tsx
index d38ddf8e35..94d8c46c85 100644
--- a/packages/cli/templates/blocks/components/Avatar/AvatarGroup.tsx
+++ b/packages/cli/templates/blocks/components/Avatar/AvatarGroup.tsx
@@ -7,28 +7,26 @@ import {AvatarGroup, AvatarGroupOverflow} from '@astryxdesign/core/AvatarGroup';
import {Stack} from '@astryxdesign/core/Layout';
import {Text} from '@astryxdesign/core/Text';
-const CDN = 'https://lookaside.facebook.com/assets/astryx';
-
const USERS = [
{
name: 'Ami Pena',
- src: `${CDN}/DATA-Ami-Pena.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Ami-Pena.png',
},
{
name: 'Drew Young',
- src: `${CDN}/DATA-Drew-Young.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Drew-Young.png',
},
{
name: 'Gabriela Fernandez',
- src: `${CDN}/DATA-Gabriela-Fernandez.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Gabriela-Fernandez.png',
},
{
name: 'Jihoo Song',
- src: `${CDN}/DATA-Jihoo-Song.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Jihoo-Song.png',
},
{
name: 'Nam Tran',
- src: `${CDN}/DATA-Nam-Tran.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Nam-Tran.png',
},
];
diff --git a/packages/cli/templates/blocks/components/Avatar/AvatarShowcase.tsx b/packages/cli/templates/blocks/components/Avatar/AvatarShowcase.tsx
index 1c9876ca9c..bbf8ad381e 100644
--- a/packages/cli/templates/blocks/components/Avatar/AvatarShowcase.tsx
+++ b/packages/cli/templates/blocks/components/Avatar/AvatarShowcase.tsx
@@ -5,29 +5,27 @@
import {Avatar, AvatarStatusDot} from '@astryxdesign/core/Avatar';
import {Stack} from '@astryxdesign/core/Layout';
-const CDN = 'https://lookaside.facebook.com/assets/astryx';
-
export default function AvatarShowcase() {
return (
<Stack direction="horizontal" gap={4} vAlign="center">
<Avatar
- src={`${CDN}/DATA-Ana-Thomas.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Ana-Thomas.png"
name="Ana Thomas"
size="large"
status={<AvatarStatusDot variant="success" label="Online" />}
/>
<Avatar
- src={`${CDN}/DATA-Drew-Young.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Drew-Young.png"
name="Drew Young"
size="large"
/>
<Avatar
- src={`${CDN}/DATA-Jihoo-Song.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Jihoo-Song.png"
name="Jihoo Song"
size="large"
/>
<Avatar
- src={`${CDN}/DATA-Nam-Tran.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Nam-Tran.png"
name="Nam Tran"
size="large"
status={<AvatarStatusDot variant="error" label="Online" />}
diff --git a/packages/cli/templates/blocks/components/Avatar/AvatarUserCard.tsx b/packages/cli/templates/blocks/components/Avatar/AvatarUserCard.tsx
index ec34da6329..41b00bff19 100644
--- a/packages/cli/templates/blocks/components/Avatar/AvatarUserCard.tsx
+++ b/packages/cli/templates/blocks/components/Avatar/AvatarUserCard.tsx
@@ -6,24 +6,22 @@ import {Avatar, AvatarStatusDot} from '@astryxdesign/core/Avatar';
import {Stack} from '@astryxdesign/core/Layout';
import {Text} from '@astryxdesign/core/Text';
-const CDN = 'https://lookaside.facebook.com/assets/astryx';
-
const USERS = [
{
name: 'Itai Jordaan',
- src: `${CDN}/DATA-Itai-Jordaan.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Itai-Jordaan.png',
role: 'Engineering Lead',
variant: 'success' as const,
},
{
name: 'Margot Schroder',
- src: `${CDN}/DATA-Margot-Schroder.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Margot-Schroder.png',
role: 'Product Designer',
variant: 'neutral' as const,
},
{
name: 'Daniela Gimenez',
- src: `${CDN}/DATA-Daniela-Gimenez.png`,
+ src: 'https://lookaside.facebook.com/assets/astryx/DATA-Daniela-Gimenez.png',
role: 'Engineering Manager',
variant: 'error' as const,
},
diff --git a/packages/cli/templates/blocks/components/Avatar/AvatarWithImage.tsx b/packages/cli/templates/blocks/components/Avatar/AvatarWithImage.tsx
index 5f3436ecef..bf87636693 100644
--- a/packages/cli/templates/blocks/components/Avatar/AvatarWithImage.tsx
+++ b/packages/cli/templates/blocks/components/Avatar/AvatarWithImage.tsx
@@ -5,24 +5,26 @@
import {Avatar} from '@astryxdesign/core/Avatar';
import {Stack} from '@astryxdesign/core/Layout';
-const CDN = 'https://lookaside.facebook.com/assets/astryx';
-
export default function AvatarWithImage() {
return (
<Stack direction="horizontal" gap={4} vAlign="center">
- <Avatar src={`${CDN}/DATA-Ami-Pena.png`} name="Ami Pena" size="tiny" />
<Avatar
- src={`${CDN}/DATA-Ana-Thomas.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Ami-Pena.png"
+ name="Ami Pena"
+ size="tiny"
+ />
+ <Avatar
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Ana-Thomas.png"
name="Ana Thomas"
size="small"
/>
<Avatar
- src={`${CDN}/DATA-Daniela-Gimenez.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Daniela-Gimenez.png"
name="Daniela Gimenez"
size="medium"
/>
<Avatar
- src={`${CDN}/DATA-Gabriela-Fernandez.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Gabriela-Fernandez.png"
name="Gabriela Fernandez"
size="large"
/>
diff --git a/packages/cli/templates/blocks/components/Avatar/AvatarWithStatus.tsx b/packages/cli/templates/blocks/components/Avatar/AvatarWithStatus.tsx
index 5f9b518692..9f99736e33 100644
--- a/packages/cli/templates/blocks/components/Avatar/AvatarWithStatus.tsx
+++ b/packages/cli/templates/blocks/components/Avatar/AvatarWithStatus.tsx
@@ -5,25 +5,23 @@
import {Avatar, AvatarStatusDot} from '@astryxdesign/core/Avatar';
import {Stack} from '@astryxdesign/core/Layout';
-const CDN = 'https://lookaside.facebook.com/assets/astryx';
-
export default function AvatarWithStatus() {
return (
<Stack direction="horizontal" gap={4} vAlign="center">
<Avatar
- src={`${CDN}/DATA-Itai-Jordaan.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Itai-Jordaan.png"
name="Itai Jordaan"
size="large"
status={<AvatarStatusDot variant="success" label="Online" />}
/>
<Avatar
- src={`${CDN}/DATA-Margot-Schroder.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Margot-Schroder.png"
name="Margot Schroder"
size="large"
status={<AvatarStatusDot variant="neutral" label="Offline" />}
/>
<Avatar
- src={`${CDN}/DATA-Pablo-Morales.png`}
+ src="https://lookaside.facebook.com/assets/astryx/DATA-Pablo-Morales.png"
name="Pablo Morales"
size="large"
status={<AvatarStatusDot variant="error" label="Busy" />}
diff --git a/packages/cli/templates/pages/theme-showcase/page.tsx b/packages/cli/templates/pages/theme-showcase/page.tsx
index 8a27a6d9e5..047d3db6a1 100644
--- a/packages/cli/templates/pages/theme-showcase/page.tsx
+++ b/packages/cli/templates/pages/theme-showcase/page.tsx
@@ -282,14 +282,14 @@ const DEFAULT_PRODUCTS: ProductSpec[] = [
// Neutral product photos, served from the shared astryx asset CDN so the
// scaffolded template renders real imagery without needing local public assets.
-const NEUTRAL_CDN = 'https://lookaside.facebook.com/assets/astryx';
const DEFAULT_IMAGES: Record<string, string> = {
- watch: `${NEUTRAL_CDN}/Neutral-Watch.png`,
- headphones: `${NEUTRAL_CDN}/Neutral-Headphones.png`,
- backpack: `${NEUTRAL_CDN}/Neutral-Backpack.png`,
- wallet: `${NEUTRAL_CDN}/Neutral-Wallet.png`,
- tumbler: `${NEUTRAL_CDN}/Neutral-Tumbler.png`,
- throw_: `${NEUTRAL_CDN}/Neutral-Blanket.png`,
+ watch: 'https://lookaside.facebook.com/assets/astryx/Neutral-Watch.png',
+ headphones:
+ 'https://lookaside.facebook.com/assets/astryx/Neutral-Headphones.png',
+ backpack: 'https://lookaside.facebook.com/assets/astryx/Neutral-Backpack.png',
+ wallet: 'https://lookaside.facebook.com/assets/astryx/Neutral-Wallet.png',
+ tumbler: 'https://lookaside.facebook.com/assets/astryx/Neutral-Tumbler.png',
+ throw_: 'https://lookaside.facebook.com/assets/astryx/Neutral-Blanket.png',
};
export interface ThemeShowcaseProps {