An open source design system that's fully customizable and agent ready
TypeScript
fix(sidenav): aria-current on the link, not the wrapper, for split-action items (navigation-8) (#3378)
Cindy Zhangb076295c7600
diff --git a/.changeset/sidenav-aria-current.md b/.changeset/sidenav-aria-current.mdnew file mode 100644index 0000000000..15f8f90557--- /dev/null+++ b/.changeset/sidenav-aria-current.md@@ -0,0 +1,6 @@+---+'@astryxdesign/core': patch+---++[fix] SideNavItem: for split-action items (a collapsible item with its own link/action), `aria-current="page"` now sits on the focusable link instead of the non-interactive wrapper `<div>`, so screen readers announce the current page on the actual navigation element (#3343).+@cixzhangdiff --git a/packages/core/src/SideNav/SideNav.test.tsx b/packages/core/src/SideNav/SideNav.test.tsxindex b7206dbe25..259b58cab7 100644--- a/packages/core/src/SideNav/SideNav.test.tsx+++ b/packages/core/src/SideNav/SideNav.test.tsx@@ -577,6 +577,22 @@ describe('SideNavItem', () => {expect(link).toHaveAttribute('aria-current', 'page');});+ it('places aria-current on the link, not the wrapper, for split-action items', () => {+ // A collapsible item (has children) WITH a primary href renders the+ // split-action path: the link and the expand toggle are siblings inside a+ // wrapper div. aria-current="page" must sit on the focusable link so it is+ // announced as the current page (navigation-8).+ render(+ <SideNavItem label="Reports" href="/reports" isSelected>+ <SideNavItem label="Weekly" href="/reports/weekly" />+ </SideNavItem>,+ );+ const link = screen.getByRole('link', {name: /Reports/});+ expect(link).toHaveAttribute('aria-current', 'page');+ // The wrapper div must NOT carry aria-current.+ expect(link.closest('[aria-current="page"]')).toBe(link);+ });+it('renders custom component when as and href are provided', () => {render(<SideNavItem label="Dashboard" href="/dashboard" as={CustomLink} />);const link = screen.getByRole('link');diff --git a/packages/core/src/SideNav/SideNavItem.tsx b/packages/core/src/SideNav/SideNavItem.tsxindex 779e470a59..329a09f3aa 100644--- a/packages/core/src/SideNav/SideNavItem.tsx+++ b/packages/core/src/SideNav/SideNavItem.tsx@@ -612,16 +612,14 @@ export function SideNavItem({if (hasIndependentToggle) {itemElement = (- <div- aria-current={isSelected ? ('page' as const) : undefined}- data-testid={testId}- {...navItemStyleProps}>+ <div data-testid={testId} {...navItemStyleProps}><NavItemElementref={ref}href={href}as={as}isDisabled={isDisabled}onClick={handleClick}+ aria-current={isSelected ? ('page' as const) : undefined}{...stylex.props(styles.splitAction)}>{itemContent}</NavItemElement>