Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): add @media (hover: hover) guards to prevent sticky hover on mobile (#340)

Cindy Zhangb258f19911bc
diff --git a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
index 6aa4f8f17f..f2f57c067f 100644
--- a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
+++ b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
@@ -92,7 +92,9 @@ const itemStyles = stylex.create({
gap: spacingVars['--spacing-1'],
textDecoration: {
default: 'none',
- ':hover': 'underline',
+ ':hover': {
+ '@media (hover: hover)': 'underline',
+ },
},
cursor: 'pointer',
},
diff --git a/packages/core/src/Button/XDSButton.tsx b/packages/core/src/Button/XDSButton.tsx
index 2ed31fe435..c911e733e4 100644
--- a/packages/core/src/Button/XDSButton.tsx
+++ b/packages/core/src/Button/XDSButton.tsx
@@ -101,7 +101,9 @@ const variants = stylex.create({
color: colorVars['--color-text-on-media'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
outline: {
@@ -118,7 +120,9 @@ const variants = stylex.create({
color: colorVars['--color-text-primary'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
outline: {
@@ -135,7 +139,9 @@ const variants = stylex.create({
color: colorVars['--color-text-primary'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
outline: {
@@ -152,7 +158,9 @@ const variants = stylex.create({
color: colorVars['--color-text-on-media'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
outline: {
diff --git a/packages/core/src/Calendar/styles.ts b/packages/core/src/Calendar/styles.ts
index 4e003cd2b6..364f41feb7 100644
--- a/packages/core/src/Calendar/styles.ts
+++ b/packages/core/src/Calendar/styles.ts
@@ -236,7 +236,9 @@ export const dayCellTheme = stylex.create({
backgroundColor: 'transparent',
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
},
outline: {
default: null,
@@ -269,7 +271,9 @@ export const dayCellTheme = stylex.create({
color: colorVars['--color-text-on-media'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
},
},
diff --git a/packages/core/src/CheckboxInput/XDSCheckboxInput.tsx b/packages/core/src/CheckboxInput/XDSCheckboxInput.tsx
index 5168f47dc1..1056bfdb4b 100644
--- a/packages/core/src/CheckboxInput/XDSCheckboxInput.tsx
+++ b/packages/core/src/CheckboxInput/XDSCheckboxInput.tsx
@@ -82,25 +82,29 @@ const styles = stylex.create({
checkboxUnchecked: {
borderColor: {
default: colorVars['--color-divider-emphasized'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-divider-emphasized']}, ${colorVars['--color-hover-tint']} 20%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-divider-emphasized']}, ${colorVars['--color-hover-tint']} 20%)`,
+ },
},
backgroundColor: {
default: colorVars['--color-surface'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-surface']}, ${colorVars['--color-hover-tint']} 5%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-surface']}, ${colorVars['--color-hover-tint']} 5%)`,
+ },
},
},
checkboxChecked: {
borderColor: {
default: colorVars['--color-accent'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
backgroundColor: {
default: colorVars['--color-accent'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
},
checkboxDisabled: {
diff --git a/packages/core/src/DateInput/XDSDateInput.tsx b/packages/core/src/DateInput/XDSDateInput.tsx
index 2a4ddcae1c..aa6487ecb5 100644
--- a/packages/core/src/DateInput/XDSDateInput.tsx
+++ b/packages/core/src/DateInput/XDSDateInput.tsx
@@ -59,7 +59,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -67,7 +69,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -178,19 +182,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
diff --git a/packages/core/src/Link/XDSLink.tsx b/packages/core/src/Link/XDSLink.tsx
index e139131bf1..e11d757764 100644
--- a/packages/core/src/Link/XDSLink.tsx
+++ b/packages/core/src/Link/XDSLink.tsx
@@ -56,7 +56,9 @@ const styles = stylex.create({
fontWeight: 'inherit',
textDecoration: {
default: 'none',
- ':hover': 'underline',
+ ':hover': {
+ '@media (hover: hover)': 'underline',
+ },
},
cursor: 'pointer',
transitionProperty: 'color, text-decoration',
diff --git a/packages/core/src/List/XDSListItem.tsx b/packages/core/src/List/XDSListItem.tsx
index 2582055818..2b9c2637ef 100644
--- a/packages/core/src/List/XDSListItem.tsx
+++ b/packages/core/src/List/XDSListItem.tsx
@@ -130,7 +130,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
},
diff --git a/packages/core/src/NumberInput/XDSNumberInput.tsx b/packages/core/src/NumberInput/XDSNumberInput.tsx
index c71705ee6d..39f65b9660 100644
--- a/packages/core/src/NumberInput/XDSNumberInput.tsx
+++ b/packages/core/src/NumberInput/XDSNumberInput.tsx
@@ -52,7 +52,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -60,7 +62,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -153,19 +157,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
diff --git a/packages/core/src/RadioList/XDSRadioListItem.tsx b/packages/core/src/RadioList/XDSRadioListItem.tsx
index 327ec9226d..eac8b804e9 100644
--- a/packages/core/src/RadioList/XDSRadioListItem.tsx
+++ b/packages/core/src/RadioList/XDSRadioListItem.tsx
@@ -61,25 +61,29 @@ const styles = stylex.create({
radioUnchecked: {
borderColor: {
default: colorVars['--color-divider-emphasized'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-divider-emphasized']}, ${colorVars['--color-hover-tint']} 20%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-divider-emphasized']}, ${colorVars['--color-hover-tint']} 20%)`,
+ },
},
backgroundColor: {
default: colorVars['--color-surface'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-surface']}, ${colorVars['--color-hover-tint']} 5%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-surface']}, ${colorVars['--color-hover-tint']} 5%)`,
+ },
},
},
radioChecked: {
borderColor: {
default: colorVars['--color-accent'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
backgroundColor: {
default: colorVars['--color-accent'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
},
radioWrapperFocus: {
diff --git a/packages/core/src/Selector/XDSSelector.tsx b/packages/core/src/Selector/XDSSelector.tsx
index 58bddab0ac..3327f6a4f2 100644
--- a/packages/core/src/Selector/XDSSelector.tsx
+++ b/packages/core/src/Selector/XDSSelector.tsx
@@ -65,7 +65,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -78,7 +80,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -241,19 +245,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
diff --git a/packages/core/src/SideNav/XDSSideNavHeader.tsx b/packages/core/src/SideNav/XDSSideNavHeader.tsx
index 15e761c91f..8f1938ceb8 100644
--- a/packages/core/src/SideNav/XDSSideNavHeader.tsx
+++ b/packages/core/src/SideNav/XDSSideNavHeader.tsx
@@ -59,7 +59,9 @@ const styles = stylex.create({
fontSize: 'inherit',
textAlign: 'start',
':hover': {
- backgroundColor: colorVars['--color-hover-overlay'],
+ '@media (hover: hover)': {
+ backgroundColor: colorVars['--color-hover-overlay'],
+ },
},
},
interactiveInset: {
diff --git a/packages/core/src/SideNav/XDSSideNavItem.tsx b/packages/core/src/SideNav/XDSSideNavItem.tsx
index b559eb699a..fe5854c8ea 100644
--- a/packages/core/src/SideNav/XDSSideNavItem.tsx
+++ b/packages/core/src/SideNav/XDSSideNavItem.tsx
@@ -61,14 +61,18 @@ const styles = stylex.create({
textAlign: 'start',
boxSizing: 'border-box',
':hover': {
- backgroundColor: colorVars['--color-hover-overlay'],
+ '@media (hover: hover)': {
+ backgroundColor: colorVars['--color-hover-overlay'],
+ },
},
},
selected: {
backgroundColor: colorVars['--color-deemphasized'],
fontWeight: fontWeightVars['--font-weight-medium'],
':hover': {
- backgroundColor: colorVars['--color-deemphasized'],
+ '@media (hover: hover)': {
+ backgroundColor: colorVars['--color-deemphasized'],
+ },
},
},
disabled: {
diff --git a/packages/core/src/Slider/XDSSlider.tsx b/packages/core/src/Slider/XDSSlider.tsx
index f27cada65d..00a7fbe9bf 100644
--- a/packages/core/src/Slider/XDSSlider.tsx
+++ b/packages/core/src/Slider/XDSSlider.tsx
@@ -215,7 +215,9 @@ const styles = stylex.create({
thumbHover: {
backgroundColor: {
default: colorVars['--color-accent'],
- ':hover': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ ':hover': {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
},
thumbFocusWithin: {
diff --git a/packages/core/src/Switch/XDSSwitch.tsx b/packages/core/src/Switch/XDSSwitch.tsx
index 7611790190..ce17e1bd85 100644
--- a/packages/core/src/Switch/XDSSwitch.tsx
+++ b/packages/core/src/Switch/XDSSwitch.tsx
@@ -102,15 +102,17 @@ const styles = stylex.create({
trackOff: {
backgroundColor: {
default: colorVars['--color-gray-background'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-gray-background']}, ${colorVars['--color-hover-tint']} 5%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-gray-background']}, ${colorVars['--color-hover-tint']} 5%)`,
+ },
},
},
trackOn: {
backgroundColor: {
default: colorVars['--color-accent'],
- [stylex.when.ancestor(':hover')]:
- `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-accent']}, ${colorVars['--color-hover-tint']} 15%)`,
+ },
},
},
trackDisabled: {
diff --git a/packages/core/src/TabList/XDSTab.tsx b/packages/core/src/TabList/XDSTab.tsx
index 702df3c435..4fe22d8353 100644
--- a/packages/core/src/TabList/XDSTab.tsx
+++ b/packages/core/src/TabList/XDSTab.tsx
@@ -118,7 +118,9 @@ const styles = stylex.create({
borderRadius: radiusVars['--radius-rounded'],
opacity: {
default: 0,
- [stylex.when.ancestor(':hover')]: 1,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': 1,
+ },
},
transitionProperty: 'opacity',
transitionDuration: transitionVars['--transition-fast'],
diff --git a/packages/core/src/TabList/XDSTabMenu.tsx b/packages/core/src/TabList/XDSTabMenu.tsx
index aef8ad84e3..4c46e32471 100644
--- a/packages/core/src/TabList/XDSTabMenu.tsx
+++ b/packages/core/src/TabList/XDSTabMenu.tsx
@@ -129,7 +129,9 @@ const styles = stylex.create({
borderRadius: radiusVars['--radius-rounded'],
opacity: {
default: 0,
- [stylex.when.ancestor(':hover')]: 1,
+ [stylex.when.ancestor(':hover')]: {
+ '@media (hover: hover)': 1,
+ },
},
transitionProperty: 'opacity',
transitionDuration: transitionVars['--transition-fast'],
@@ -174,7 +176,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundColor: {
default: 'transparent',
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
},
outline: {
default: null,
diff --git a/packages/core/src/Table/XDSTableRow.tsx b/packages/core/src/Table/XDSTableRow.tsx
index b1b445d57f..89d9a1298d 100644
--- a/packages/core/src/Table/XDSTableRow.tsx
+++ b/packages/core/src/Table/XDSTableRow.tsx
@@ -42,7 +42,9 @@ const hoverRowStyles = stylex.create({
row: {
backgroundColor: {
default: null,
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
},
transitionProperty: 'background-color',
transitionDuration: transitionVars['--transition-fast'],
@@ -54,7 +56,9 @@ const stripedHoverRowStyles = stylex.create({
backgroundColor: {
default: null,
':nth-child(even)': colorVars['--color-wash'],
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
},
transitionProperty: 'background-color',
transitionDuration: transitionVars['--transition-fast'],
diff --git a/packages/core/src/TextArea/XDSTextArea.tsx b/packages/core/src/TextArea/XDSTextArea.tsx
index 3548d358f9..704589ee9f 100644
--- a/packages/core/src/TextArea/XDSTextArea.tsx
+++ b/packages/core/src/TextArea/XDSTextArea.tsx
@@ -52,7 +52,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -60,7 +62,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -144,19 +148,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
@@ -217,7 +229,10 @@ export interface XDSTextAreaProps {
*/
onChange?: (value: string, e: ChangeEvent<HTMLTextAreaElement>) => void;
/** Async action on change. Fires after onChange if not prevented. */
- onChangeAction?: (value: string, e: ChangeEvent<HTMLTextAreaElement>) => void | Promise<void>;
+ onChangeAction?: (
+ value: string,
+ e: ChangeEvent<HTMLTextAreaElement>,
+ ) => void | Promise<void>;
/** Whether the input is in a loading state. @default false */
isLoading?: boolean;
/**
diff --git a/packages/core/src/TextInput/XDSTextInput.tsx b/packages/core/src/TextInput/XDSTextInput.tsx
index b5f8819ffb..3403f43a4c 100644
--- a/packages/core/src/TextInput/XDSTextInput.tsx
+++ b/packages/core/src/TextInput/XDSTextInput.tsx
@@ -11,7 +11,14 @@
* - /apps/storybook/stories/TextInput.stories.tsx (storybook stories)
*/
-import {forwardRef, useContext, useId, useOptimistic, useTransition, type ChangeEvent} from 'react';
+import {
+ forwardRef,
+ useContext,
+ useId,
+ useOptimistic,
+ useTransition,
+ type ChangeEvent,
+} from 'react';
import * as stylex from '@stylexjs/stylex';
import type {XDSIconName} from '../Icon';
import {
@@ -43,7 +50,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -51,7 +60,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -114,19 +125,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
@@ -228,7 +247,10 @@ export interface XDSTextInputProps {
*/
onChange?: (value: string, e: ChangeEvent<HTMLInputElement>) => void;
/** Async action on change. Fires after onChange if not prevented. */
- onChangeAction?: (value: string, e: ChangeEvent<HTMLInputElement>) => void | Promise<void>;
+ onChangeAction?: (
+ value: string,
+ e: ChangeEvent<HTMLInputElement>,
+ ) => void | Promise<void>;
/** Whether the input is in a loading state. @default false */
isLoading?: boolean;
/**
diff --git a/packages/core/src/TimeInput/XDSTimeInput.tsx b/packages/core/src/TimeInput/XDSTimeInput.tsx
index 37246aab4c..f6da3f437a 100644
--- a/packages/core/src/TimeInput/XDSTimeInput.tsx
+++ b/packages/core/src/TimeInput/XDSTimeInput.tsx
@@ -63,7 +63,9 @@ const styles = stylex.create({
borderStyle: 'solid',
borderColor: {
default: colorVars['--color-divider-emphasized'],
- ':hover': colorVars['--color-divider-high-contrast'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-divider-high-contrast'],
+ },
},
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
@@ -71,7 +73,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover'],
+ },
},
outline: {
default: 'none',
@@ -180,19 +184,27 @@ const statusHoverShadowStyles = stylex.create({
warning: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-warning'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-warning'],
+ },
},
},
error: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-error'],
+ ':hover': {
+ '@media (hover: hover)': elevationVars['--elevation-input-hover-error'],
+ },
},
},
success: {
boxShadow: {
default: 'none',
- ':hover': elevationVars['--elevation-input-hover-success'],
+ ':hover': {
+ '@media (hover: hover)':
+ elevationVars['--elevation-input-hover-success'],
+ },
},
},
});
diff --git a/packages/core/src/Token/XDSToken.tsx b/packages/core/src/Token/XDSToken.tsx
index 5d9c17bcea..d7d9de9923 100644
--- a/packages/core/src/Token/XDSToken.tsx
+++ b/packages/core/src/Token/XDSToken.tsx
@@ -131,7 +131,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundImage: {
default: null,
- ':hover': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ ':hover': {
+ '@media (hover: hover)': `linear-gradient(${colorVars['--color-hover-overlay']}, ${colorVars['--color-hover-overlay']})`,
+ },
':active': `linear-gradient(${colorVars['--color-pressed-overlay']}, ${colorVars['--color-pressed-overlay']})`,
},
outline: {
diff --git a/packages/core/src/TopNav/XDSTopNavItem.tsx b/packages/core/src/TopNav/XDSTopNavItem.tsx
index b0bc2bf87f..a0abb94fa0 100644
--- a/packages/core/src/TopNav/XDSTopNavItem.tsx
+++ b/packages/core/src/TopNav/XDSTopNavItem.tsx
@@ -48,7 +48,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundColor: {
default: 'transparent',
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
':active': colorVars['--color-pressed-overlay'],
},
outline: {
@@ -65,7 +67,9 @@ const styles = stylex.create({
fontWeight: fontWeightVars['--font-weight-semibold'],
backgroundColor: {
default: colorVars['--color-deemphasized'],
- ':hover': colorVars['--color-deemphasized'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-deemphasized'],
+ },
':active': colorVars['--color-deemphasized'],
},
},
diff --git a/packages/core/src/TopNav/XDSTopNavMenu.tsx b/packages/core/src/TopNav/XDSTopNavMenu.tsx
index fff938fc9e..a9ccf0b6eb 100644
--- a/packages/core/src/TopNav/XDSTopNavMenu.tsx
+++ b/packages/core/src/TopNav/XDSTopNavMenu.tsx
@@ -45,7 +45,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundColor: {
default: 'transparent',
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
},
outline: {
default: null,
@@ -77,7 +79,9 @@ const styles = stylex.create({
transitionDuration: transitionVars['--transition-fast'],
backgroundColor: {
default: 'transparent',
- ':hover': colorVars['--color-hover-overlay'],
+ ':hover': {
+ '@media (hover: hover)': colorVars['--color-hover-overlay'],
+ },
},
border: 'none',
outline: {