Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(docsite): filter theme registry to only installed packages (#2035)

Cindy Zhangb2cda13b59e4
diff --git a/apps/docsite/scripts/generate-data.mjs b/apps/docsite/scripts/generate-data.mjs
index b9952130e4..0205e49ee8 100644
--- a/apps/docsite/scripts/generate-data.mjs
+++ b/apps/docsite/scripts/generate-data.mjs
@@ -685,7 +685,11 @@ export const docsCount = ${docTopics.length};
function generateThemeRegistry(packages) {
console.log('Generating theme registry...');
- const themePackages = packages.filter(p => p.name.startsWith('@xds/theme-'));
+ const docsitePkg = JSON.parse(fs.readFileSync(path.join(DOCSITE_ROOT, 'package.json'), 'utf-8'));
+ const docsiteDeps = {...docsitePkg.dependencies, ...docsitePkg.devDependencies};
+ const themePackages = packages.filter(p =>
+ p.name.startsWith('@xds/theme-') && docsiteDeps[p.name] != null
+ );
if (!themePackages.length) {
writeRegistry('themeRegistry.ts', `// Auto-generated — no theme packages found
import type {XDSDefinedTheme} from '@xds/core/theme';
diff --git a/apps/docsite/src/__tests__/data-extraction.test.ts b/apps/docsite/src/__tests__/data-extraction.test.ts
index a996b90be4..93acd17f43 100644
--- a/apps/docsite/src/__tests__/data-extraction.test.ts
+++ b/apps/docsite/src/__tests__/data-extraction.test.ts
@@ -487,9 +487,16 @@ describe('themeRegistry', () => {
expect(registrySource).toContain('themeObjects');
});
- it('has an import and entry for every theme package', () => {
- const themePackages = packages.filter(p =>
- p.name.startsWith('@xds/theme-'),
+ it('has an import and entry for every installed theme package', () => {
+ const docsitePkg = JSON.parse(
+ fs.readFileSync(new URL('../../package.json', import.meta.url), 'utf-8'),
+ );
+ const docsiteDeps = {
+ ...docsitePkg.dependencies,
+ ...docsitePkg.devDependencies,
+ };
+ const themePackages = packages.filter(
+ p => p.name.startsWith('@xds/theme-') && docsiteDeps[p.name] != null,
);
expect(themePackages.length).toBeGreaterThan(0);
for (const pkg of themePackages) {
@@ -499,6 +506,22 @@ describe('themeRegistry', () => {
}
});
+ it('excludes theme packages not installed in the docsite', () => {
+ const docsitePkg = JSON.parse(
+ fs.readFileSync(new URL('../../package.json', import.meta.url), 'utf-8'),
+ );
+ const docsiteDeps = {
+ ...docsitePkg.dependencies,
+ ...docsitePkg.devDependencies,
+ };
+ const uninstalled = packages.filter(
+ p => p.name.startsWith('@xds/theme-') && docsiteDeps[p.name] == null,
+ );
+ for (const pkg of uninstalled) {
+ expect(registrySource).not.toContain(`from '${pkg.name}/built'`);
+ }
+ });
+
it('has no entries for non-theme packages', () => {
const nonTheme = packages.filter(p => !p.name.startsWith('@xds/theme-'));
for (const pkg of nonTheme) {