Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

feat(eslint-plugin): promote @astryx/no-physical-properties to error (#4615)

nynexman4464ba0adc584453
diff --git a/.changeset/rtl-lint-error-gate.md b/.changeset/rtl-lint-error-gate.md
new file mode 100644
index 0000000000..c5af643de9
--- /dev/null
+++ b/.changeset/rtl-lint-error-gate.md
@@ -0,0 +1,6 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] The RTL physical→logical migration is complete, so promote the `@astryx/no-physical-properties` lint rule from `warn` to `error` in both the recommended and strict tiers. This gates against future physical-property regressions now that the core package is clean (the one sanctioned physical suppression lives in `rtlStyles.centerInline`).
+@nynexman4464
diff --git a/internal/eslint-plugin-astryx/index.js b/internal/eslint-plugin-astryx/index.js
index 113b0b25c5..e23d593b0f 100644
--- a/internal/eslint-plugin-astryx/index.js
+++ b/internal/eslint-plugin-astryx/index.js
@@ -269,12 +269,8 @@ plugin.configs.strict = {
'@astryx/no-hardcoded-anchor': 'error',
'@astryx/no-raw-paragraph': 'error',
'@astryx/no-border-shorthand': 'error',
- // Deliberately 'warn' even in the strict tier (not 'error'): the core
- // package still has known un-migrated Phase-4 physical properties
- // (Calendar radii, Slider positioning, Table gradients) that would break CI
- // if this were an error. Ship at warn until RTL Phase 4 (Calendar/Slider/
- // Table) migration lands; flip to error afterward.
- '@astryx/no-physical-properties': 'warn',
+ // RTL physical→logical migration complete; errors to prevent regressions.
+ '@astryx/no-physical-properties': 'error',
'@astryx/no-react-namespace-hooks': 'error',
'@astryx/require-base-props': 'error',
'@astryx/require-ref-prop': 'error',
@@ -300,9 +296,8 @@ plugin.configs.recommended = {
'@astryx/no-hardcoded-anchor': 'warn',
'@astryx/no-raw-paragraph': 'warn',
'@astryx/no-border-shorthand': 'warn',
- // Warn now, flip to error after RTL Phase 4 (Calendar/Slider/Table)
- // physical-property migration lands.
- '@astryx/no-physical-properties': 'warn',
+ // RTL physical→logical migration complete; errors to prevent regressions.
+ '@astryx/no-physical-properties': 'error',
'@astryx/no-react-namespace-hooks': 'error',
'@astryx/require-base-props': 'warn',
'@astryx/require-ref-prop': 'warn',