Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(core): tokenize SelectableCard transitions, add className to ResizeHandle (#2966)

Cindy Zhangba617a4a2abb
diff --git a/packages/core/src/Resizable/ResizeHandle.tsx b/packages/core/src/Resizable/ResizeHandle.tsx
index a33ce3054d..ac78b3464f 100644
--- a/packages/core/src/Resizable/ResizeHandle.tsx
+++ b/packages/core/src/Resizable/ResizeHandle.tsx
@@ -213,7 +213,7 @@ const dynamicStyles = stylex.create({
export interface ResizeHandleProps extends Omit<
BaseProps<HTMLDivElement>,
- 'style' | 'className'
+ 'style'
> {
ref?: React.Ref<HTMLDivElement>;
@@ -311,6 +311,7 @@ export function ResizeHandle({
resizable,
children,
xstyle,
+ className,
ref,
...props
}: ResizeHandleProps) {
@@ -507,6 +508,7 @@ export function ResizeHandle({
isDisabled && styles.disabled,
xstyle,
),
+ className,
)}
{...props}>
{/* Wider invisible hit area for pointer interaction */}
diff --git a/packages/core/src/SelectableCard/SelectableCard.tsx b/packages/core/src/SelectableCard/SelectableCard.tsx
index 33d9ee2f18..8fd4c24422 100644
--- a/packages/core/src/SelectableCard/SelectableCard.tsx
+++ b/packages/core/src/SelectableCard/SelectableCard.tsx
@@ -35,7 +35,7 @@ import {
} from 'react';
import * as stylex from '@stylexjs/stylex';
import type {StyleXStyles} from '@stylexjs/stylex';
-import {colorVars} from '../theme/tokens.stylex';
+import {colorVars, durationVars, easeVars} from '../theme/tokens.stylex';
import type {SizeValue, SpacingStep} from '../utils/types';
import {mergeProps, mergeRefs} from '../utils';
import {Card} from '../Card/Card';
@@ -52,7 +52,9 @@ const styles = stylex.create({
interactive: {
position: 'relative',
cursor: 'pointer',
- transition: 'box-shadow 0.15s ease, border-color 0.15s ease',
+ transitionProperty: 'box-shadow, border-color',
+ transitionDuration: durationVars['--duration-fast'],
+ transitionTimingFunction: easeVars['--ease-standard'],
outlineOffset: '2px',
},
focusWithin: {
@@ -70,7 +72,9 @@ const styles = stylex.create({
inset: 0,
borderRadius: 'inherit',
pointerEvents: 'none',
- transition: 'background-color 0.15s ease',
+ transitionProperty: 'background-color',
+ transitionDuration: durationVars['--duration-fast'],
+ transitionTimingFunction: easeVars['--ease-standard'],
backgroundColor: 'transparent',
},
':active::after': {