An open source design system that's fully customizable and agent ready
TypeScript
fix(utils): guard adjustTime against non-finite deltas (#3584)
Md Shahrier Islam Arhambfce984528f2
diff --git a/.changeset/adjust-time-nonfinite.md b/.changeset/adjust-time-nonfinite.mdnew file mode 100644index 0000000000..ff3970686e--- /dev/null+++ b/.changeset/adjust-time-nonfinite.md@@ -0,0 +1,8 @@+---+'@astryxdesign/core': patch+---++[fix] adjustTime guards non-finite deltas and wraps negatives in O(1) (#3583)++A non-finite deltaMinutes previously spun the wrap-around loop forever (-Infinity — tab freeze) or produced the corrupt string "NaN:NaN" (NaN) that could be committed into consumer form state through DateTimeInput's timeIncrement path. Non-finite deltas now return the input time unchanged, and the negative wrap-around uses double-modulo instead of a loop.+@arham766diff --git a/packages/core/src/utils/timeParser.test.ts b/packages/core/src/utils/timeParser.test.tsindex 98a2745a4e..53409306c2 100644--- a/packages/core/src/utils/timeParser.test.ts+++ b/packages/core/src/utils/timeParser.test.ts@@ -249,6 +249,19 @@ describe('isTimeInRange', () => {});describe('adjustTime', () => {+ it('returns the input unchanged for non-finite deltas', () => {+ // -Infinity previously spun the wrap-around loop forever;+ // NaN previously produced the corrupt string "NaN:NaN".+ expect(adjustTime('10:00' as ISOTimeString, -Infinity)).toBe('10:00');+ expect(adjustTime('10:00' as ISOTimeString, Infinity)).toBe('10:00');+ expect(adjustTime('10:00' as ISOTimeString, NaN)).toBe('10:00');+ });++ it('wraps large negative deltas in constant time', () => {+ expect(adjustTime('10:00' as ISOTimeString, -1440 * 1e7)).toBe('10:00');+ expect(adjustTime('10:00' as ISOTimeString, -1440 * 1e7 - 30)).toBe('09:30');+ });+it('adds minutes', () => {expect(adjustTime('14:30' as ISOTimeString, 15)).toBe('14:45');expect(adjustTime('14:30' as ISOTimeString, 30)).toBe('15:00');diff --git a/packages/core/src/utils/timeParser.ts b/packages/core/src/utils/timeParser.tsindex b7c51188f2..057c2765f2 100644--- a/packages/core/src/utils/timeParser.ts+++ b/packages/core/src/utils/timeParser.ts@@ -361,13 +361,16 @@ export function adjustTime(return time;}+ // A non-finite delta would spin the wrap-around forever (-Infinity) or+ // produce "NaN:NaN" (NaN) — return the input unchanged instead.+ if (!Number.isFinite(deltaMinutes)) {+ return time;+ }+let totalMinutes = parsed.hour * 60 + parsed.minute + deltaMinutes;- // Wrap around midnight- while (totalMinutes < 0) {- totalMinutes += 24 * 60;- }- totalMinutes = totalMinutes % (24 * 60);+ // Wrap around midnight (double-modulo handles negatives in O(1))+ totalMinutes = ((totalMinutes % (24 * 60)) + 24 * 60) % (24 * 60);const newHour = Math.floor(totalMinutes / 60);const newMinute = totalMinutes % 60;