An open source design system that's fully customizable and agent ready
TypeScript
fix(inputs): suppress hover ring on disabled inputs (#4495)
Cindy Zhangc2189b1d75d2
diff --git a/.changeset/fix-disabled-input-hover.md b/.changeset/fix-disabled-input-hover.mdnew file mode 100644index 0000000000..f89a4202e3--- /dev/null+++ b/.changeset/fix-disabled-input-hover.md@@ -0,0 +1,6 @@+---+'@astryxdesign/core': patch+---++[fix] Inputs no longer show the hover ring while disabled. The shared input wrapper's disabled state now suppresses both the base and status hover shadows, so TextInput, TextArea, NumberInput, DateInput, TimeInput, Selector, MultiSelector, Typeahead, and Tokenizer stay visually inert on hover when disabled.+@cixzhangdiff --git a/packages/core/src/DateInput/DateInput.tsx b/packages/core/src/DateInput/DateInput.tsxindex 78bbc5063d..da9dd1d38f 100644--- a/packages/core/src/DateInput/DateInput.tsx+++ b/packages/core/src/DateInput/DateInput.tsx@@ -647,7 +647,9 @@ export function DateInput({sizeStyles[size],isEffectivelyDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !isEffectivelyDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,diff --git a/packages/core/src/DateRangeInput/DateRangeInput.tsx b/packages/core/src/DateRangeInput/DateRangeInput.tsxindex 4ebf686567..588d309fc2 100644--- a/packages/core/src/DateRangeInput/DateRangeInput.tsx+++ b/packages/core/src/DateRangeInput/DateRangeInput.tsx@@ -560,7 +560,9 @@ export function DateRangeInput({sizeStyles[size],isEffectivelyDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !isEffectivelyDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],xstyle,),diff --git a/packages/core/src/DateTimeInput/DateTimeInput.tsx b/packages/core/src/DateTimeInput/DateTimeInput.tsxindex 4c0ca31482..dddf2dc5a2 100644--- a/packages/core/src/DateTimeInput/DateTimeInput.tsx+++ b/packages/core/src/DateTimeInput/DateTimeInput.tsx@@ -901,7 +901,9 @@ export function DateTimeInput({styles.dateWrapper,isEffectivelyDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !isEffectivelyDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],),)}>@@ -999,7 +1001,9 @@ export function DateTimeInput({styles.timeWrapper,isEffectivelyDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !isEffectivelyDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],),)}>diff --git a/packages/core/src/Field/inputStyles.stylex.ts b/packages/core/src/Field/inputStyles.stylex.tsindex c8c8144108..9d88e4f1dd 100644--- a/packages/core/src/Field/inputStyles.stylex.ts+++ b/packages/core/src/Field/inputStyles.stylex.ts@@ -67,6 +67,8 @@ export const inputWrapperStyles = stylex.create({cursor: 'not-allowed',opacity: 0.5,borderColor: colorVars['--color-border-emphasized'],+ // Suppress the base hover ring — a disabled control must not react to hover.+ boxShadow: 'none',},});diff --git a/packages/core/src/MultiSelector/MultiSelector.tsx b/packages/core/src/MultiSelector/MultiSelector.tsxindex cf0bb4a669..429269423b 100644--- a/packages/core/src/MultiSelector/MultiSelector.tsx+++ b/packages/core/src/MultiSelector/MultiSelector.tsx@@ -781,13 +781,7 @@ export function MultiSelector<T extends MultiSelectorOptionType>({return [{value: SELECT_ALL_VALUE, label: selectAllLabel}, ...result];}return result;- }, [- searchQuery,- options,- selectedAtOpen,- hasSelectAll,- selectAllLabel,- ]);+ }, [searchQuery, options, selectedAtOpen, hasSelectAll, selectAllLabel]);// Layer for dropdown positioningconst handleLayerHide = useCallback(() => {@@ -1319,7 +1313,7 @@ export function MultiSelector<T extends MultiSelectorOptionType>({isDisabled && inputWrapperStyles.disabled,optimisticValue.length === 0 && styles.triggerPlaceholder,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,),diff --git a/packages/core/src/NumberInput/NumberInput.tsx b/packages/core/src/NumberInput/NumberInput.tsxindex 8cfaad8c3f..e82581bc19 100644--- a/packages/core/src/NumberInput/NumberInput.tsx+++ b/packages/core/src/NumberInput/NumberInput.tsx@@ -618,7 +618,7 @@ export function NumberInput({sizeStyles[size],isDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,diff --git a/packages/core/src/Selector/Selector.tsx b/packages/core/src/Selector/Selector.tsxindex fd7bd94f67..fceb5e5883 100644--- a/packages/core/src/Selector/Selector.tsx+++ b/packages/core/src/Selector/Selector.tsx@@ -1046,7 +1046,7 @@ export function Selector<T extends SelectorOptionType>(isDisabled && inputWrapperStyles.disabled,!selectedItem && styles.triggerPlaceholder,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,),diff --git a/packages/core/src/TextArea/TextArea.tsx b/packages/core/src/TextArea/TextArea.tsxindex 4013d52095..66ca5c2f91 100644--- a/packages/core/src/TextArea/TextArea.tsx+++ b/packages/core/src/TextArea/TextArea.tsx@@ -442,7 +442,9 @@ export function TextArea({textareaSizeStyles[size],effectivelyDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !effectivelyDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],xstyle,),diff --git a/packages/core/src/TextInput/TextInput.tsx b/packages/core/src/TextInput/TextInput.tsxindex 62cd1a4bd6..e67f898df9 100644--- a/packages/core/src/TextInput/TextInput.tsx+++ b/packages/core/src/TextInput/TextInput.tsx@@ -413,7 +413,7 @@ export function TextInput({sizeStyles[size],isDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,diff --git a/packages/core/src/TimeInput/TimeInput.tsx b/packages/core/src/TimeInput/TimeInput.tsxindex 60c84cd6c9..27e2c6c8a8 100644--- a/packages/core/src/TimeInput/TimeInput.tsx+++ b/packages/core/src/TimeInput/TimeInput.tsx@@ -619,7 +619,7 @@ export function TimeInput({sizeStyles[size],isDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],inputGroup && groupStyles.inGroup,xstyle,diff --git a/packages/core/src/Tokenizer/Tokenizer.tsx b/packages/core/src/Tokenizer/Tokenizer.tsxindex 87f4dfe43d..e36f784ad3 100644--- a/packages/core/src/Tokenizer/Tokenizer.tsx+++ b/packages/core/src/Tokenizer/Tokenizer.tsx@@ -739,7 +739,7 @@ export function Tokenizer<T extends SearchableItem>({isTruncated && styles.truncatedWrapper,isDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],),)}>@@ -837,7 +837,9 @@ export function Tokenizer<T extends SearchableItem>({isTruncated && styles.truncatedWrapper,isDisabled && inputWrapperStyles.disabled,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status &&+ !isDisabled &&+ inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],),)}>diff --git a/packages/core/src/Typeahead/Typeahead.tsx b/packages/core/src/Typeahead/Typeahead.tsxindex 6582a5447b..7e1d1a5951 100644--- a/packages/core/src/Typeahead/Typeahead.tsx+++ b/packages/core/src/Typeahead/Typeahead.tsx@@ -421,7 +421,7 @@ export function Typeahead<T extends SearchableItem>({styles.wrapper,sizeStyle,status && inputStatusBorderStyles[status.type],- status && inputStatusHoverShadowStyles[status.type],+ status && !isDisabled && inputStatusHoverShadowStyles[status.type],status && inputStatusFocusWithinStyles[status.type],isDisabled && inputWrapperStyles.disabled,inputGroup && groupStyles.inGroup,