An open source design system that's fully customizable and agent ready
TypeScript
fix(type-scale): use Math.round for 4px grid snapping in computeLeading (#664)
Ernestca04963c5a6c
diff --git a/packages/core/src/theme/expandTypeScale.ts b/packages/core/src/theme/expandTypeScale.tsindex 04f2a31a70..eacd8021bf 100644--- a/packages/core/src/theme/expandTypeScale.ts+++ b/packages/core/src/theme/expandTypeScale.ts@@ -172,7 +172,10 @@ function computeSize(base: number, ratio: number, step: number): number {*/function computeLeading(fontSize: number, targetRatio: number): number {const rawLh = fontSize * targetRatio;- const snappedLh = Math.max(Math.ceil(rawLh / 4) * 4, fontSize + 4);+ const snappedLh = Math.max(+ Math.round(rawLh / 4) * 4,+ Math.ceil((fontSize + 4) / 4) * 4,+ );// Round to 4 decimal places for clean CSS outputreturn Math.round((snappedLh / fontSize) * 10000) / 10000;}diff --git a/packages/core/src/theme/tokens.stylex.ts b/packages/core/src/theme/tokens.stylex.tsindex ef2a92d80d..9e4145f7a4 100644--- a/packages/core/src/theme/tokens.stylex.ts+++ b/packages/core/src/theme/tokens.stylex.ts@@ -369,16 +369,16 @@ export const typeScaleDefaults = {// Text tokens — body/label/code at base, large one step up, supporting one step down'--text-body-size': 'var(--text-base)', // 14px'--text-body-weight': 'var(--font-weight-normal)',- '--text-body-leading': '1.7143',+ '--text-body-leading': '1.4286','--text-large-size': '17px', // 14 × 1.2¹ (no matching --text-* token)'--text-large-weight': 'var(--font-weight-semibold)',- '--text-large-leading': '1.6471',+ '--text-large-leading': '1.4118','--text-label-size': 'var(--text-base)', // 14px'--text-label-weight': 'var(--font-weight-medium)','--text-label-leading': '1.4286','--text-code-size': 'var(--text-base)', // 14px'--text-code-weight': 'var(--font-weight-normal)',- '--text-code-leading': '1.7143',+ '--text-code-leading': '1.4286','--text-supporting-size': 'var(--text-xsm)', // 12px'--text-supporting-weight': 'var(--font-weight-normal)','--text-supporting-leading': '1.6667',