An open source design system that's fully customizable and agent ready
TypeScript
fix(templates): fix image fill issues in classic-gallery and library (#2130)
rubyycheungcb4c48d5100c
diff --git a/packages/cli/templates/pages/classic-gallery/page.tsx b/packages/cli/templates/pages/classic-gallery/page.tsxindex a5f35473cf..f7830e83bc 100644--- a/packages/cli/templates/pages/classic-gallery/page.tsx+++ b/packages/cli/templates/pages/classic-gallery/page.tsx@@ -6,7 +6,6 @@ import {XDSVStack} from '@xds/core/Layout';import {XDSCenter} from '@xds/core/Center';import {XDSText, XDSHeading} from '@xds/core/Text';import {XDSGrid} from '@xds/core/Grid';-import {XDSAspectRatio} from '@xds/core/AspectRatio';import {XDSSection} from '@xds/core/Section';import {XDSTabList, XDSTab} from '@xds/core/TabList';import * as stylex from '@stylexjs/stylex';@@ -21,6 +20,8 @@ const styles = stylex.create({paddingBlock: 'var(--spacing-8)',},imageWrapper: {+ position: 'relative',+ aspectRatio: '3/2',borderRadius: 'var(--radius-container)',overflow: 'clip',},@@ -28,6 +29,8 @@ const styles = stylex.create({textAlign: 'center',},imgFill: {+ position: 'absolute',+ inset: 0,width: '100%',height: '100%',objectFit: 'cover',@@ -153,16 +156,13 @@ export default function ClassicGalleryTemplate() {{/* Gallery Grid */}<XDSGrid columns={{minWidth: 400}} gap={4}>{filteredImages.map((image, i) => (- <XDSAspectRatio- key={i}- ratio={3 / 2}- xstyle={styles.imageWrapper}>+ <div key={i} {...stylex.props(styles.imageWrapper)}><imgsrc={image.src}alt={image.alt}{...stylex.props(styles.imgFill)}/>- </XDSAspectRatio>+ </div>))}</XDSGrid></XDSVStack>diff --git a/packages/cli/templates/pages/library/page.tsx b/packages/cli/templates/pages/library/page.tsxindex 8cd8de89ca..0268027a9b 100644--- a/packages/cli/templates/pages/library/page.tsx+++ b/packages/cli/templates/pages/library/page.tsx@@ -5,7 +5,6 @@ import * as stylex from '@stylexjs/stylex';import {XDSLayout, XDSLayoutHeader, XDSLayoutContent} from '@xds/core/Layout';import {XDSText, XDSHeading} from '@xds/core/Text';import {XDSCard} from '@xds/core/Card';-import {XDSAspectRatio} from '@xds/core/AspectRatio';import {XDSToggleButton, XDSToggleButtonGroup} from '@xds/core/ToggleButton';import {XDSTextInput} from '@xds/core/TextInput';import {XDSDivider} from '@xds/core/Divider';@@ -310,7 +309,15 @@ const ITEMS: LibraryItem[] = [];const styles = stylex.create({+ thumbnailWrapper: {+ position: 'relative',+ aspectRatio: '16/9',+ overflow: 'clip',+ flexShrink: 0,+ },thumbnailImage: {+ position: 'absolute',+ inset: 0,width: '100%',height: '100%',objectFit: 'cover',@@ -365,13 +372,13 @@ function LibraryNav() {function LibraryCard({item}: {item: LibraryItem}) {return (<XDSCard padding={0}>- <XDSAspectRatio ratio={16 / 9}>+ <div {...stylex.props(styles.thumbnailWrapper)}><imgsrc={item.imageUrl}alt={item.name}{...stylex.props(styles.thumbnailImage)}/>- </XDSAspectRatio>+ </div><XDSSection variant="transparent" padding={4}><XDSVStack gap={1}><XDSHeading level={3}>{item.name}</XDSHeading>diff --git a/packages/core/src/AspectRatio/XDSAspectRatio.tsx b/packages/core/src/AspectRatio/XDSAspectRatio.tsxindex 9723e6b334..e709723432 100644--- a/packages/core/src/AspectRatio/XDSAspectRatio.tsx+++ b/packages/core/src/AspectRatio/XDSAspectRatio.tsx@@ -60,6 +60,9 @@ const styles = stylex.create({container: {position: 'relative',width: '100%',+ overflow: 'clip',+ minHeight: 0,+ flexShrink: 0,},child: {position: 'absolute',