Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(AppShell): replace hardcoded spacing with spacingVars tokens in skip link (#650)

Cindy Zhangd1117b95fdd6
diff --git a/packages/core/src/AppShell/XDSAppShell.tsx b/packages/core/src/AppShell/XDSAppShell.tsx
index 0612cbd1c5..877cd959d6 100644
--- a/packages/core/src/AppShell/XDSAppShell.tsx
+++ b/packages/core/src/AppShell/XDSAppShell.tsx
@@ -30,6 +30,7 @@ import {
colorVars,
fontWeightVars,
radiusVars,
+ spacingVars,
textSizeVars,
} from '../theme/tokens.stylex';
import {XDSLayout} from '../Layout/XDSLayout';
@@ -280,9 +281,13 @@ const styles = stylex.create({
default: '1px',
':focus': 'auto',
},
- padding: {
+ paddingBlock: {
default: 0,
- ':focus': '8px 16px',
+ ':focus': spacingVars['--spacing-2'],
+ },
+ paddingInline: {
+ default: 0,
+ ':focus': spacingVars['--spacing-4'],
},
margin: {
default: '-1px',
@@ -304,11 +309,11 @@ const styles = stylex.create({
// Focus styles
top: {
default: 0,
- ':focus': '8px',
+ ':focus': spacingVars['--spacing-2'],
},
insetInlineStart: {
default: 0,
- ':focus': '8px',
+ ':focus': spacingVars['--spacing-2'],
},
backgroundColor: colorVars['--color-surface'],
color: colorVars['--color-accent-text'],