Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(ListItem): use fixed inline padding (8px default, 12px spacious) (#887)

Cindy Zhangd492c0c3658f
diff --git a/packages/core/src/List/XDSListItem.tsx b/packages/core/src/List/XDSListItem.tsx
index 2aa8f497ee..11e5e8de01 100644
--- a/packages/core/src/List/XDSListItem.tsx
+++ b/packages/core/src/List/XDSListItem.tsx
@@ -13,7 +13,6 @@
* - /apps/storybook/stories/List.stories.tsx
*/
-
import {useContext, type ReactNode} from 'react';
import * as stylex from '@stylexjs/stylex';
import type {StyleXStyles} from '@stylexjs/stylex';
@@ -124,6 +123,7 @@ const styles = stylex.create({
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-3'],
+ paddingInline: spacingVars['--spacing-2'],
position: 'relative',
boxSizing: 'border-box',
textAlign: 'start',
@@ -132,6 +132,7 @@ const styles = stylex.create({
// so the browser renders the ::marker. Flex layout moves to inner wrapper.
itemWithMarker: {
display: 'list-item',
+ paddingInline: spacingVars['--spacing-2'],
position: 'relative',
boxSizing: 'border-box',
textAlign: 'start',
@@ -243,19 +244,17 @@ const styles = stylex.create({
const densityStyles = stylex.create({
compact: {
paddingBlock: spacingVars['--spacing-1'],
- paddingInline: spacingVars['--spacing-2'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-snug'],
},
balanced: {
paddingBlock: spacingVars['--spacing-2'],
- paddingInline: spacingVars['--spacing-3'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-snug'],
},
spacious: {
paddingBlock: spacingVars['--spacing-3'],
- paddingInline: spacingVars['--spacing-4'],
+ paddingInline: spacingVars['--spacing-3'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-normal'],
},
diff --git a/packages/core/src/TreeList/XDSTreeListItem.tsx b/packages/core/src/TreeList/XDSTreeListItem.tsx
index f4ae6db4b6..240454dc28 100644
--- a/packages/core/src/TreeList/XDSTreeListItem.tsx
+++ b/packages/core/src/TreeList/XDSTreeListItem.tsx
@@ -11,7 +11,6 @@
* - /packages/core/src/TreeList/XDSTreeList.tsx
*/
-
import {useId, useMemo, type ReactNode} from 'react';
import * as stylex from '@stylexjs/stylex';
import {
@@ -68,6 +67,7 @@ const styles = stylex.create({
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-2'],
+ paddingInline: spacingVars['--spacing-2'],
outline: 'none',
overflow: 'hidden',
position: 'relative',
@@ -196,19 +196,17 @@ const styles = stylex.create({
const densityStyles = stylex.create({
compact: {
paddingBlock: spacingVars['--spacing-1'],
- paddingInline: spacingVars['--spacing-2'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-snug'],
},
balanced: {
paddingBlock: spacingVars['--spacing-2'],
- paddingInline: spacingVars['--spacing-3'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-snug'],
},
spacious: {
paddingBlock: spacingVars['--spacing-3'],
- paddingInline: spacingVars['--spacing-4'],
+ paddingInline: spacingVars['--spacing-3'],
fontSize: typeScaleVars['--text-body-size'],
lineHeight: lineHeightVars['--leading-normal'],
},