Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(SideNav): anchor the collapsed icon-only heading trigger to its menu popover (#4850)

Ojas Mutrejad78d8c05e12c
diff --git a/.changeset/sidenav-heading-collapsed-popover-anchor.md b/.changeset/sidenav-heading-collapsed-popover-anchor.md
new file mode 100644
index 0000000000..cf41ed478b
--- /dev/null
+++ b/.changeset/sidenav-heading-collapsed-popover-anchor.md
@@ -0,0 +1,7 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] SideNav: the collapsed icon-only `SideNavHeading` trigger with a `menu` no longer omits its popover's anchor. The trigger's ref callback wasn't forwarding to `usePopover`'s `triggerRef`, so the menu popover had no CSS anchor to position against and fell back to the viewport corner instead of opening next to the trigger.
+
+@HelloOjasMutreja
diff --git a/packages/core/src/SideNav/SideNav.test.tsx b/packages/core/src/SideNav/SideNav.test.tsx
index 27a2839866..6c8b0c0ef4 100644
--- a/packages/core/src/SideNav/SideNav.test.tsx
+++ b/packages/core/src/SideNav/SideNav.test.tsx
@@ -613,6 +613,31 @@ describe('SideNavHeading collapsed', () => {
expect(menu!.contains(button)).toBe(false);
}
});
+
+ it('anchors the collapsed icon-only trigger so the popover positions against it', () => {
+ render(
+ <CollapsedWrapper>
+ <SideNavHeading
+ heading="My App"
+ icon={<span data-testid="app-icon">🏠</span>}
+ menu={<div role="menuitem">Alpha</div>}
+ />
+ </CollapsedWrapper>,
+ );
+ const trigger = screen.getByRole('button', {name: 'My App'});
+ // The same element also carries the collapsed-item Tooltip's own
+ // anchor-name (via anchorRef={collapsedItemRef}), so a plain
+ // non-empty check would pass even when the menu popover itself isn't
+ // anchored. Assert the popover's own position-anchor id specifically
+ // appears in the trigger's (possibly multi-value) anchor-name list.
+ const popoverEl = document.querySelector('[popover]') as HTMLElement;
+ const anchorId = popoverEl.style.positionAnchor;
+ expect(anchorId).not.toBe('');
+ const triggerAnchorNames = trigger.style.anchorName
+ .split(',')
+ .map(s => s.trim());
+ expect(triggerAnchorNames).toContain(anchorId);
+ });
});
// =============================================================================
diff --git a/packages/core/src/SideNav/SideNavHeading.tsx b/packages/core/src/SideNav/SideNavHeading.tsx
index 01b58a48f8..2735890b61 100644
--- a/packages/core/src/SideNav/SideNavHeading.tsx
+++ b/packages/core/src/SideNav/SideNavHeading.tsx
@@ -398,7 +398,11 @@ export function SideNavHeading({
if (isCollapsed && icon) {
const collapsedIcon = <span {...stylex.props(styles.icon)}>{icon}</span>;
- const collapsedSetRef = mergeRefs<HTMLElement>(collapsedItemRef, ref);
+ const collapsedSetRef = mergeRefs<HTMLElement>(
+ collapsedItemRef,
+ ref,
+ menu ? popover.triggerRef : undefined,
+ );
let collapsedElement: ReactNode;