Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(sandbox): add Y2K to theme dropdown; centralize theme registry (#2165)

rubyycheungd9c198e7f1d3
diff --git a/apps/sandbox/src/app/SandboxNav.tsx b/apps/sandbox/src/app/SandboxNav.tsx
index 1cd73063e9..e99fa5345f 100644
--- a/apps/sandbox/src/app/SandboxNav.tsx
+++ b/apps/sandbox/src/app/SandboxNav.tsx
@@ -6,7 +6,7 @@ import Link from 'next/link';
import {XDSSideNav, XDSSideNavItem, XDSSideNavSection} from '@xds/core/SideNav';
import {XDSDropdownMenu} from '@xds/core/DropdownMenu';
import {XDSText} from '@xds/core/Text';
-import {useThemeControls} from './providers';
+import {useThemeControls, SANDBOX_THEMES} from './providers';
import type {ThemeMode} from '@xds/core/theme';
import {categories} from './sandboxPages';
import {
@@ -52,16 +52,10 @@ const styles = stylex.create({
function SandboxHeader() {
const {setThemeName, mode, setMode} = useThemeControls();
- const themeItems = [
- {label: 'Default', onClick: () => setThemeName('default')},
- {label: 'Neutral', onClick: () => setThemeName('neutral')},
- {label: 'Brutalist', onClick: () => setThemeName('brutalist')},
- {label: 'Matcha', onClick: () => setThemeName('matcha')},
- {label: 'Daily', onClick: () => setThemeName('daily')},
- {label: 'Stone', onClick: () => setThemeName('stone')},
- {label: 'Gothic', onClick: () => setThemeName('gothic')},
- {label: 'Chocolate', onClick: () => setThemeName('chocolate')},
- ];
+ const themeItems = SANDBOX_THEMES.map(({id, label}) => ({
+ label,
+ onClick: () => setThemeName(id),
+ }));
const modeItems = [
{label: 'Light', onClick: () => setMode('light' as ThemeMode)},
diff --git a/apps/sandbox/src/app/providers.tsx b/apps/sandbox/src/app/providers.tsx
index d5a199bbaf..b5243098fa 100644
--- a/apps/sandbox/src/app/providers.tsx
+++ b/apps/sandbox/src/app/providers.tsx
@@ -14,17 +14,32 @@ import {chocolateTheme} from '@xds/theme-chocolate/built';
import {y2kTheme} from '@xds/theme-y2k/built';
import type {XDSDefinedTheme, ThemeMode} from '@xds/core/theme';
-const themes: Record<string, XDSDefinedTheme> = {
- default: defaultTheme,
- neutral: neutralTheme,
- brutalist: brutalistTheme,
- matcha: matchaTheme,
- daily: dailyTheme,
- stone: stoneTheme,
- gothic: gothicTheme,
- chocolate: chocolateTheme,
- y2k: y2kTheme,
-};
+/**
+ * Ordered list of available themes — single source of truth.
+ *
+ * Adding a new theme: add an entry here and the Theme dropdown in
+ * SandboxNav, the embed sync, the localStorage hydration, and any other
+ * theme-aware UI all pick it up automatically.
+ */
+export const SANDBOX_THEMES: ReadonlyArray<{
+ id: string;
+ label: string;
+ theme: XDSDefinedTheme;
+}> = [
+ {id: 'default', label: 'Default', theme: defaultTheme},
+ {id: 'neutral', label: 'Neutral', theme: neutralTheme},
+ {id: 'brutalist', label: 'Brutalist', theme: brutalistTheme},
+ {id: 'matcha', label: 'Matcha', theme: matchaTheme},
+ {id: 'daily', label: 'Daily', theme: dailyTheme},
+ {id: 'stone', label: 'Stone', theme: stoneTheme},
+ {id: 'gothic', label: 'Gothic', theme: gothicTheme},
+ {id: 'chocolate', label: 'Chocolate', theme: chocolateTheme},
+ {id: 'y2k', label: 'Y2K', theme: y2kTheme},
+];
+
+const themes: Record<string, XDSDefinedTheme> = Object.fromEntries(
+ SANDBOX_THEMES.map(t => [t.id, t.theme]),
+);
type ThemeContextValue = {
themeName: string;