Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(lint): enable no-console, consistent-type-assertions, and no-non-null-assertion (#2257)

Andrey Goderdcb6eb6c19ec
diff --git a/eslint.config.js b/eslint.config.js
index b47df03e02..58437c2037 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -62,6 +62,21 @@ export default tseslint.config(
destructuredArrayIgnorePattern: "^_",
caughtErrorsIgnorePattern: "^_",
}],
+ "no-console": ["warn", { allow: ["warn", "error"] }],
+ "@typescript-eslint/no-non-null-assertion": "warn",
+ "@typescript-eslint/consistent-type-assertions": ["warn", {
+ assertionStyle: "as",
+ objectLiteralTypeAssertions: "never",
+ }],
+ },
+ },
+ // Test files — relax rules for test ergonomics
+ {
+ files: ["**/*.test.{ts,tsx}", "**/*.perf.test.{ts,tsx}"],
+ rules: {
+ "no-console": "off",
+ "@typescript-eslint/no-non-null-assertion": "off",
+ "@typescript-eslint/consistent-type-assertions": "off",
},
},
// Copyright header — all source files must have the Meta copyright notice
diff --git a/packages/core/src/AppShell/XDSAppShell.tsx b/packages/core/src/AppShell/XDSAppShell.tsx
index e5cb365ce7..5ac2431ce2 100644
--- a/packages/core/src/AppShell/XDSAppShell.tsx
+++ b/packages/core/src/AppShell/XDSAppShell.tsx
@@ -492,9 +492,7 @@ export function XDSAppShell({
mobileNavDefaultIsMobile,
);
const [uncontrolledMobileOpen, setUncontrolledMobileOpen] = useState(false);
- const isMobileNavOpen = mobileNavIsControlled
- ? mobileNavConfig!.isOpen!
- : uncontrolledMobileOpen;
+ const isMobileNavOpen = mobileNavConfig?.isOpen ?? uncontrolledMobileOpen;
const setMobileNavOpen = useCallback(
(open: boolean) => {
diff --git a/packages/core/src/Carousel/XDSCarousel.tsx b/packages/core/src/Carousel/XDSCarousel.tsx
index 92a44dbab1..f96463a30e 100644
--- a/packages/core/src/Carousel/XDSCarousel.tsx
+++ b/packages/core/src/Carousel/XDSCarousel.tsx
@@ -168,6 +168,7 @@ const styles = stylex.create({
opacity: 0,
pointerEvents: 'none' as const,
},
+ // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- CSS custom property requires type widening for StyleX
buttonRadiusOverride: {
'--_button-radius': radiusVars['--radius-full'],
} as Record<string, string>,
@@ -263,6 +264,12 @@ export function XDSCarousel({
? styles.fadeEnd
: null;
+ const coverStyle: React.CSSProperties = {
+ positionArea: 'center',
+ width: 'anchor-size(width)',
+ height: 'anchor-size(height)',
+ };
+
return (
<div
ref={(el: HTMLDivElement | null) => {
@@ -333,12 +340,7 @@ export function XDSCarousel({
{
placement: 'below',
alignment: 'center',
- style: {
- // Override anchor positioning to cover the anchor instead of below it
- positionArea: 'center',
- width: 'anchor-size(width)',
- height: 'anchor-size(height)',
- } as React.CSSProperties,
+ style: coverStyle,
xstyle: styles.buttonOverlay,
},
)}
diff --git a/packages/core/src/Chat/XDSChatToolCalls.tsx b/packages/core/src/Chat/XDSChatToolCalls.tsx
index b9207ad654..34f515257e 100644
--- a/packages/core/src/Chat/XDSChatToolCalls.tsx
+++ b/packages/core/src/Chat/XDSChatToolCalls.tsx
@@ -368,7 +368,7 @@ function CallRow({call}: {call: XDSChatToolCallItem}) {
<span {...stylex.props(styles.statusIconCircle)} />
<span {...stylex.props(styles.statusIconInner)}>
<XDSIcon
- icon={STATUS_ICON_NAMES[status]!}
+ icon={STATUS_ICON_NAMES[status] ?? 'check'}
size="xsm"
color="inherit"
/>
@@ -548,7 +548,7 @@ export function XDSChatToolCalls(props: XDSChatToolCallsProps) {
<span {...stylex.props(styles.statusIconCircle)} />
<span {...stylex.props(styles.statusIconInner)}>
<XDSIcon
- icon={STATUS_ICON_NAMES[latestStatus]!}
+ icon={STATUS_ICON_NAMES[latestStatus] ?? 'check'}
size="xsm"
color="inherit"
/>
diff --git a/packages/core/src/CheckboxList/XDSCheckboxListItem.tsx b/packages/core/src/CheckboxList/XDSCheckboxListItem.tsx
index 5e1331a143..d4773b4fec 100644
--- a/packages/core/src/CheckboxList/XDSCheckboxListItem.tsx
+++ b/packages/core/src/CheckboxList/XDSCheckboxListItem.tsx
@@ -142,8 +142,8 @@ export function XDSCheckboxListItem({
// 2. Standalone mode (isChecked prop)
// 3. Neither → unchecked
let resolvedChecked: boolean | 'indeterminate' = false;
- if (ctx && ctx.value !== undefined) {
- resolvedChecked = ctx.value.includes(value!);
+ if (ctx && ctx.value !== undefined && value !== undefined) {
+ resolvedChecked = ctx.value.includes(value);
} else if (isChecked !== undefined) {
resolvedChecked = isChecked;
}
@@ -154,13 +154,13 @@ export function XDSCheckboxListItem({
const handleToggle = () => {
if (effectiveDisabled || effectiveReadOnly || isBusy) return;
- if (ctx && ctx.value !== undefined) {
+ if (ctx && ctx.value !== undefined && value !== undefined) {
// Collection mode
- const currentlyChecked = ctx.value.includes(value!);
+ const currentlyChecked = ctx.value.includes(value);
if (currentlyChecked) {
ctx.onChange?.(ctx.value.filter(v => v !== value));
} else {
- ctx.onChange?.([...ctx.value, value!]);
+ ctx.onChange?.([...ctx.value, value]);
}
} else {
// Standalone mode
diff --git a/packages/core/src/CodeBlock/highlightRanges.ts b/packages/core/src/CodeBlock/highlightRanges.ts
index 02d53cbea4..eddd6599ce 100644
--- a/packages/core/src/CodeBlock/highlightRanges.ts
+++ b/packages/core/src/CodeBlock/highlightRanges.ts
@@ -54,7 +54,8 @@ function ensureDynamicHighlightType(tokenType: string): void {
const style = document.createElement('style');
style.setAttribute('data-xds-highlight-dynamic', '');
document.head.appendChild(style);
- dynamicStyleSheet = style.sheet!;
+ dynamicStyleSheet = style.sheet ?? null;
+ if (!dynamicStyleSheet) return;
}
const name = `xds-${tokenType}`;
diff --git a/packages/core/src/Collapsible/useXDSCollapsible.ts b/packages/core/src/Collapsible/useXDSCollapsible.ts
index c1a716a49c..8647c5a76f 100644
--- a/packages/core/src/Collapsible/useXDSCollapsible.ts
+++ b/packages/core/src/Collapsible/useXDSCollapsible.ts
@@ -99,8 +99,8 @@ export function useXDSCollapsible(
// Determine open state from the appropriate source
let isOpen: boolean;
- if (isControlledByGroup) {
- isOpen = group.isOpen(value!);
+ if (isControlledByGroup && value != null) {
+ isOpen = group.isOpen(value);
} else if (config?.isOpen !== undefined) {
isOpen = config.isOpen;
} else {
@@ -109,8 +109,8 @@ export function useXDSCollapsible(
// Toggle handler dispatches to the appropriate controller
const toggle = () => {
- if (isControlledByGroup) {
- group.toggle(value!);
+ if (isControlledByGroup && value != null) {
+ group.toggle(value);
} else if (config?.onOpenChange) {
config.onOpenChange(!isOpen);
} else {
diff --git a/packages/core/src/CommandPalette/XDSCommandPalette.tsx b/packages/core/src/CommandPalette/XDSCommandPalette.tsx
index b63b1deec1..226d483c68 100644
--- a/packages/core/src/CommandPalette/XDSCommandPalette.tsx
+++ b/packages/core/src/CommandPalette/XDSCommandPalette.tsx
@@ -154,7 +154,7 @@ function buildSelectableItems(
groupOrder.push(group);
groups.set(group, []);
}
- groups.get(group)!.push(item);
+ groups.get(group)?.push(item);
} else {
ungrouped.push(item);
}
@@ -162,7 +162,7 @@ function buildSelectableItems(
const result: XDSSelectorOptionData[] = [];
for (const heading of groupOrder) {
- for (const item of groups.get(heading)!) {
+ for (const item of groups.get(heading) ?? []) {
result.push({value: item.id, label: item.label});
}
}
@@ -211,7 +211,7 @@ function ItemRenderer<T extends XDSSearchableItem>({
groupOrder.push(group);
groups.set(group, []);
}
- groups.get(group)!.push(item);
+ groups.get(group)?.push(item);
} else {
ungrouped.push(item);
}
@@ -221,7 +221,7 @@ function ItemRenderer<T extends XDSSearchableItem>({
<>
{groupOrder.map(heading => (
<XDSCommandPaletteGroup key={heading} heading={heading}>
- {groups.get(heading)!.map(renderOne)}
+ {(groups.get(heading) ?? []).map(renderOne)}
</XDSCommandPaletteGroup>
))}
{ungrouped.map(renderOne)}
diff --git a/packages/core/src/FileInput/XDSFileInput.tsx b/packages/core/src/FileInput/XDSFileInput.tsx
index a3a4d88052..554efce1c9 100644
--- a/packages/core/src/FileInput/XDSFileInput.tsx
+++ b/packages/core/src/FileInput/XDSFileInput.tsx
@@ -585,7 +585,7 @@ export function XDSFileInput({
const fileNames = hasFiles
? Array.isArray(value)
? value.map(f => f.name).join(', ')
- : value!.name
+ : (value?.name ?? '')
: null;
const renderDropzoneContent = () => {
diff --git a/packages/core/src/Layer/useXDSLayer.tsx b/packages/core/src/Layer/useXDSLayer.tsx
index 7ad9b086f3..42deeb082c 100644
--- a/packages/core/src/Layer/useXDSLayer.tsx
+++ b/packages/core/src/Layer/useXDSLayer.tsx
@@ -374,7 +374,7 @@ export function useXDSLayer(
positionAnchor: anchorId,
positionArea: getPositionArea(placement, alignment),
positionTryFallbacks: 'flip-block, flip-inline, flip-block flip-inline',
- } as React.CSSProperties;
+ };
const stylexResult = stylex.props(styles.base, xstyle);
const combinedClassName = extraClassName
diff --git a/packages/core/src/Markdown/XDSMarkdown.tsx b/packages/core/src/Markdown/XDSMarkdown.tsx
index 65ecbd2882..b58d5572b3 100644
--- a/packages/core/src/Markdown/XDSMarkdown.tsx
+++ b/packages/core/src/Markdown/XDSMarkdown.tsx
@@ -1009,6 +1009,11 @@ function renderBlock(
inlinePlugins?: MarkdownInlinePlugin[],
components?: Partial<XDSMarkdownComponents>,
): React.ReactNode {
+ const blockAlignMargin = BLOCK_ALIGN_MARGIN[contentAlign];
+ const blockAlignStyle =
+ blockAlignMargin != null
+ ? dynamicStyles.blockAlign(blockAlignMargin)
+ : null;
const spacing = getElementSpacing(node, density);
const isFirst = index === 0;
const isLast = index === blockCount - 1;
@@ -1125,9 +1130,7 @@ function renderBlock(
contentWidthValue != null
? dynamicStyles.blockWidth(contentWidthValue)
: undefined,
- BLOCK_ALIGN_MARGIN[contentAlign] != null
- ? dynamicStyles.blockAlign(BLOCK_ALIGN_MARGIN[contentAlign]!)
- : undefined,
+ blockAlignStyle,
]}
/>
</div>
@@ -1382,7 +1385,9 @@ function renderBlock(
? dynamicStyles.blockWidth(contentWidthValue)
: null,
BLOCK_ALIGN_MARGIN[contentAlign] != null
- ? dynamicStyles.blockAlign(BLOCK_ALIGN_MARGIN[contentAlign]!)
+ ? dynamicStyles.blockAlign(
+ BLOCK_ALIGN_MARGIN[contentAlign] as string,
+ )
: null,
isFirst && styles.noMarginBlockStart,
isLast && styles.noMarginBlockEnd,
diff --git a/packages/core/src/PowerSearch/PowerSearchEditPopover.tsx b/packages/core/src/PowerSearch/PowerSearchEditPopover.tsx
index 8530245f79..4538a99fdf 100644
--- a/packages/core/src/PowerSearch/PowerSearchEditPopover.tsx
+++ b/packages/core/src/PowerSearch/PowerSearchEditPopover.tsx
@@ -140,24 +140,24 @@ function isEditableFilterComplete(
function editableToCompleteFilter(
config: InternalConfig,
ef: EditablePartialFilter,
-): PowerSearchFilter {
- const op = config.getOperator(ef.field, ef.operator!);
+): PowerSearchFilter | null {
+ if (!ef.operator) return null;
+ const op = config.getOperator(ef.field, ef.operator);
if (op?.value.type === 'nested') {
+ const subs = (ef._subFilters ?? [])
+ .map(s => editableToCompleteFilter(config, s))
+ .filter((s): s is PowerSearchFilter => s != null);
return {
field: ef.field,
- operator: ef.operator!,
- value: {
- type: 'nested',
- value: (ef._subFilters ?? []).map(s =>
- editableToCompleteFilter(config, s),
- ),
- },
+ operator: ef.operator,
+ value: {type: 'nested', value: subs},
};
}
+ if (ef.value == null) return null;
return {
field: ef.field,
- operator: ef.operator!,
- value: ef.value!,
+ operator: ef.operator,
+ value: ef.value,
};
}
@@ -377,9 +377,9 @@ function NestedEditor({
...partialFilter,
value: {
type: 'nested',
- value: newSubFilters.map(sf =>
- editableToCompleteFilter(config, sf),
- ),
+ value: newSubFilters
+ .map(sf => editableToCompleteFilter(config, sf))
+ .filter((sf): sf is PowerSearchFilter => sf != null),
},
});
} else {
diff --git a/packages/core/src/SideNav/XDSSideNavHeading.tsx b/packages/core/src/SideNav/XDSSideNavHeading.tsx
index e6bcff36a7..ce7688c8c4 100644
--- a/packages/core/src/SideNav/XDSSideNavHeading.tsx
+++ b/packages/core/src/SideNav/XDSSideNavHeading.tsx
@@ -604,11 +604,11 @@ export function XDSSideNavHeading({
);
// Whole heading is a link (no menu, single headingHref)
- if (isWholeHeadingLink) {
+ if (isWholeHeadingLink && headingHref) {
return (
<LinkComponent
ref={ref as React.Ref<HTMLAnchorElement>}
- href={headingHref!}
+ href={headingHref}
data-testid={testId}
{...mergeProps(
xdsClassName('side-nav-heading'),
diff --git a/packages/core/src/Table/XDSBaseTable.tsx b/packages/core/src/Table/XDSBaseTable.tsx
index ef8a72ebca..ab2d9c34fc 100644
--- a/packages/core/src/Table/XDSBaseTable.tsx
+++ b/packages/core/src/Table/XDSBaseTable.tsx
@@ -153,7 +153,10 @@ function TableRowInner<T extends Record<string, unknown>>({
const cellRenderProps = applyPlugins(
plugins,
p => p.transformBodyCell,
- {htmlProps: initialCellHtmlProps, styles: []} as BodyCellRenderProps,
+ {
+ htmlProps: initialCellHtmlProps,
+ styles: [],
+ } satisfies BodyCellRenderProps,
col,
item,
);
@@ -161,7 +164,7 @@ function TableRowInner<T extends Record<string, unknown>>({
const isDefaultRenderer = !col.renderCell;
const rawContent = isDefaultRenderer
? defaultCellRenderer(item, col.key)
- : col.renderCell!(item);
+ : (col.renderCell?.(item) ?? null);
// In truncate mode, wrap default-rendered string content in
// <XDSText maxLines={1}> for smart tooltips that only appear
@@ -197,7 +200,11 @@ function TableRowInner<T extends Record<string, unknown>>({
const rowRenderProps = applyPlugins(
plugins,
p => p.transformBodyRow,
- {htmlProps: {}, styles: [], children: <>{cells}</>} as BodyRowRenderProps,
+ {
+ htmlProps: {},
+ styles: [],
+ children: <>{cells}</>,
+ } satisfies BodyRowRenderProps,
item,
rowIndex,
);
@@ -279,9 +286,12 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
// Use stable empty array when no plugins provided
const plugins = pluginsProp ?? (EMPTY_PLUGINS as TablePlugin<T>[]);
- const RowComponent = XDSTableRow as React.ComponentType<TableRowComponentProps>;
- const CellComponent = XDSTableCell as React.ComponentType<TableCellComponentProps>;
- const HeaderCellComponent = XDSTableHeaderCell as React.ComponentType<TableHeaderCellComponentProps>;
+ const RowComponent =
+ XDSTableRow as React.ComponentType<TableRowComponentProps>;
+ const CellComponent =
+ XDSTableCell as React.ComponentType<TableCellComponentProps>;
+ const HeaderCellComponent =
+ XDSTableHeaderCell as React.ComponentType<TableHeaderCellComponentProps>;
// Resolve columns: explicit > auto-generated from data.
const baseColumns: XDSTableColumn<T>[] =
@@ -314,7 +324,7 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
const tableRenderProps = applyPlugins(plugins, p => p.transformTable, {
htmlProps: {...userTableProps},
styles: children ? [styles.table, styles.tableAutoLayout] : [styles.table],
- } as TableRenderProps);
+ } satisfies TableRenderProps);
// --- Plugin pipeline: header cells ---
const headerCells = resolvedColumns.map(col => {
@@ -335,7 +345,7 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
htmlProps: initialHeaderHtmlProps,
styles: [],
content: headerContent,
- } as HeaderCellRenderProps,
+ } satisfies HeaderCellRenderProps,
col,
);
@@ -397,7 +407,7 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
htmlProps: {},
styles: [],
children: <>{headerCells}</>,
- } as HeaderRowRenderProps,
+ } satisfies HeaderRowRenderProps,
);
// --- Render ---
@@ -424,29 +434,55 @@ function XDSBaseTableInner<T extends Record<string, unknown>>({
stylex.props(...tableRenderProps.styles),
)}
style={tableStyle}>
- {children
- ? children
- : (
- <>
- {hasColumns && (
- <XDSTableHeader>
- <RowComponent {...headerRowRenderProps.htmlProps} xstyle={headerRowRenderProps.styles}>
- {headerRowRenderProps.children}
- </RowComponent>
- </XDSTableHeader>
- )}
- <XDSTableBody>
- {hasData
- ? data.map((item, rowIndex) => {
- const rowKey = idKey == null ? rowIndex : typeof idKey === 'function' ? idKey(item) : String(item[idKey]);
- return (<MemoizedTableRow<T> key={rowKey} item={item} rowIndex={rowIndex} rowKey={rowKey} columns={resolvedColumns} plugins={plugins} textOverflow={textOverflow} RowComponent={RowComponent} CellComponent={CellComponent} />);
- })
- : data != null && emptyState !== false && (
- <tr><td colSpan={resolvedColumns.length}>{emptyState ?? <XDSEmptyState title="No data" isCompact />}</td></tr>
- )}
- </XDSTableBody>
- </>
- )}
+ {children ? (
+ children
+ ) : (
+ <>
+ {hasColumns && (
+ <XDSTableHeader>
+ <RowComponent
+ {...headerRowRenderProps.htmlProps}
+ xstyle={headerRowRenderProps.styles}>
+ {headerRowRenderProps.children}
+ </RowComponent>
+ </XDSTableHeader>
+ )}
+ <XDSTableBody>
+ {hasData
+ ? data.map((item, rowIndex) => {
+ const rowKey =
+ idKey == null
+ ? rowIndex
+ : typeof idKey === 'function'
+ ? idKey(item)
+ : String(item[idKey]);
+ return (
+ <MemoizedTableRow<T>
+ key={rowKey}
+ item={item}
+ rowIndex={rowIndex}
+ rowKey={rowKey}
+ columns={resolvedColumns}
+ plugins={plugins}
+ textOverflow={textOverflow}
+ RowComponent={RowComponent}
+ CellComponent={CellComponent}
+ />
+ );
+ })
+ : data != null &&
+ emptyState !== false && (
+ <tr>
+ <td colSpan={resolvedColumns.length}>
+ {emptyState ?? (
+ <XDSEmptyState title="No data" isCompact />
+ )}
+ </td>
+ </tr>
+ )}
+ </XDSTableBody>
+ </>
+ )}
</table>
);
diff --git a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
index b289a3e82b..7ece6e2517 100644
--- a/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
+++ b/packages/core/src/Table/plugins/filtering/useXDSTableFiltering.tsx
@@ -314,6 +314,15 @@ interface FilterStore {
const FilterStoreContext = createContext<FilterStore | null>(null);
FilterStoreContext.displayName = 'FilterStoreContext';
+function useFilterStore(): FilterStore {
+ const store = use(FilterStoreContext);
+ if (!store)
+ throw new Error(
+ 'useFilterStore must be used within a Table with filtering',
+ );
+ return store;
+}
+
/** Variant is stable per plugin instance — kept in a separate context so
* slot components can read it without going through the mutable store. */
const FilterVariantContext = createContext<XDSTableFilterVariant>('popover');
@@ -396,7 +405,7 @@ function TextFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const config = store.getConfig();
const value = config.filters[columnKey];
const strValue = typeof value === 'string' ? value : '';
@@ -431,7 +440,7 @@ function NumberFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const config = store.getConfig();
const value = config.filters[columnKey];
const numValue = typeof value === 'number' ? value : null;
@@ -490,7 +499,7 @@ function SelectorFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const config = store.getConfig();
const value = config.filters[columnKey];
const strValue = typeof value === 'string' ? value : '';
@@ -553,7 +562,7 @@ function MultiSelectorFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const config = store.getConfig();
const value = config.filters[columnKey];
const arrValue = Array.isArray(value) ? value : [];
@@ -594,7 +603,7 @@ function DateFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const value = store.getConfig().filters[columnKey] as string | undefined;
return (
@@ -622,7 +631,7 @@ function TimeFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const value = store.getConfig().filters[columnKey] as string | undefined;
return (
@@ -652,7 +661,7 @@ function StringListFilterControl({
size: 'sm' | 'md';
hasClear?: boolean;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const value =
(store.getConfig().filters[columnKey] as string[] | undefined) ?? [];
@@ -789,7 +798,7 @@ function PopoverFilterTrigger({
header: string;
operatorValue: OperatorValue;
}) {
- const store = use(FilterStoreContext)!;
+ const store = useFilterStore();
const config = store.getConfig();
const value = config.filters[columnKey];
const hasValue = value != null;
diff --git a/packages/core/src/Table/plugins/sortable/useXDSTableSortable.tsx b/packages/core/src/Table/plugins/sortable/useXDSTableSortable.tsx
index 54b510453a..7ffaa52955 100644
--- a/packages/core/src/Table/plugins/sortable/useXDSTableSortable.tsx
+++ b/packages/core/src/Table/plugins/sortable/useXDSTableSortable.tsx
@@ -215,7 +215,7 @@ function SortHeaderButton<T extends Record<string, unknown>>({
configRef: React.RefObject<UseXDSTableSortableConfig>;
}) {
const config = configRef.current;
- const sortKey = resolveSortKey(column)!;
+ const sortKey = resolveSortKey(column) ?? '';
const entryIndex = config.sort.findIndex(e => e.sortKey === sortKey);
const entry = entryIndex >= 0 ? config.sort[entryIndex] : null;
const direction = entry?.direction ?? null;
diff --git a/packages/core/src/Thumbnail/XDSThumbnail.tsx b/packages/core/src/Thumbnail/XDSThumbnail.tsx
index 5c209cf568..2ca5354194 100644
--- a/packages/core/src/Thumbnail/XDSThumbnail.tsx
+++ b/packages/core/src/Thumbnail/XDSThumbnail.tsx
@@ -171,6 +171,7 @@ const styles = stylex.create({
borderRadius: radiusVars['--radius-element'],
overflow: 'hidden',
},
+ // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- CSS custom property requires type widening for StyleX
removeButtonOverrides: {
position: 'absolute',
top: spacingVars['--spacing-1'],
diff --git a/packages/core/src/Toast/useXDSToast.tsx b/packages/core/src/Toast/useXDSToast.tsx
index 53ff9f55f9..500ba67041 100644
--- a/packages/core/src/Toast/useXDSToast.tsx
+++ b/packages/core/src/Toast/useXDSToast.tsx
@@ -40,7 +40,7 @@ function getFallbackContext(): XDSToastContextValue {
container.setAttribute('data-xds-toast-fallback', '');
document.body.appendChild(container);
- let resolveCtx: (ctx: XDSToastContextValue) => void;
+ let resolveCtx: ((ctx: XDSToastContextValue) => void) | undefined;
const ctxReady = new Promise<XDSToastContextValue>(r => {
resolveCtx = r;
});
@@ -52,7 +52,7 @@ function getFallbackContext(): XDSToastContextValue {
if (ctx && !doneRef.current) {
doneRef.current = true;
fallbackContext = ctx;
- resolveCtx!(ctx);
+ resolveCtx?.(ctx);
}
}, [ctx]);
return null;
diff --git a/packages/core/src/Tokenizer/XDSTokenizer.tsx b/packages/core/src/Tokenizer/XDSTokenizer.tsx
index 494cb77c39..23c666ee68 100644
--- a/packages/core/src/Tokenizer/XDSTokenizer.tsx
+++ b/packages/core/src/Tokenizer/XDSTokenizer.tsx
@@ -528,7 +528,8 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
) {
const createdValue = item.id.slice(CREATABLE_ID_PREFIX.length);
if (selectedIds.has(createdValue)) return;
- const realItem = {id: createdValue, label: createdValue} as T;
+ const base = {id: createdValue, label: createdValue};
+ const realItem = base as T;
const newItems = [...value, realItem];
onChange(newItems, {item: realItem, type: 'create'});
return;
@@ -626,6 +627,13 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
);
});
+ const popoverOverrideStyle: React.CSSProperties = {
+ positionArea: undefined,
+ positionTryFallbacks: undefined,
+ top: 'anchor(top)',
+ left: 'anchor(start)',
+ };
+
const wrapperContent = (
<div
ref={wrapperRef}
@@ -769,12 +777,7 @@ export function XDSTokenizer<T extends XDSSearchableItem>({
placement: 'below',
alignment: 'start',
xstyle: styles.layerPopover,
- style: {
- positionArea: undefined,
- positionTryFallbacks: undefined,
- top: 'anchor(top)',
- left: 'anchor(start)',
- } as React.CSSProperties,
+ style: popoverOverrideStyle,
},
)}
</>
diff --git a/packages/core/src/TopNav/XDSTopNavHeading.tsx b/packages/core/src/TopNav/XDSTopNavHeading.tsx
index 234a47e77e..c0fe7bc19e 100644
--- a/packages/core/src/TopNav/XDSTopNavHeading.tsx
+++ b/packages/core/src/TopNav/XDSTopNavHeading.tsx
@@ -466,11 +466,11 @@ export function XDSTopNavHeading({
}
// Whole heading is a link (no menu, single headingHref)
- if (isWholeHeadingLink) {
+ if (isWholeHeadingLink && headingHref) {
return (
<LinkComponent
ref={ref as React.Ref<HTMLAnchorElement>}
- href={headingHref!}
+ href={headingHref}
data-testid={testId}
{...mergeProps(
xdsClassName('top-nav-heading'),
diff --git a/packages/core/src/TreeList/XDSTreeList.tsx b/packages/core/src/TreeList/XDSTreeList.tsx
index baf956089d..905ce0a3e5 100644
--- a/packages/core/src/TreeList/XDSTreeList.tsx
+++ b/packages/core/src/TreeList/XDSTreeList.tsx
@@ -150,7 +150,7 @@ export function XDSTreeList({
setExpandedKeysOverride(prev => {
const next = new Map(prev);
const isCurrentlyExpanded = prev.has(id)
- ? prev.get(id)!
+ ? (prev.get(id) ?? false)
: expandedKeysFromProps.has(id);
next.set(id, !isCurrentlyExpanded);
return next;
@@ -167,7 +167,7 @@ export function XDSTreeList({
return items.map((item, index) => {
const isLast = index === items.length - 1;
const isExpanded = expandedKeysOverride.has(item.id)
- ? expandedKeysOverride.get(item.id)!
+ ? (expandedKeysOverride.get(item.id) ?? false)
: expandedKeysFromProps.has(item.id);
const hasChildren = item.children != null && item.children.length > 0;
@@ -178,7 +178,7 @@ export function XDSTreeList({
const renderedChildren =
isExpanded && hasChildren
? renderItems(
- item.children!,
+ item.children ?? [],
nestedLevel + 1,
ancestorsIsLastForChildren,
)
diff --git a/packages/core/src/hooks/useImageMode.ts b/packages/core/src/hooks/useImageMode.ts
index 0d27fe7a05..cd2f3221b2 100644
--- a/packages/core/src/hooks/useImageMode.ts
+++ b/packages/core/src/hooks/useImageMode.ts
@@ -110,12 +110,13 @@ export function useImageMode(
return;
}
+ const srcUrl = src;
let cancelled = false;
async function detect() {
try {
// Load image as bitmap (async, doesn't block rendering)
- const response = await fetch(src!, {mode: 'cors'});
+ const response = await fetch(srcUrl, {mode: 'cors'});
const blob = await response.blob();
const bitmap = await createImageBitmap(blob);
diff --git a/packages/core/src/theme/defineTheme.ts b/packages/core/src/theme/defineTheme.ts
index 0691ff702c..fb4f0f9f49 100644
--- a/packages/core/src/theme/defineTheme.ts
+++ b/packages/core/src/theme/defineTheme.ts
@@ -750,7 +750,7 @@ function expandContainerPadding(
parsed.blockStart === parsed.blockEnd;
if (allSame) {
- tokens.push([prefix, effectiveInlineStart!]);
+ tokens.push([prefix, effectiveInlineStart ?? '']);
return tokens;
}
diff --git a/packages/core/src/theme/syntax/XDSSyntaxTheme.tsx b/packages/core/src/theme/syntax/XDSSyntaxTheme.tsx
index 185f9d11be..387c87fe25 100644
--- a/packages/core/src/theme/syntax/XDSSyntaxTheme.tsx
+++ b/packages/core/src/theme/syntax/XDSSyntaxTheme.tsx
@@ -77,14 +77,14 @@ export function useXDSSyntaxTheme(): UseXDSSyntaxThemeReturn | null {
const tokens = useMemo(() => {
if (!ctx) return null;
- const resolved = {} as Record<SyntaxThemeTokenKey, string>;
+ const resolved: Partial<Record<SyntaxThemeTokenKey, string>> = {};
for (const key of ALL_SYNTAX_KEYS) {
resolved[key] = resolveSyntaxTokenForMode(
ctx.theme.__inputTokens[key],
effectiveMode,
);
}
- return resolved;
+ return resolved as Record<SyntaxThemeTokenKey, string>;
}, [ctx, effectiveMode]);
if (!ctx || !tokens) return null;
diff --git a/packages/core/src/theme/syntax/defineSyntaxTheme.ts b/packages/core/src/theme/syntax/defineSyntaxTheme.ts
index 4e448c2a6e..d1c15d16ad 100644
--- a/packages/core/src/theme/syntax/defineSyntaxTheme.ts
+++ b/packages/core/src/theme/syntax/defineSyntaxTheme.ts
@@ -140,14 +140,14 @@ export function defineSyntaxTheme(input: SyntaxThemeInput): SyntaxTheme {
}
// Resolve tuples to light-dark() CSS strings
- const resolved: SyntaxThemeTokenMap = {} as SyntaxThemeTokenMap;
+ const resolved: Partial<SyntaxThemeTokenMap> = {};
for (const key of ALL_SYNTAX_KEYS) {
resolved[key] = resolveTokenValue(input.tokens[key]);
}
return {
name: input.name,
- tokens: resolved,
+ tokens: resolved as SyntaxThemeTokenMap,
__inputTokens: {...input.tokens},
};
}
diff --git a/packages/core/src/utils/groupItems.ts b/packages/core/src/utils/groupItems.ts
index 07f4ea08eb..40f4a4d1b0 100644
--- a/packages/core/src/utils/groupItems.ts
+++ b/packages/core/src/utils/groupItems.ts
@@ -70,7 +70,7 @@ export function groupItems<T extends XDSSearchableItem>(
groupOrder.push(group);
groups.set(group, []);
}
- groups.get(group)!.push(item);
+ groups.get(group)?.push(item);
} else {
ungrouped.push(item);
}
@@ -78,7 +78,7 @@ export function groupItems<T extends XDSSearchableItem>(
const result: ItemGroup<T>[] = groupOrder.map(heading => ({
heading,
- items: groups.get(heading)!,
+ items: groups.get(heading) ?? [],
}));
if (ungrouped.length > 0) {
diff --git a/packages/core/src/utils/sharedResizeObserver.test.ts b/packages/core/src/utils/sharedResizeObserver.test.ts
index a41d02d388..a4b5d4ca01 100644
--- a/packages/core/src/utils/sharedResizeObserver.test.ts
+++ b/packages/core/src/utils/sharedResizeObserver.test.ts
@@ -31,9 +31,8 @@ describe('sharedResizeObserver', () => {
});
it('creates a single ResizeObserver for multiple elements', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el1 = document.createElement('div');
const el2 = document.createElement('div');
@@ -51,9 +50,8 @@ describe('sharedResizeObserver', () => {
});
it('fires callback synchronously on registration', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el = document.createElement('div');
const cb = vi.fn();
@@ -62,17 +60,14 @@ describe('sharedResizeObserver', () => {
// Callback should have fired once immediately with a synthetic entry
expect(cb).toHaveBeenCalledTimes(1);
- expect(cb).toHaveBeenCalledWith(
- expect.objectContaining({target: el}),
- );
+ expect(cb).toHaveBeenCalledWith(expect.objectContaining({target: el}));
unobserveResize(el);
});
it('dispatches resize entries to the correct callbacks', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el1 = document.createElement('div');
const el2 = document.createElement('div');
@@ -108,9 +103,8 @@ describe('sharedResizeObserver', () => {
});
it('destroys the observer when the last element is unobserved', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el1 = document.createElement('div');
const el2 = document.createElement('div');
@@ -126,9 +120,8 @@ describe('sharedResizeObserver', () => {
});
it('recreates observer after full teardown', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el1 = document.createElement('div');
observeResize(el1, vi.fn());
@@ -143,9 +136,8 @@ describe('sharedResizeObserver', () => {
});
it('replaces callback when same element is observed twice', async () => {
- const {observeResize, unobserveResize} = await import(
- './sharedResizeObserver'
- );
+ const {observeResize, unobserveResize} =
+ await import('./sharedResizeObserver');
const el = document.createElement('div');
const cb1 = vi.fn();
diff --git a/packages/core/src/utils/sharedResizeObserver.ts b/packages/core/src/utils/sharedResizeObserver.ts
index 068b5d563a..2842e5ffc7 100644
--- a/packages/core/src/utils/sharedResizeObserver.ts
+++ b/packages/core/src/utils/sharedResizeObserver.ts
@@ -66,7 +66,8 @@ export function observeResize(
// Fire once immediately so callers get an initial measurement
// without duplicating their logic outside the observer path.
- callback({target: element} as ResizeObserverEntry);
+ const entry: Partial<ResizeObserverEntry> = {target: element};
+ callback(entry as ResizeObserverEntry);
}
/**
diff --git a/packages/core/src/utils/timeParser.ts b/packages/core/src/utils/timeParser.ts
index 3931db2949..82cd797d45 100644
--- a/packages/core/src/utils/timeParser.ts
+++ b/packages/core/src/utils/timeParser.ts
@@ -280,10 +280,12 @@ export function clampTime(
if (!parsed) return time;
if (min && compareTime(time, min) < 0) {
- return formatISOTime(parseISOTime(min)!, includeSeconds);
+ const parsedMin = parseISOTime(min);
+ if (parsedMin) return formatISOTime(parsedMin, includeSeconds);
}
if (max && compareTime(time, max) > 0) {
- return formatISOTime(parseISOTime(max)!, includeSeconds);
+ const parsedMax = parseISOTime(max);
+ if (parsedMax) return formatISOTime(parsedMax, includeSeconds);
}
return time;