An open source design system that's fully customizable and agent ready
TypeScript
refactor(core): consolidate inline visually-hidden styles into VisuallyHidden primitive (#3491)
Cindy Zhangdd00d23f45ac
diff --git a/.changeset/consolidate-visually-hidden.md b/.changeset/consolidate-visually-hidden.mdnew file mode 100644index 0000000000..2f26a830b3--- /dev/null+++ b/.changeset/consolidate-visually-hidden.md@@ -0,0 +1,6 @@+---+'@astryxdesign/core': patch+---++[refactor] Consolidated 5 inline visually-hidden style blocks into the shared VisuallyHidden primitive (Button, Link, ProgressBar, Switch, TextArea); no behavior change.+@cixzhangdiff --git a/packages/core/src/Button/Button.tsx b/packages/core/src/Button/Button.tsxindex 70874bb5c7..4ba90d9218 100644--- a/packages/core/src/Button/Button.tsx+++ b/packages/core/src/Button/Button.tsx@@ -34,6 +34,7 @@ import {} from '../theme/tokens.stylex';import {Tooltip} from '../Tooltip/Tooltip';import {Spinner} from '../Spinner';+import {VisuallyHidden} from '../VisuallyHidden';import {EDGE_COMP_ATTR} from '../Layout/edgeCompensation.stylex';import {useSize} from '../SizeContext/SizeContext';@@ -124,17 +125,6 @@ const styles = stylex.create({textOverflow: 'ellipsis',minWidth: 0,},- visuallyHidden: {- position: 'absolute',- width: '1px',- height: '1px',- padding: 0,- margin: '-1px',- overflow: 'hidden',- clip: 'rect(0, 0, 0, 0)',- whiteSpace: 'nowrap',- borderWidth: 0,- },link: {textDecoration: 'none',},@@ -690,12 +680,9 @@ export function Button({)}</span>{/* Live region for loading state announcements */}- <span- {...stylex.props(styles.visuallyHidden)}- role="status"- aria-live="polite">+ <VisuallyHidden role="status" aria-live="polite">{isLoadingState ? 'Loading' : ''}- </span>+ </VisuallyHidden></>);diff --git a/packages/core/src/Link/Link.tsx b/packages/core/src/Link/Link.tsxindex e3a1f30eca..6ff2719813 100644--- a/packages/core/src/Link/Link.tsx+++ b/packages/core/src/Link/Link.tsx@@ -30,6 +30,7 @@ import {import {Icon} from '../Icon';import {Tooltip} from '../Tooltip';import {Text} from '../Text';+import {VisuallyHidden} from '../VisuallyHidden';import type {TextType,TextSize,@@ -98,18 +99,6 @@ const styles = stylex.create({fontSize: typeScaleVars['--text-body-size'],lineHeight: typeScaleVars['--text-body-leading'],},- // Screen-reader-only text (announces the new-tab context change).- visuallyHidden: {- position: 'absolute',- width: 1,- height: 1,- margin: -1,- padding: 0,- overflow: 'hidden',- clip: 'rect(0, 0, 0, 0)',- whiteSpace: 'nowrap',- borderStyle: 'none',- },});/**@@ -345,7 +334,7 @@ export function Link({{isExternalLink && !renderAsButton && (<><Icon icon="externalLink" size="xsm" color="inherit" />- <span {...stylex.props(styles.visuallyHidden)}>{newTabLabel}</span>+ <VisuallyHidden>{newTabLabel}</VisuallyHidden></>)}</>diff --git a/packages/core/src/ProgressBar/ProgressBar.tsx b/packages/core/src/ProgressBar/ProgressBar.tsxindex 179dc4a57d..cd2a8ac350 100644--- a/packages/core/src/ProgressBar/ProgressBar.tsx+++ b/packages/core/src/ProgressBar/ProgressBar.tsx@@ -31,6 +31,7 @@ import {import {mergeProps} from '../utils';import type {BaseProps} from '../BaseProps';import {themeProps} from '../utils/themeProps';+import {VisuallyHidden} from '../VisuallyHidden';/*** Extensible variant map for ProgressBar.@@ -313,9 +314,7 @@ export function ProgressBar({)}</div>) : (- <span id={labelId} {...stylex.props(styles.visuallyHidden)}>- {label}- </span>+ <VisuallyHidden id={labelId}>{label}</VisuallyHidden>)}{/* Progress track */}diff --git a/packages/core/src/Switch/Switch.tsx b/packages/core/src/Switch/Switch.tsxindex 649ac2969e..d3668055ea 100644--- a/packages/core/src/Switch/Switch.tsx+++ b/packages/core/src/Switch/Switch.tsx@@ -44,6 +44,7 @@ import {switchScope} from './switch.markers.stylex';import type {BaseProps} from '../BaseProps';import type {SizeValue} from '../utils/types';import {themeProps} from '../utils/themeProps';+import {VisuallyHidden} from '../VisuallyHidden';// Fixed dimensions: 40px width, 24px height, 16px thumb (off), 20px thumb (on)const SWITCH_WIDTH = 40;@@ -179,17 +180,6 @@ const styles = stylex.create({fontSize: typeScaleVars['--text-supporting-size'],color: colorVars['--color-text-secondary'],},- srOnly: {- position: 'absolute',- width: 1,- height: 1,- padding: 0,- margin: -1,- overflow: 'hidden',- clip: 'rect(0, 0, 0, 0)',- whiteSpace: 'nowrap',- borderWidth: 0,- },});export type SwitchLabelPosition = 'start' | 'end';@@ -416,11 +406,7 @@ export function Switch({{isBusy && <Spinner size="sm" />}</div></div>- {isBusy && (- <span {...stylex.props(styles.srOnly)} role="status">- Loading- </span>- )}+ {isBusy && <VisuallyHidden role="status">Loading</VisuallyHidden>}</div>);diff --git a/packages/core/src/TextArea/TextArea.tsx b/packages/core/src/TextArea/TextArea.tsxindex 689740095c..7605635ce6 100644--- a/packages/core/src/TextArea/TextArea.tsx+++ b/packages/core/src/TextArea/TextArea.tsx@@ -49,6 +49,7 @@ import type {SizeValue} from '../utils/types';import {useInputContainer} from '../hooks/useInputContainer';import {useSize} from '../SizeContext/SizeContext';import {themeProps} from '../utils/themeProps';+import {VisuallyHidden} from '../VisuallyHidden';const COUNTER_WARNING_THRESHOLD = 0.8;@@ -93,17 +94,6 @@ const styles = stylex.create({counterError: {color: colorVars['--color-error'],},- srOnly: {- position: 'absolute',- width: '1px',- height: '1px',- padding: 0,- margin: '-1px',- overflow: 'hidden',- clip: 'rect(0,0,0,0)',- whiteSpace: 'nowrap',- borderWidth: 0,- },statusIcon: {position: 'absolute',top: spacingVars['--spacing-2'],@@ -451,13 +441,13 @@ export function TextArea({optimisticValue.length > maxLength && styles.counterError,)}>{optimisticValue.length}/{maxLength}- <span aria-live="polite" {...stylex.props(styles.srOnly)}>+ <VisuallyHidden aria-live="polite">{optimisticValue.length >= maxLength * COUNTER_WARNING_THRESHOLD? optimisticValue.length > maxLength? `${optimisticValue.length - maxLength} characters over limit`: `${maxLength - optimisticValue.length} characters remaining`: ''}- </span>+ </VisuallyHidden></div>)}</Field>