Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(DropdownMenu): use elevation token and add xdsClassName (#670)

Cindy Zhangdf145c1e25d6
diff --git a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
index 9be61cb8a8..3df3c157cb 100644
--- a/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
+++ b/packages/core/src/DropdownMenu/XDSDropdownMenu.tsx
@@ -31,12 +31,14 @@ import {XDSDivider} from '../Divider';
import {XDSDropdownMenuItem} from './XDSDropdownMenuItem';
import {
colorVars,
+ elevationVars,
spacingVars,
radiusVars,
transitionVars,
typographyVars,
textSizeVars,
} from '../theme/tokens.stylex';
+import {xdsClassName, mergeProps} from '../utils';
const styles = stylex.create({
// Dropdown container
@@ -47,7 +49,7 @@ const styles = stylex.create({
padding: spacingVars['--spacing-1'],
borderRadius: radiusVars['--radius-element'],
backgroundColor: colorVars['--color-surface'],
- boxShadow: `0 4px 12px ${colorVars['--color-shadow-elevation']}`,
+ boxShadow: elevationVars['--elevation-menu'],
opacity: 1,
transition: `opacity ${transitionVars['--transition-fast']}`,
},
@@ -593,7 +595,13 @@ export function XDSDropdownMenu({
</XDSButton>
{layer.render(
- <div id={menuId} role="menu" {...stylex.props(styles.dropdown)}>
+ <div
+ id={menuId}
+ role="menu"
+ {...mergeProps(
+ xdsClassName('dropdown-menu'),
+ stylex.props(styles.dropdown),
+ )}>
{renderOptions()}
</div>,
{