An open source design system that's fully customizable and agent ready
TypeScript
fix(core): TopNavMenu and TopNavMegaMenu forward ref to the drawer trigger (#8897)
Parinithe203bb2269af
diff --git a/.changeset/top-nav-drawer-trigger-ref.md b/.changeset/top-nav-drawer-trigger-ref.mdnew file mode 100644index 0000000000..676de889a9--- /dev/null+++ b/.changeset/top-nav-drawer-trigger-ref.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] `TopNavMenu` and `TopNavMegaMenu` now forward their `ref` to the trigger button in drawer mode (`architecture:public-component-api` INV8). Before, only the desktop popover trigger received the ref, so a caller's ref stayed empty whenever the menu rendered inside the mobile drawer. Apps need no code change; the desktop trigger and every other prop are unchanged.++@parinith-webdiff --git a/packages/core/src/TopNav/TopNavMegaMenu.test.tsx b/packages/core/src/TopNav/TopNavMegaMenu.test.tsxindex 115d384c67..8aa951f261 100644--- a/packages/core/src/TopNav/TopNavMegaMenu.test.tsx+++ b/packages/core/src/TopNav/TopNavMegaMenu.test.tsx@@ -9,6 +9,7 @@* SYNC: When TopNavMegaMenu changes, update tests to match new behavior*/+import {createRef} from 'react';import * as stylex from '@stylexjs/stylex';import {focusOutlineStyles} from '../utils/focusOutline.stylex';import {describe, it, expect, vi, beforeAll, afterAll, afterEach} from 'vitest';@@ -1130,3 +1131,23 @@ describe('TopNavMegaMenuItem pass-through props', () => {);});});++describe('TopNavMegaMenu ref', () => {+ const items = <TopNavMegaMenuItem title="Analytics" href="/analytics" />;++ it('forwards its ref to the trigger button', () => {+ const ref = createRef<HTMLButtonElement>();+ render(<TopNavMegaMenu ref={ref} label="Products" items={items} />);+ expect(ref.current).toBe(screen.getByRole('button', {name: 'Products'}));+ });++ it('forwards its ref to the drawer trigger', () => {+ const ref = createRef<HTMLButtonElement>();+ render(+ <TopNavRenderContext value="drawer">+ <TopNavMegaMenu ref={ref} label="Products" items={items} />+ </TopNavRenderContext>,+ );+ expect(ref.current).toBe(screen.getByRole('button', {name: /Products/}));+ });+});diff --git a/packages/core/src/TopNav/TopNavMegaMenu.tsx b/packages/core/src/TopNav/TopNavMegaMenu.tsxindex 5e0eb64ed3..b760383550 100644--- a/packages/core/src/TopNav/TopNavMegaMenu.tsx+++ b/packages/core/src/TopNav/TopNavMegaMenu.tsx@@ -378,6 +378,7 @@ export function TopNavMegaMenu({if (renderMode === 'drawer') {return (<DrawerMegaMenu+ ref={ref}label={label}items={items}featured={featured}@@ -564,6 +565,7 @@ function DefaultMegaMenu({// =============================================================================function DrawerMegaMenu({+ ref,label,items,featured,@@ -572,7 +574,7 @@ function DrawerMegaMenu({style,onClick: onClickProp,...rest-}: Pick<TopNavMegaMenuProps, 'label' | 'items' | 'featured'> &+}: Pick<TopNavMegaMenuProps, 'ref' | 'label' | 'items' | 'featured'> &BaseProps<HTMLButtonElement>) {const [isExpanded, setIsExpanded] = useState(false);const pressable = usePressFeedback();@@ -582,6 +584,7 @@ function DrawerMegaMenu({<div {...stylex.props(styles.drawerSection)}>{/* Header toggle — same pattern as TopNavMenu drawer */}<button+ ref={ref}type="button"{...rest}onClick={composeEventHandlers(onClickProp, () =>diff --git a/packages/core/src/TopNav/TopNavMenu.test.tsx b/packages/core/src/TopNav/TopNavMenu.test.tsxindex 12f83e5cb5..4338bf9245 100644--- a/packages/core/src/TopNav/TopNavMenu.test.tsx+++ b/packages/core/src/TopNav/TopNavMenu.test.tsx@@ -9,6 +9,7 @@* SYNC: When TopNavMenu changes, update tests to match new behavior*/+import {createRef} from 'react';import {beforeEach, describe, it, expect, vi} from 'vitest';import {render, screen, fireEvent, act} from '@testing-library/react';import userEvent from '@testing-library/user-event';@@ -322,6 +323,22 @@ describe('TopNavMenu pass-through props', () => {expect(trigger).toHaveAttribute('data-source', 'nav');});+ it('forwards its ref to the trigger button', () => {+ const ref = createRef<HTMLButtonElement>();+ render(<TopNavMenu ref={ref} label="Products" items={mockItems} />);+ expect(ref.current).toBe(screen.getByRole('button', {name: 'Products'}));+ });++ it('forwards its ref to the drawer trigger', () => {+ const ref = createRef<HTMLButtonElement>();+ render(+ <TopNavRenderContext value="drawer">+ <TopNavMenu ref={ref} label="Products" items={mockItems} />+ </TopNavRenderContext>,+ );+ expect(ref.current).toBe(screen.getByRole('button', {name: /Products/}));+ });+it('keeps its own popup wiring when a caller passes the same attributes', () => {render(<TopNavMenudiff --git a/packages/core/src/TopNav/TopNavMenu.tsx b/packages/core/src/TopNav/TopNavMenu.tsxindex ddb0be08dd..dfee54d047 100644--- a/packages/core/src/TopNav/TopNavMenu.tsx+++ b/packages/core/src/TopNav/TopNavMenu.tsx@@ -477,6 +477,7 @@ export function TopNavMenu({return (<div {...stylex.props(drawerStyles.section)}><button+ ref={ref}type="button"{...rest}onMouseEnter={onMouseEnterProp}