Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix(MoreMenu): add xdsClassName for theme targeting (#672)

Cindy Zhange4f89bbfb73f
diff --git a/packages/core/src/MoreMenu/XDSMoreMenu.test.tsx b/packages/core/src/MoreMenu/XDSMoreMenu.test.tsx
index e55c91de59..489552da37 100644
--- a/packages/core/src/MoreMenu/XDSMoreMenu.test.tsx
+++ b/packages/core/src/MoreMenu/XDSMoreMenu.test.tsx
@@ -184,4 +184,10 @@ describe('XDSMoreMenu', () => {
expect(button).toBeInTheDocument();
expect(button.tagName).toBe('BUTTON');
});
+
+ it('renders xds-more-menu class on dropdown panel for theme targeting', () => {
+ render(<XDSMoreMenu items={defaultItems} />);
+ const menu = screen.getByRole('menu', {hidden: true});
+ expect(menu.className).toContain('xds-more-menu');
+ });
});
diff --git a/packages/core/src/MoreMenu/XDSMoreMenu.tsx b/packages/core/src/MoreMenu/XDSMoreMenu.tsx
index b9aa8f35ab..d41f231fa0 100644
--- a/packages/core/src/MoreMenu/XDSMoreMenu.tsx
+++ b/packages/core/src/MoreMenu/XDSMoreMenu.tsx
@@ -44,6 +44,7 @@ import {
typographyVars,
textSizeVars,
} from '../theme/tokens.stylex';
+import {xdsClassName, mergeProps} from '../utils';
// =============================================================================
// Styles
@@ -475,7 +476,13 @@ export function XDSMoreMenu({
data-testid={testId}
/>
{layer.render(
- <div id={menuId} role="menu" {...stylex.props(styles.dropdown)}>
+ <div
+ id={menuId}
+ role="menu"
+ {...mergeProps(
+ xdsClassName('more-menu'),
+ stylex.props(styles.dropdown),
+ )}>
{renderOptions()}
</div>,
{