An open source design system that's fully customizable and agent ready
TypeScript
fix(carousel): make the scroll container keyboard-focusable (#3544)
Cindy Zhange67f42210017
diff --git a/.changeset/carousel-scroll-focusable.md b/.changeset/carousel-scroll-focusable.mdnew file mode 100644index 0000000000..c9c6acf5c6--- /dev/null+++ b/.changeset/carousel-scroll-focusable.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] Carousel: make the horizontal scroll container keyboard-focusable (`tabIndex={0}`) so keyboard-only users can scroll it with arrow keys. Previously the scrollable region had no keyboard access (axe: scrollable-region-focusable). (#3343)++@cixzhangdiff --git a/packages/core/src/Carousel/Carousel.test.tsx b/packages/core/src/Carousel/Carousel.test.tsxindex 44b28b7ad1..7a6c80e200 100644--- a/packages/core/src/Carousel/Carousel.test.tsx+++ b/packages/core/src/Carousel/Carousel.test.tsx@@ -38,6 +38,19 @@ describe('Carousel', () => {expect(region).toHaveAttribute('aria-roledescription', 'carousel');});+ it('makes the scroll container keyboard-focusable', () => {+ render(+ <Carousel aria-label="Photos">+ <div>Item</div>+ </Carousel>,+ );+ // The inner scroll container overflows, so it must be reachable by+ // keyboard (axe: scrollable-region-focusable).+ const region = screen.getByRole('region', {name: 'Photos'});+ const scroller = region.firstElementChild;+ expect(scroller).toHaveAttribute('tabindex', '0');+ });+it('applies data-testid', () => {render(<Carousel data-testid="my-carousel">diff --git a/packages/core/src/Carousel/Carousel.tsx b/packages/core/src/Carousel/Carousel.tsxindex 8fbd8c67d2..78e3188323 100644--- a/packages/core/src/Carousel/Carousel.tsx+++ b/packages/core/src/Carousel/Carousel.tsx@@ -340,6 +340,7 @@ export function Carousel({{...htmlProps}><divref={composedRef}+ tabIndex={0}{...stylex.props(styles.scroller,gapStyles[gap],