An open source design system that's fully customizable and agent ready
TypeScript
fix(Slider): range thumb names come from the catalog (#9023)
Cindy Zhangec128c4110bb
diff --git a/.changeset/slider-thumb-names-i18n.md b/.changeset/slider-thumb-names-i18n.mdnew file mode 100644index 0000000000..7e1936dfcd--- /dev/null+++ b/.changeset/slider-thumb-names-i18n.md@@ -0,0 +1,7 @@+---+'@astryxdesign/core': patch+---++[fix] Slider: a range slider's thumb names ("Minimum value" and "Maximum value", announced to screen readers) now come from the message catalog (`@astryx.slider.minimumThumb`, `@astryx.slider.maximumThumb`), so they follow the app's locale.++@cixzhangdiff --git a/packages/core/locales/en.json b/packages/core/locales/en.jsonindex efb2a761cb..fce94c3da8 100644--- a/packages/core/locales/en.json+++ b/packages/core/locales/en.json@@ -791,6 +791,14 @@"defaultMessage": "Open menu","description": "Screen-reader-only label on the `⋯` overflow-menu button embedded in a SideNav section heading. Same string as `topNav.heading.openMenu` — translations may share."},+ "@astryx.slider.minimumThumb": {+ "defaultMessage": "Minimum value",+ "description": "Accessible name of the lower thumb of a range Slider (two thumbs), announced together with the Slider's own label, for example \"Price range, Minimum value, 20\". Never shown on screen."+ },+ "@astryx.slider.maximumThumb": {+ "defaultMessage": "Maximum value",+ "description": "Accessible name of the upper thumb of a range Slider (two thumbs), announced together with the Slider's own label, for example \"Price range, Maximum value, 80\". Never shown on screen."+ },"@astryx.tabList.label": {"defaultMessage": "Tabs","description": "Screen-reader-only fallback name for a horizontal tab bar. Plural noun; \"Tabs\" here = UI tab panels, not browser tabs or the Tab key."diff --git a/packages/core/src/Slider/Slider.test.tsx b/packages/core/src/Slider/Slider.test.tsxindex 4d1caeb88d..26798f89a4 100644--- a/packages/core/src/Slider/Slider.test.tsx+++ b/packages/core/src/Slider/Slider.test.tsx@@ -9,6 +9,7 @@* SYNC: When Slider.tsx changes, update tests to match new behavior*/+import {InternationalizationProvider} from '../i18n';import {useState} from 'react';import {describe, it, expect, vi, beforeEach} from 'vitest';import {render, screen, act, fireEvent, waitFor} from '@testing-library/react';@@ -75,6 +76,24 @@ describe('Slider', () => {expect(sliders[1]).toHaveAccessibleName('Maximum value');});+ it('translates the range thumb names under another locale', () => {+ render(+ <InternationalizationProvider+ locale="fr"+ overrides={{+ fr: {+ '@astryx.slider.minimumThumb': 'Valeur minimale',+ '@astryx.slider.maximumThumb': 'Valeur maximale',+ },+ }}>+ <Slider label="Prix" value={[20, 80] as [number, number]} />+ </InternationalizationProvider>,+ );+ const sliders = screen.getAllByRole('slider');+ expect(sliders[0]).toHaveAccessibleName('Valeur minimale');+ expect(sliders[1]).toHaveAccessibleName('Valeur maximale');+ });+it('sets aria-valuetext with formatValue', () => {render(<Slider label="Temperature" value={72} formatValue={v => `${v}°F`} />,diff --git a/packages/core/src/Slider/Slider.tsx b/packages/core/src/Slider/Slider.tsxindex 916672579c..4aec05427a 100644--- a/packages/core/src/Slider/Slider.tsx+++ b/packages/core/src/Slider/Slider.tsx@@ -59,6 +59,7 @@ import {themeProps} from '../utils/themeProps';import {useMergedRefs} from '../hooks/useMergedRefs';import {useResolvedRequired} from '../hooks/useResolvedRequired';+import {useTranslator} from '../i18n';// =============================================================================// Types// =============================================================================@@ -513,6 +514,7 @@ export function Slider({ref, ...props}: SliderProps) {'aria-describedby': ariaDescribedByProp,...restWithRange} = props;+ const t = useTranslator();const {minStepsBetweenThumbs: _minSteps, ...restProps} =restWithRange as typeof restWithRange & {minStepsBetweenThumbs?: number};const {rest, container} = useFieldInputStyling('Slider', restProps, {@@ -983,8 +985,8 @@ export function Slider({ref, ...props}: SliderProps) {// name from the visible label element via aria-labelledby.const thumbLabel = isRange? thumbIndex === 0- ? 'Minimum value'- : 'Maximum value'+ ? t('@astryx.slider.minimumThumb')+ : t('@astryx.slider.maximumThumb'): undefined;// ARIA bounds must agree with the movement clamping in updateValue: in