Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix: stabilize default resize snaps (#5276)

nynexman4464f24d0e9c99f9
diff --git a/.changeset/stable-resizable-snaps.md b/.changeset/stable-resizable-snaps.md
new file mode 100644
index 0000000000..31f3b160e5
--- /dev/null
+++ b/.changeset/stable-resizable-snaps.md
@@ -0,0 +1,7 @@
+---
+'@astryxdesign/core': patch
+---
+
+[fix] Keep useResizable callbacks stable when snap points are omitted.
+
+@nynexman4464
diff --git a/packages/core/src/Resizable/useResizable.test.ts b/packages/core/src/Resizable/useResizable.test.ts
index 2b01ee3422..d24e9e7c6f 100644
--- a/packages/core/src/Resizable/useResizable.test.ts
+++ b/packages/core/src/Resizable/useResizable.test.ts
@@ -400,3 +400,22 @@ describe('useResizable live collapse state', () => {
expect(onCollapseChange).toHaveBeenCalledExactlyOnceWith(true);
});
});
+
+describe('useResizable identity', () => {
+ it('keeps callbacks stable when optional snaps are omitted', () => {
+ const {result, rerender} = renderHook(() =>
+ useResizable({defaultSize: 200, minSizePx: 100, maxSizePx: 400}),
+ );
+ const first = {
+ expand: result.current.expand,
+ resize: result.current.resize,
+ snaps: result.current.props._snaps,
+ };
+
+ rerender();
+
+ expect(result.current.expand).toBe(first.expand);
+ expect(result.current.resize).toBe(first.resize);
+ expect(result.current.props._snaps).toBe(first.snaps);
+ });
+});
diff --git a/packages/core/src/Resizable/useResizable.ts b/packages/core/src/Resizable/useResizable.ts
index 10afecf2b2..56809dfd97 100644
--- a/packages/core/src/Resizable/useResizable.ts
+++ b/packages/core/src/Resizable/useResizable.ts
@@ -253,13 +253,15 @@ function useSingleResizable(config: UseResizableSingleConfig): ResizableRegion {
maxSizePx = Infinity,
collapsible = false,
collapsedSize = DEFAULT_COLLAPSED_SIZE,
- snaps = [],
+ snaps: configuredSnaps,
autoSaveId,
defaultIsCollapsed,
isCollapsed: controlledIsCollapsed,
onSizeChange,
onCollapseChange,
} = config;
+ const emptySnapsRef = useRef<number[]>([]);
+ const snaps = configuredSnaps ?? emptySnapsRef.current;
const resolvedDefault = resolveDefaultSize(defaultSize);
const persisted = autoSaveId ? loadPersistedState(autoSaveId) : null;