An open source design system that's fully customizable and agent ready
TypeScript
test(CommandPalette): the lookup-work test finds its options without a visibility check per option (#8725)
Christopher Chedeauf3e48f1975c0
diff --git a/packages/core/src/CommandPalette/CommandPalette.perf.test.ts b/packages/core/src/CommandPalette/CommandPalette.perf.test.tsindex 8472cd16e9..24d6ed963f 100644--- a/packages/core/src/CommandPalette/CommandPalette.perf.test.ts+++ b/packages/core/src/CommandPalette/CommandPalette.perf.test.ts@@ -69,11 +69,15 @@ describe('CommandPalette delegated mouseover performance', () => {searchSource: createStaticSource(items),}),);+ // The options with {hidden: true}: the default query checks each one's+ // visibility through jsdom's getComputedStyle, its ancestors' included,+ // which takes seconds at 500 options (and many times that on a busy+ // machine), where this test measures lookup reads. The combobox query+ // below still checks that the open palette is visible.+ const allOptions = () => view.getAllByRole('option', {hidden: true});try {- await waitFor(() =>- expect(view.getAllByRole('option')).toHaveLength(count),- );- const options = view.getAllByRole('option');+ await waitFor(() => expect(allOptions()).toHaveLength(count));+ const options = allOptions();const targets = [0, count - 1, Math.floor(count / 2), 0];for (const index of targets) {const option = options[index];