Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

fix: bug bash alignment — SideNav 8px spacing, Breadcrumbs text centering (#525)

Cindy Zhangf44e25c8792c
diff --git a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
index 94d16560e9..3aec738709 100644
--- a/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
+++ b/packages/core/src/Breadcrumbs/XDSBreadcrumbItem.tsx
@@ -86,11 +86,15 @@ const itemStyles = stylex.create({
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-1'],
+ lineHeight: lineHeightVars['--leading-snug'],
+ paddingBlock: spacingVars['--spacing-1'],
},
link: {
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-1'],
+ lineHeight: lineHeightVars['--leading-snug'],
+ paddingBlock: spacingVars['--spacing-1'],
textDecoration: {
default: 'none',
':hover': {
diff --git a/packages/core/src/Breadcrumbs/XDSBreadcrumbs.tsx b/packages/core/src/Breadcrumbs/XDSBreadcrumbs.tsx
index 13cf4befaa..b81675256e 100644
--- a/packages/core/src/Breadcrumbs/XDSBreadcrumbs.tsx
+++ b/packages/core/src/Breadcrumbs/XDSBreadcrumbs.tsx
@@ -138,6 +138,7 @@ const separatorStyles = stylex.create({
alignItems: 'center',
color: colorVars['--color-text-secondary'],
lineHeight: lineHeightVars['--leading-snug'],
+ paddingBlock: spacingVars['--spacing-1'],
userSelect: 'none',
},
defaultSize: {
diff --git a/packages/core/src/SideNav/XDSSideNav.tsx b/packages/core/src/SideNav/XDSSideNav.tsx
index 847c9ed374..6feb8d2633 100644
--- a/packages/core/src/SideNav/XDSSideNav.tsx
+++ b/packages/core/src/SideNav/XDSSideNav.tsx
@@ -46,14 +46,14 @@ const styles = stylex.create({
backgroundColor: colorVars['--color-surface'],
},
topContent: {
- paddingInline: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-1'],
},
scrollable: {
flex: 1,
overflowY: 'auto',
overflowX: 'hidden',
- paddingInline: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-1'],
},
stickyBottom: {
@@ -64,14 +64,14 @@ const styles = stylex.create({
backgroundColor: colorVars['--color-surface'],
},
footer: {
- paddingInline: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-2'],
},
footerIcons: {
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-1'],
- paddingInline: spacingVars['--spacing-1'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-2'],
borderBlockStart: `1px solid ${colorVars['--color-divider']}`,
},
diff --git a/packages/core/src/SideNav/XDSSideNavHeading.tsx b/packages/core/src/SideNav/XDSSideNavHeading.tsx
index b041e349fd..2e59631863 100644
--- a/packages/core/src/SideNav/XDSSideNavHeading.tsx
+++ b/packages/core/src/SideNav/XDSSideNavHeading.tsx
@@ -43,7 +43,7 @@ const styles = stylex.create({
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-2'],
- paddingInline: spacingVars['--spacing-3'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-3'],
boxSizing: 'border-box',
textDecoration: 'none',
@@ -66,7 +66,7 @@ const styles = stylex.create({
},
},
interactiveInset: {
- marginInline: spacingVars['--spacing-1'],
+ marginInline: spacingVars['--spacing-2'],
marginBlock: spacingVars['--spacing-1'],
},
icon: {
diff --git a/packages/core/src/SideNav/XDSSideNavItem.tsx b/packages/core/src/SideNav/XDSSideNavItem.tsx
index cdb14cf4b5..28ef6bbacf 100644
--- a/packages/core/src/SideNav/XDSSideNavItem.tsx
+++ b/packages/core/src/SideNav/XDSSideNavItem.tsx
@@ -46,7 +46,7 @@ const styles = stylex.create({
alignItems: 'center',
gap: spacingVars['--spacing-2'],
width: '100%',
- paddingInline: spacingVars['--spacing-3'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-2'],
borderRadius: radiusVars['--radius-element'],
borderWidth: 0,
diff --git a/packages/core/src/SideNav/XDSSideNavSection.tsx b/packages/core/src/SideNav/XDSSideNavSection.tsx
index e958b4d3fe..063f3884de 100644
--- a/packages/core/src/SideNav/XDSSideNavSection.tsx
+++ b/packages/core/src/SideNav/XDSSideNavSection.tsx
@@ -39,7 +39,7 @@ const styles = stylex.create({
display: 'flex',
alignItems: 'center',
gap: spacingVars['--spacing-2'],
- paddingInline: spacingVars['--spacing-3'],
+ paddingInline: spacingVars['--spacing-2'],
paddingBlock: spacingVars['--spacing-1'],
cursor: 'default',
userSelect: 'none',