Skip to content

An open source design system that's fully customizable and agent ready

TypeScript

ci: fold fixture-contrast into test-build (#8916)

Cindy Zhangf4abc97c0a6e
diff --git a/.github/scripts/ci-tooling-routing.test.mjs b/.github/scripts/ci-tooling-routing.test.mjs
index e15f9c6f53..32de7d35be 100644
--- a/.github/scripts/ci-tooling-routing.test.mjs
+++ b/.github/scripts/ci-tooling-routing.test.mjs
@@ -116,7 +116,16 @@ describe('Node-tooling CI routing', () => {
'node .github/scripts/theme-layer-cascade.js',
'ASTRYX_STYLEX_BROWSER=1 vitest run scripts/stylex-module-resolution.browser.test.mjs --project node --maxWorkers=1',
]);
- expect(ci.jobs['fixture-contrast'].if).toContain(TOOLING_FALSE);
+ // The vibe-tests fixtures share test-build's Playwright runner, and its
+ // Node-tooling skip.
+ expect(ci.jobs['fixture-contrast']).toBeUndefined();
+ for (const name of [
+ 'Verify canonical setup compositions',
+ 'Verify guest fixture contrast',
+ ]) {
+ expect(step(ci.jobs['test-build'], name)).toBeDefined();
+ }
+ expect(ci.jobs['test-build'].if).toContain(TOOLING_FALSE);
// The merge-base size build is heavy build work and stays off the
// Node-tooling, docsite, and spec lanes.
expect(ci.jobs['size-base'].if).toContain(BROAD_ONLY);
diff --git a/.github/scripts/heavy-caps-action.test.mjs b/.github/scripts/heavy-caps-action.test.mjs
index e81d2ace97..113240edf7 100644
--- a/.github/scripts/heavy-caps-action.test.mjs
+++ b/.github/scripts/heavy-caps-action.test.mjs
@@ -401,7 +401,6 @@ describe('per-author caps on heavy suites (spec:AST-030 FR16)', () => {
job.steps?.some(isCaps),
);
expect(heavyJobs.map(([id]) => id).sort()).toEqual([
- 'fixture-contrast',
'pr-interaction',
'test-build',
]);
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 99839a7980..634fd70c0d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2025,34 +2025,9 @@ jobs:
- name: Run Build package contracts
run: pnpm test:build
- # Guest token boundaries cross portals and the host light/dark cascade. This
- # requires a production browser render; source and jsdom checks cannot prove
- # which custom properties paint the portaled surfaces.
- fixture-contrast:
- needs: [check-scope]
- if: github.event_name != 'workflow_dispatch' && needs.check-scope.outputs.docsite_only != 'true' && needs.check-scope.outputs.spec_only != 'true' && needs.check-scope.outputs.tooling_only != 'true'
- runs-on: ubuntu-24.04-arm
- timeout-minutes: 15
- permissions:
- # The heavy-suite caps read the author's pull requests and runs.
- actions: read
- contents: read
- pull-requests: read
- steps:
- - uses: actions/checkout@v7
-
- - name: Per-author heavy-suite caps
- uses: ./.github/actions/heavy-caps
-
- # The daily heavy-run cap counts this step (spec:AST-030 FR16).
- - name: Heavy suite runs
- run: 'true'
-
- - uses: ./.github/actions/setup
-
- - name: Install Playwright
- run: npx playwright install chromium
-
+ # The vibe-tests fixtures share this Playwright-equipped runner: the
+ # canonical setup compositions and the guest fixture contrast need a
+ # production browser render.
- name: Verify canonical setup compositions
env:
ASTRYX_CANONICAL_SETUP_BROWSER: '1'
@@ -2747,7 +2722,6 @@ jobs:
interaction-scope,
pr-interaction,
test-build,
- fixture-contrast,
visual-scout,
pr-visual,
pr-rtl-shard,