An open source design system that's fully customizable and agent ready
TypeScript
feat(Table): change textOverflow default from 'wrap' to 'truncate' (#2096)
Cindy Zhangf665a6e988bc
diff --git a/packages/core/src/Table/XDSTable.test.tsx b/packages/core/src/Table/XDSTable.test.tsxindex 2e4b26d940..f73541adec 100644--- a/packages/core/src/Table/XDSTable.test.tsx+++ b/packages/core/src/Table/XDSTable.test.tsx@@ -732,9 +732,18 @@ describe('XDSTable', () => {);});- it('wraps text by default (textOverflow="wrap")', () => {+ it('truncates text by default (textOverflow="truncate")', () => {render(<XDSTable data={users} columns={columns} />);const cells = screen.getAllByRole('cell');+ // Default-rendered cells contain an XDSText child element (a <span>)+ const textEl = cells[0].querySelector('span');+ expect(textEl).toBeTruthy();+ expect(textEl).toHaveTextContent('Alice');+ });++ it('wraps text when textOverflow="wrap"', () => {+ render(<XDSTable data={users} columns={columns} textOverflow="wrap" />);+ const cells = screen.getAllByRole('cell');// In wrap mode, no title attribute is added (text is visible, not hidden)expect(cells[0]).not.toHaveAttribute('title');// Content is presentdiff --git a/packages/core/src/Table/XDSTable.tsx b/packages/core/src/Table/XDSTable.tsxindex c4862d6ada..7c7351896b 100644--- a/packages/core/src/Table/XDSTable.tsx+++ b/packages/core/src/Table/XDSTable.tsx@@ -90,11 +90,11 @@ export interface XDSTableProps<T extends Record<string, unknown>> extends Omit<** Header cells always truncate regardless of this setting.*- * @default 'wrap'+ * @default 'truncate'** @example* ```- * <XDSTable data={logs} columns={columns} textOverflow="truncate" />+ * <XDSTable data={logs} columns={columns} textOverflow="wrap" />* ```*/textOverflow?: 'wrap' | 'truncate';@@ -195,7 +195,7 @@ function XDSTableInner<T extends Record<string, unknown>>({isStriped = false,hasHover = false,verticalAlign = 'middle',- textOverflow = 'wrap',+ textOverflow = 'truncate',plugins: userPlugins,columns,data,diff --git a/packages/core/src/Table/table.stylex.ts b/packages/core/src/Table/table.stylex.tsindex b827fa134f..11749b16f9 100644--- a/packages/core/src/Table/table.stylex.ts+++ b/packages/core/src/Table/table.stylex.ts@@ -43,7 +43,7 @@ export const overflowStyles = stylex.create({/*** Wrap styles for table cells.*- * Applied at the <td>/<th> level when textOverflow is 'wrap' (the default).+ * Applied at the <td>/<th> level when textOverflow is 'wrap'.* Text wraps naturally and the row grows taller to fit. No content is hidden.*/export const wrapStyles = stylex.create({diff --git a/packages/core/src/Table/types.ts b/packages/core/src/Table/types.tsindex 49b9f6196c..a80812d226 100644--- a/packages/core/src/Table/types.ts+++ b/packages/core/src/Table/types.ts@@ -404,7 +404,7 @@ export interface XDSBaseTableProps<T extends Record<string, unknown>> {* Only affects cells using the default renderer (no `renderCell`).* Cells with `renderCell` control their own overflow behavior.*- * @default 'wrap'+ * @default 'truncate'*/textOverflow?: 'wrap' | 'truncate';/**